path translation fixes and tests

Author: dwasinge

src/main/java/com/redhat/labs/omp/utils/GitLabPathUtils.java

@@ -1,7 +1,12 @@
 package com.redhat.labs.omp.utils;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 public class GitLabPathUtils {
 
+    private static Logger LOGGER = LoggerFactory.getLogger(GitLabPathUtils.class);
+
     public static String generateValidPath(String input) {
 
         if (null == input || input.trim().length() == 0) {
@@ -11,9 +16,6 @@ public static String generateValidPath(String input) {
         // trim
         String path = input.trim();
 
-        // remove leading or trailing hyphens
-        path = path.replaceFirst("^-*", "").replaceFirst("-*$", "");
-
         // turn to lowercase
         path = path.toLowerCase();
 
@@ -23,6 +25,14 @@ public static String generateValidPath(String input) {
         // remove any characters other than A-Z, a-z, 0-9, ., -
         path = path.replaceAll("[^A-Za-z0-9-\\.]", "");
 
+        // remove leading or trailing hyphens
+        path = path.replaceFirst("^-*", "").replaceFirst("-*$", "");
+
+        // remove ending '.', '.git', or '.atom'
+        path = path.replaceAll("(\\.|\\.git|\\.atom)$", "");
+
+        LOGGER.debug("input name {}, converted to path {}", input, path);
+
         return path;
 
     }

src/test/java/com/redhat/labs/utils/GitLabPathUtilsTest.java

@@ -6,6 +6,10 @@
 
 public class GitLabPathUtilsTest {
 
+//    Groups Requirements:
+//        Name can contain only letters, digits, emojis, '_', '.', dash, space, parenthesis. It must start with letter, digit, emoji or '_'.
+//        Path can contain only letters, digits, '_', '-' and '.'. Cannot start with '-' or end in '.', '.git' or '.atom'
+
     @Test
     public void testGenerateValidInputNull() {
 
@@ -98,4 +102,43 @@ public void testGenerateValidPathFullReplace() {
 
     }
 
+    @Test
+    public void testGenerateValidWithEndingPeriod() {
+
+        // given
+        String input = "_My Favørite Proj.";
+
+        // when
+        String output = GitLabPathUtils.generateValidPath(input);
+
+        Assertions.assertEquals("my-favrite-proj", output);
+
+    }
+
+    @Test
+    public void testGenerateValidWithEndingPeriodGit() {
+
+        // given
+        String input = "_My Favørite Proj.git";
+
+        // when
+        String output = GitLabPathUtils.generateValidPath(input);
+
+        Assertions.assertEquals("my-favrite-proj", output);
+
+    }
+
+    @Test
+    public void testGenerateValidWithEndingPeriodAtom() {
+
+        // given
+        String input = "_My Favørite Proj.atom";
+
+        // when
+        String output = GitLabPathUtils.generateValidPath(input);
+
+        Assertions.assertEquals("my-favrite-proj", output);
+
+    }
+
 }