support a list of uuids to migrate

Author: mcanoy

src/main/java/com/redhat/labs/lodestar/resource/EngagementResource.java

@@ -88,7 +88,7 @@ public Response findAllEngagements(@Context UriInfo uriInfo, @QueryParam("pagina
                     includeCommits);
             builder.entity(ePage.getEngagements());
             builder.links(ePage.getLinks(uriInfo.getAbsolutePathBuilder()));
-            ePage.getHeaders().entrySet().stream().forEach(e -> builder.header(e.getKey(), e.getValue()));
+            ePage.getHeaders().entrySet().forEach(e -> builder.header(e.getKey(), e.getValue()));
 
         } else {
             builder.entity(engagementService.getAllEngagements(includeStatus, includeCommits));

src/main/java/com/redhat/labs/lodestar/resource/MigrationResource.java

@@ -3,6 +3,7 @@
 import javax.inject.Inject;
 import javax.ws.rs.PUT;
 import javax.ws.rs.Path;
+import javax.ws.rs.Produces;
 import javax.ws.rs.QueryParam;
 import javax.ws.rs.core.Response;
 
@@ -11,26 +12,37 @@
 import org.eclipse.microprofile.openapi.annotations.tags.Tag;
 
 import com.redhat.labs.lodestar.service.MigrationService;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
 
 @Path("/api/migrate")
 @Tag(name = "Migration", description = "Migration services")
 public class MigrationResource {
+    private static final Logger LOGGER = LoggerFactory.getLogger(MigrationResource.class);
 
     @Inject
     MigrationService migrationService;
 
     @PUT
     @Timed(name = "performedMigration", description = "How much time it takes to migrate", unit = MetricUnits.MILLISECONDS)
+    @Produces("application/json")
     public Response migrate(@QueryParam(value = "participants") boolean migrateParticipants,
             @QueryParam("artifacts") boolean migrateArtifacts,
-            @QueryParam("uuids") boolean migrateUuids,
+            @QueryParam("projects") boolean migrateUuids,
             @QueryParam("hosting") boolean migrateHosting,
             @QueryParam("engagements") boolean migrateEngagements,
             @QueryParam("overwrite") boolean overwrite,
-            @QueryParam("uuid") String uuid) {
-        
-        migrationService.migrate(migrateUuids, migrateParticipants, migrateArtifacts, migrateHosting, migrateEngagements,
-                overwrite, uuid);
+            @QueryParam("uuids") List<String> uuids) {
+
+        try {
+            migrationService.migrate(migrateUuids, migrateParticipants, migrateArtifacts, migrateHosting, migrateEngagements,
+                    overwrite, uuids);
+        } catch (Exception ex) {
+            LOGGER.error("Migration did not complete successfully", ex);
+            return Response.status(Response.Status.BAD_REQUEST).entity("{ \"message\": \"Migration did not complete successfully\"}").build();
+        }
 
         return Response.ok().build();
 

src/main/java/com/redhat/labs/lodestar/service/FileService.java

@@ -52,13 +52,11 @@ public Optional<File> createFile(Integer projectId, String filePath, File file)
     // create multiple files
     public boolean createFiles(Integer projectId, CommitMultiple commit) {
 
-        Response response = null;
-
         // encode actions in commit
         commit.encodeActions();
 
         // call gitlab api to commit
-        response = gitLabService.commitMultipleFiles(projectId, commit);
+        Response response = gitLabService.commitMultipleFiles(projectId, commit);
 
         // decode actions in commit
         commit.decodeActions();
@@ -105,7 +103,7 @@ public Optional<File> deleteFile(Integer projectId, String filePath, String ref)
             // set branch
             file.setBranch(ref);
             // add commit message
-            file.setCommitMessage(String.format("git api deleted file. {}", filePath));
+            file.setCommitMessage(String.format("git api deleted file. %s", filePath));
 
             gitLabService.deleteFile(projectId, filePath, file);
         }

src/main/java/com/redhat/labs/lodestar/service/MigrationService.java

@@ -58,9 +58,9 @@ public class MigrationService {
      * engagements that haven't been migrated. 
      */
     public void migrate(boolean migrateUuids, boolean migrateParticipants, boolean migrateArtifacts, boolean migrateHosting,
-                        boolean migrateEngagements, boolean overwrite, String uuid) {
+                        boolean migrateEngagements, boolean overwrite, List<String> uuids) {
         LOGGER.debug("uuids {} participants {} artifacts {} hosting {} engagements {} overwrite {} uuid {}", migrateUuids,
-                migrateParticipants, migrateArtifacts, migrateHosting, migrateEngagements, overwrite, uuid);
+                migrateParticipants, migrateArtifacts, migrateHosting, migrateEngagements, overwrite, uuids.size());
 
         getAllEngagements(); //hydrate before stream
 
@@ -71,16 +71,20 @@ public void migrate(boolean migrateUuids, boolean migrateParticipants, boolean m
         }
 
         LOGGER.info("Start Migrate content");
-        migrateAll(migrateParticipants, migrateArtifacts, migrateHosting, migrateEngagements, overwrite, uuid);
+        migrateAll(migrateParticipants, migrateArtifacts, migrateHosting, migrateEngagements, overwrite, uuids);
         LOGGER.info("End Migrate content");
 
     }
 
     private void migrateAll(boolean migrateParticipants, boolean migrateArtifacts, boolean migrateHosting,
-                            boolean migrateEngagements, boolean overwrite, String uuid ) {
-        getAllEngagements().values().forEach(e -> {
-            LOGGER.debug("Migrating {}", e.getUuid());
-            if(uuid == null || e.getUuid().equals(uuid)) {
+                            boolean migrateEngagements, boolean overwrite, List<String> uuids ) {
+        int counter = 0;
+        for(Engagement e : getAllEngagements().values()) {
+
+            if(uuids.isEmpty() || uuids.contains(e.getUuid())) {
+                counter++;
+                LOGGER.debug("Migrating ({}) {}", counter, e.getUuid());
+                
                 List<Action> actions = new ArrayList<>();
                 String content;
                 if(migrateEngagements) {
@@ -112,7 +116,7 @@ private void migrateAll(boolean migrateParticipants, boolean migrateArtifacts, b
                     fileService.createFiles(e.getProjectId(), commit);
                 }
             }
-        });
+        }
     }
 
     /**

src/test/java/com/redhat/labs/lodestar/service/MigrationServiceTest.java

@@ -87,12 +87,12 @@ public static void setup() {
     @Test 
     void migrate() {
         migrationService.migrate(false, false, false, false, false,
-                false, null);
+                false, Collections.emptyList());
 
         Mockito.verify(projectServiceMock, Mockito.never()).updateProject(Mockito.any());
         Mockito.verify(fileServiceMock, Mockito.never()).createFile(Mockito.anyInt(), Mockito.eq("engagement/participants.json"), Mockito.any(File.class));
 
-        migrationService.migrate(true, true, true, true, true, false, null);
+        migrationService.migrate(true, true, true, true, true, false, Collections.emptyList());
 
         Mockito.verify(projectServiceMock, Mockito.times(2)).updateProject(Mockito.any());
         Mockito.verify(fileServiceMock, Mockito.times(3)).createFiles(Mockito.anyInt(), Mockito.any(CommitMultiple.class));