Skip to content

Commit 4519904

Browse files
authored
Switch from env to envfrom (#27)
* Switch from env to envfrom so we don't have to keep messing with the deployment * Should be secret, not configmap
1 parent 1d8be81 commit 4519904

File tree

1 file changed

+3
-21
lines changed

1 file changed

+3
-21
lines changed

deployment/templates/deploymentconfig.yaml

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -27,27 +27,9 @@ spec:
2727
deploymentconfig: {{ .Values.name }}
2828
spec:
2929
containers:
30-
- env:
31-
- name: GITLAB_PERSONAL_ACCESS_TOKEN
32-
valueFrom:
33-
secretKeyRef:
34-
name: omp-gitlab-configuration
35-
key: GITLAB_PERSONAL_ACCESS_TOKEN
36-
- name: TEMPLATE_REPOSITORY_ID
37-
valueFrom:
38-
secretKeyRef:
39-
name: omp-gitlab-configuration
40-
key: TEMPLATE_REPOSITORY_ID
41-
- name: RESIDENCIES_PARENT_REPOSITORIES_ID
42-
valueFrom:
43-
secretKeyRef:
44-
name: omp-gitlab-configuration
45-
key: RESIDENCIES_PARENT_REPOSITORIES_ID
46-
- name: GITLAB_API_URL
47-
valueFrom:
48-
secretKeyRef:
49-
name: omp-gitlab-configuration
50-
key: GITLAB_API_URL
30+
- envFrom:
31+
- secretRef:
32+
name: omp-gitlab-configuration
5133
image: "{{ .Values.imageName }}:{{ .Values.imageTag }}"
5234
imagePullPolicy: Always
5335
name: {{ .Values.name }}

0 commit comments

Comments
 (0)