Skip to content

Commit 6c30375

Browse files
authored
ensure lower case file action (#116)
* ensure lower case file action * File action test
1 parent 596c92e commit 6c30375

File tree

2 files changed

+23
-10
lines changed

2 files changed

+23
-10
lines changed

src/main/java/com/redhat/labs/lodestar/models/gitlab/FileAction.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ public enum FileAction {
55

66
CREATE,
77
UPDATE,
8-
DELETE
8+
DELETE;
9+
10+
@Override public String toString() {
11+
return name().toLowerCase();
12+
}
913

1014
}

src/test/java/com/redhat/labs/lodestar/service/FileServiceTest.java

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77

88
import org.junit.jupiter.api.Assertions;
99
import org.junit.jupiter.api.Test;
10-
import org.wildfly.common.Assert;
1110

1211
import com.redhat.labs.lodestar.models.gitlab.File;
12+
import com.redhat.labs.lodestar.models.gitlab.FileAction;
1313

1414
import io.quarkus.test.junit.QuarkusTest;
1515

@@ -20,18 +20,27 @@ class FileServiceTest {
2020
FileService fileService;
2121

2222

23+
24+
@Test
25+
void testFileAction() {
26+
Assertions.assertEquals("create", FileAction.CREATE.toString());
27+
Assertions.assertEquals("delete", FileAction.DELETE.toString());
28+
Assertions.assertEquals("update", FileAction.UPDATE.toString());
29+
}
30+
31+
2332
@Test
2433
void testGetFile404() {
2534
Optional<File> fileNotFound = fileService.getFileAllow404(7, "404.error");
2635

27-
Assert.assertFalse(fileNotFound.isPresent());
36+
Assertions.assertFalse(fileNotFound.isPresent());
2837
}
2938

3039
@Test
3140
void testGetFile() {
3241
Optional<File> fileNotFound = fileService.getFile(7, "404.error");
3342

34-
Assert.assertFalse(fileNotFound.isPresent());
43+
Assertions.assertFalse(fileNotFound.isPresent());
3544
}
3645

3746
@Test
@@ -44,37 +53,37 @@ void testGetFile500() {
4453
@Test
4554
void deleteFile() {
4655
Optional<File> deletedFile = fileService.deleteFile(7, "engagement.json");
47-
Assert.assertTrue(deletedFile.isPresent());
56+
Assertions.assertTrue(deletedFile.isPresent());
4857
}
4958

5059
@Test
5160
void deleteFileNotExist() {
5261
Optional<File> deletedFile = fileService.deleteFile(7, "nonexistent.rht");
53-
Assert.assertFalse(deletedFile.isPresent());
62+
Assertions.assertFalse(deletedFile.isPresent());
5463
}
5564

5665
@Test
5766
void updateFile() {
5867
Optional<File> updatedFile = fileService.updateFile(7, "update.file", File.builder().filePath("update.file").content("hi").build());
59-
Assert.assertTrue(updatedFile.isPresent());
68+
Assertions.assertTrue(updatedFile.isPresent());
6069
}
6170

6271
@Test
6372
void updateFileNotExist() {
6473
Optional<File> updatedFile = fileService.updateFile(7, "nonexistent.rht", File.builder().filePath("update.file").content("hi").build());
65-
Assert.assertFalse(updatedFile.isPresent());
74+
Assertions.assertFalse(updatedFile.isPresent());
6675
}
6776

6877
@Test
6978
void createFile() {
7079
Optional<File> updatedFile = fileService.createFile(7, "create.file", File.builder().filePath("create.file").content("hi").build());
71-
Assert.assertTrue(updatedFile.isPresent());
80+
Assertions.assertTrue(updatedFile.isPresent());
7281
}
7382

7483
@Test
7584
void createFileNotExist() {
7685
Optional<File> updatedFile = fileService.createFile(7, "nonexistent.rht", File.builder().filePath("update.file").content("hi").build());
77-
Assert.assertFalse(updatedFile.isPresent());
86+
Assertions.assertFalse(updatedFile.isPresent());
7887
}
7988

8089
}

0 commit comments

Comments
 (0)