Merge pull request #143 from mcanoy/migrate-dates

more data cleansing

Author: mcanoy

src/main/java/com/redhat/labs/lodestar/service/MigrationService.java

@@ -4,6 +4,7 @@
 import java.time.LocalDateTime;
 import java.time.ZoneOffset;
 import java.time.format.DateTimeFormatter;
+import java.time.format.DateTimeParseException;
 import java.util.*;
 
 import javax.enterprise.context.ApplicationScoped;
@@ -164,12 +165,22 @@ private String migrateEngagement(Engagement engagement) {
                 try {
                     use.setCreated(convertDateTime(use.getCreated()));
                     use.setUpdated(convertDateTime(use.getUpdated()));
-                } catch(Exception ex) {
+                } catch(RuntimeException ex) {
                     LOGGER.error ("dtf exception {}", use.getCreated(), ex);
                 }
             }));
         }
 
+        if(copy.getLaunch() != null) {
+            try {
+                Instant.parse(copy.getLaunch().getLaunchedDateTime());
+            } catch (DateTimeParseException ex) {
+                LOGGER.error("No standard launch date {}", copy.getLaunch().getLaunchedDateTime());
+                copy.getLaunch().setLaunchedDateTime(convertDateTime(copy.getLaunch().getLaunchedDateTime()));
+            }
+        }
+
+
         copy.setHostingEnvironments(null);
         copy.setEngagementUsers(null);
         copy.setCommits(null);
@@ -183,8 +194,31 @@ private <T> T clone(T toClone, Class<T> clazz) {
     }
 
     private String convertDateTime(String oldDateTime) {
+        String[] patterns = {"yyyy-MM-dd'T'HH:mm:ss.SSSSSS", "yyyy-MM-dd'T'HH:mm:ss.SSS"};
+
+        String date = null;
+
+        for(int i=0; i<patterns.length; i++) {
+            try {
+                date = convertDateTime(oldDateTime, patterns[i]);
+                break;
+            } catch (DateTimeParseException ex) {
+                LOGGER.error("No standard date {}, pattern {}", oldDateTime, patterns[i]);
+            }
+        }
+
+        if(date == null) {
+            throw new RuntimeException("Unable to parse date " + oldDateTime);
+        }
+
+        LOGGER.trace("date converted={}", date);
+        return date;
+    }
+
+    private String convertDateTime(String oldDateTime, String pattern) {
         LOGGER.trace("Date In {}", oldDateTime);
-        DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSSSSS");
+
+        DateTimeFormatter formatter = DateTimeFormatter.ofPattern(pattern);
         LocalDateTime expected = LocalDateTime.parse(oldDateTime, formatter);
         Instant instant = expected.toInstant(ZoneOffset.UTC);
         LOGGER.trace("Date Out {}", instant);

src/test/java/com/redhat/labs/lodestar/service/MigrationServiceTest.java

@@ -1,5 +1,6 @@
 package com.redhat.labs.lodestar.service;
 
+import java.time.Instant;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
@@ -59,12 +60,15 @@ public static void setup() {
         List<UseCase> uses = new ArrayList<>();
         uses.add(UseCase.builder().title("use case").created("2021-08-26T20:42:46.050483")
                 .updated("2021-08-26T20:42:46.050483").build());
-        uses.add(UseCase.builder().title("use case2").build());
+        uses.add(UseCase.builder().title("use case2").created("2021-08-26T20:42:46.050483").build());
 
-        Engagement e = Engagement.builder().uuid("a1").categories(cats).useCases(uses).projectId(1).build();
+        Launch launch = Launch.builder().launchedBy("Alfredo").launchedByEmail("[email protected]").launchedDateTime("2021-08-26T20:42:46.050").build();
+
+        Engagement e = Engagement.builder().uuid("a1").categories(cats).useCases(uses).projectId(1).launch(launch).build();
         allEngagements.add(e);
 
-        e = Engagement.builder().uuid("c3").projectId(3).engagementUsers(engagementUsers).build();
+        launch = Launch.builder().launchedBy("Alfredo").launchedByEmail("[email protected]").launchedDateTime(Instant.now().toString()).build();
+        e = Engagement.builder().uuid("c3").projectId(3).engagementUsers(engagementUsers).launch(launch).build();
         allEngagements.add(e);
 
         e = Engagement.builder().uuid("d4").projectId(4).engagementUsers(engagementUsers).artifacts(artifacts).build();