must use valid path to look up project (#119)

Author: dwasinge

src/main/java/com/redhat/labs/lodestar/service/EngagementService.java

@@ -189,7 +189,7 @@ public Status getProjectStatus(String customerName, String engagementName) {
     }
 
     public Optional<Project> getProject(String customerName, String engagementName) {
-        String fullPath = GitLabPathUtils.getPath(engagementPathPrefix, customerName, engagementName);
+        String fullPath = GitLabPathUtils.getValidPath(engagementPathPrefix, customerName, engagementName);
 
         LOGGER.debug("Full path {}", fullPath);
         return projectService.getProjectByIdOrPath(fullPath);

src/main/java/com/redhat/labs/lodestar/service/ProjectStructureService.java

@@ -295,10 +295,7 @@ void removeIfEmpty(int retryCount, Runnable runnable) {
 
     Optional<Project> findProjectByPath(String engagementPathPrefix, String customerName, String projectName) {
 
-        String customerPath = GitLabPathUtils.generateValidPath(customerName);
-        String projectPath = GitLabPathUtils.generateValidPath(projectName);
-        String fullPath = GitLabPathUtils.getPath(engagementPathPrefix, customerPath, projectPath);
-
+        String fullPath = GitLabPathUtils.getValidPath(engagementPathPrefix, customerName, projectName);
         return projectService.getProjectByIdOrPath(fullPath);
 
     }

src/main/java/com/redhat/labs/lodestar/utils/GitLabPathUtils.java

@@ -50,4 +50,12 @@ public static String getPath(String engagementPathPrefix, String customerName, S
                 .append("/iac").toString();
     }
 
+    public static String getValidPath(String engagementPathPrefix, String customerName, String engagementName) {
+
+        String customerPath = GitLabPathUtils.generateValidPath(customerName);
+        String projectPath = GitLabPathUtils.generateValidPath(engagementName);
+        return GitLabPathUtils.getPath(engagementPathPrefix, customerPath, projectPath);
+
+    }
+
 }