only create if a new engagement

Author: dwasinge

src/main/java/com/redhat/labs/lodestar/service/ConfigService.java

@@ -185,20 +185,15 @@ boolean engagementIsArchived(Project project) {
      * Adds all configured webhooks to the project for the given {@link Engagement}.
      * 
      * @param engagement
-     * @param isFirst
      * 
      */
-    public void createWebhooksForEnagement(Engagement engagement, boolean isFirst) {
+    public void createWebhooksForEnagement(Engagement engagement) {
 
         List<HookConfig> hookConfigs = getHookConfig();
         hookConfigs.stream().forEach(hookC -> {
             Hook hook = Hook.builder().projectId(engagement.getProjectId()).pushEvents(true).url(hookC.getBaseUrl())
                     .token(hookC.getToken()).build();
-            if (isFirst) { // No need to check for existing hooks first time
                 hookService.createProjectHook(engagement.getProjectId(), hook);
-            } else {
-                hookService.createOrUpdateProjectHook(engagement.getProjectId(), hook);
-            }
         });
 
     }

src/main/java/com/redhat/labs/lodestar/service/EngagementService.java

@@ -118,8 +118,10 @@ public Project createEngagement(Engagement engagement, String author, String aut
             throw new UnexpectedGitLabResponseException("failed to commit files for engagement creation.");
         }
 
-        // create or update web hooks 
-        configService.createWebhooksForEnagement(engagement, project.isFirst());
+        // create hooks if new engagement, should already exist if updating
+        if(project.isFirst()) {
+            configService.createWebhooksForEnagement(engagement);
+        }
 
         return project;