reverting isEmpty for java 8

Author: Derek Wasinger

pom.xml

@@ -9,14 +9,13 @@
 	<version>1.0.0-SNAPSHOT</version>
 	<properties>
 		<compiler-plugin.version>3.8.1</compiler-plugin.version>
-		<jackson.version>2.10.1</jackson.version>
 		<maven.compiler.parameters>true</maven.compiler.parameters>
 		<maven.compiler.source>1.8</maven.compiler.source>
 		<maven.compiler.target>1.8</maven.compiler.target>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 		<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
 		<quarkus-plugin.version>1.3.0.Final</quarkus-plugin.version>
-		<quarkus.platform.artifact-id>quarkus-universe-bom</quarkus.platform.artifact-id>
+		<quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
 		<quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
 		<quarkus.platform.version>1.3.0.Final</quarkus.platform.version>
 		<surefire-plugin.version>2.22.1</surefire-plugin.version>

src/main/java/com/redhat/labs/omp/resources/CacheResource.java

@@ -77,7 +77,7 @@ public Response testResCache() {
     private File fetchContentFromGit(String fileName) {
 
         Optional<File> optional = fileService.getFile(templateRepositoryId, fileName);
-        if (optional.isEmpty()) {
+        if (!optional.isPresent()) {
             throw new FileNotFoundException("file not found in gitlab.");
         }
 

src/main/java/com/redhat/labs/omp/resources/LegacyFileResource.java

@@ -34,7 +34,7 @@ public class LegacyFileResource {
     public Response getFileFromGitByName(@QueryParam("name") String fileName, @QueryParam("repo_id") Integer repoId,
             @QueryParam("branch") String branch) {
         Optional<File> optional = fileService.getFile(repoId, fileName, branch);
-        if (optional.isEmpty()) {
+        if (!optional.isPresent()) {
             return Response.status(HttpStatus.SC_NOT_FOUND).build();
         }
 

src/main/java/com/redhat/labs/omp/service/EngagementService.java

@@ -97,12 +97,12 @@ private Group getOrCreateGroup(String groupName, Group groupToCreate) {
 
         Optional<Group> optional = groupService.getGitLabGroupByName(groupName);
 
-        if (optional.isEmpty()) {
+        if (!optional.isPresent()) {
 
             // try to create group
             optional = groupService.createGitLabGroup(groupToCreate);
 
-            if (optional.isEmpty()) {
+            if (!optional.isPresent()) {
                 throw new UnexpectedGitLabResponseException("failed to create group");
             }
 
@@ -116,12 +116,12 @@ private Project getOrCreateProject(Integer namespaceId, String projectName, Proj
 
         Optional<Project> optional = projectService.getProjectByName(namespaceId, projectName);
 
-        if (optional.isEmpty()) {
+        if (!optional.isPresent()) {
 
             // try to create project
             optional = projectService.createProject(project);
 
-            if (optional.isEmpty()) {
+            if (!optional.isPresent()) {
                 throw new UnexpectedGitLabResponseException("failed to create project");
             }
 

src/main/java/com/redhat/labs/omp/service/TemplateService.java

@@ -66,7 +66,7 @@ public File getTemplateInventoryFile() {
         // get inventory file
         Optional<File> optional = fileService.getFile(templateRepositoryId, inventoryFileName);
 
-        if (optional.isEmpty()) {
+        if (!optional.isPresent()) {
             throw new FileNotFoundException("could not get template inventory file from gitlab.");
         }
 
@@ -86,7 +86,7 @@ public List<File> getTemplateInventoryFiles(File file) {
             String fileName = metaFileFolder + line.substring(1);
 
             Optional<File> optional = fileService.getFile(templateRepositoryId, fileName);
-            if (optional.isEmpty()) {
+            if (!optional.isPresent()) {
                 throw new FileNotFoundException("could not get template file '" + fileName + "' from gitlab.");
             }