Skip to content

Commit f5b1acd

Browse files
committed
🦀 tidy up pet-battle A confusion 🦀
1 parent 3b183f8 commit f5b1acd

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

docs/5-the-deployments-strike-back/3-a-b-deployments.md

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ Before we jumping to A/B deployment, let's deploy Matomo through Argo CD.
9292

9393
### A/B Deployment
9494

95-
1. Let's deploy our experiment we want to compare - let's call this `B` and we'll use our existing Pet Battle deployment as `A`. Adjust the `source_ref` helm chart version and `image_version` to match what you have built.
95+
1. Let's deploy our experiment we want to compare - let's call this `B`. Adjust the `source_ref` helm chart version and `image_version` to match what you have built.
9696

9797
```bash
9898
cat << EOF >> /projects/tech-exercise/pet-battle/test/values.yaml
@@ -122,7 +122,9 @@ Before we jumping to A/B deployment, let's deploy Matomo through Argo CD.
122122
EOF
123123
```
124124

125-
2. Extend the cofiguration for the existing Pet Battle deployment (`A`) by adding the `a_b_deploy` properties to the `values` section. Copy the below lines under `pet-battle` application definition in `/projects/tech-exercise/pet-battle/test/values.yaml` file.
125+
We will use our existing Pet Battle deployment as `A`.
126+
127+
2. Extend the configuration for the existing Pet Battle deployment (`A`) by adding the `a_b_deploy` properties to the `values` section. Copy the below lines under `pet-battle` application definition in `/projects/tech-exercise/pet-battle/test/values.yaml` file.
126128

127129
```yaml
128130
a_b_deploy:
@@ -131,7 +133,7 @@ Before we jumping to A/B deployment, let's deploy Matomo through Argo CD.
131133
svc_name: pet-battle-b
132134
```
133135

134-
The `pet-battle` definition in `test/values.yaml` should look something like this (the version numbers may be different):
136+
The `pet-battle-a` definition in `test/values.yaml` should look something like this (the version numbers may be different):
135137

136138
<div class="highlight" style="background: #f7f7f7">
137139
<pre><code class="language-yaml">
@@ -208,10 +210,10 @@ And as always, push it to the Git repository - <strong>Because if it's not in Gi
208210

209211
```bash
210212
cd /projects/tech-exercise
211-
yq eval -i .applications.pet-battle-a.values.a_b_deploy.a_weight='100' pet-battle/test/values.yaml
212-
yq eval -i .applications.pet-battle-a.values.a_b_deploy.b_weight='100' pet-battle/test/values.yaml
213+
yq eval -i .applications.pet-battle.values.a_b_deploy.a_weight='100' pet-battle/test/values.yaml
214+
yq eval -i .applications.pet-battle.values.a_b_deploy.b_weight='100' pet-battle/test/values.yaml
213215
git add pet-battle/test/values.yaml
214-
git commit -m "🏋️‍♂️ service B weight increased to 80 🏋️‍♂️"
216+
git commit -m "🏋️‍♂️ service B weight increased to 50% 🏋️‍♂️"
215217
git push
216218
```
217219

@@ -225,8 +227,8 @@ And as always, push it to the Git repository - <strong>Because if it's not in Gi
225227

226228
```bash
227229
cd /projects/tech-exercise
228-
yq eval -i .applications.pet-battle-a.values.a_b_deploy.a_weight='100' pet-battle/test/values.yaml
229-
yq eval -i .applications.pet-battle-a.values.a_b_deploy.b_weight='0' pet-battle/test/values.yaml
230+
yq eval -i .applications.pet-battle.values.a_b_deploy.a_weight='100' pet-battle/test/values.yaml
231+
yq eval -i .applications.pet-battle.values.a_b_deploy.b_weight='0' pet-battle/test/values.yaml
230232
git add pet-battle/test/values.yaml
231233
git commit -m "💯 service B weight increased to 100 💯"
232234
git push

0 commit comments

Comments
 (0)