add v3-node20 versions of artifact actions (#468)

rhysd · rhysd · commit 187a0b220635 · 2024-11-06T17:39:08.000+09:00
Note that this restores the workaround for #442.
diff --git a/popular_actions.go b/popular_actions.go
diff --git a/scripts/generate-popular-actions/main.go b/scripts/generate-popular-actions/main.go
@@ -192,6 +192,17 @@ func (g *gen) fetchRemote() (map[string]*actionlint.ActionMetadata, error) {
 			}
 		}
 
+		// Workaround for #442.
+		// https://github.com/actions/download-artifact/issues/355
+		if f.spec == "actions/download-artifact@v3-node20" {
+			if f.meta.Outputs == nil {
+				f.meta.Outputs = actionlint.ActionMetadataOutputs{}
+			}
+			f.meta.Outputs["download-path"] = &actionlint.ActionMetadataOutput{
+				Name: "download-path",
+			}
+		}
+
 		ret[f.spec] = f.meta
 	}
 
diff --git a/scripts/generate-popular-actions/popular_actions.json b/scripts/generate-popular-actions/popular_actions.json
@@ -99,7 +99,7 @@
     },
     {
         "slug": "actions/download-artifact",
-        "tags": ["v1", "v2", "v3", "v4"],
+        "tags": ["v1", "v2", "v3", "v3-node20", "v4"],
         "next": "v5"
     },
     {
@@ -149,7 +149,7 @@
     },
     {
         "slug": "actions/upload-artifact",
-        "tags": ["v1", "v2", "v3", "v4"],
+        "tags": ["v1", "v2", "v3", "v3-node20", "v4"],
         "next": "v5"
     },
     {

Original file line number	Diff line number	Diff line change
`@@ -192,6 +192,17 @@ func (g gen) fetchRemote() (map[string]actionlint.ActionMetadata, error) {`
`192`	`192`	`}`
`193`	`193`	`}`
`194`	`194`
	`195`	`+ // Workaround for #442.`
	`196`	`+ // https://github.com/actions/download-artifact/issues/355`
	`197`	`+ if f.spec == "actions/download-artifact@v3-node20" {`
	`198`	`+ if f.meta.Outputs == nil {`
	`199`	`+ f.meta.Outputs = actionlint.ActionMetadataOutputs{}`
	`200`	`+ }`
	`201`	`+ f.meta.Outputs["download-path"] = &actionlint.ActionMetadataOutput{`
	`202`	`+ Name: "download-path",`
	`203`	`+ }`
	`204`	`+ }`
	`205`	`+`
`195`	`206`	`ret[f.spec] = f.meta`
`196`	`207`	`}`
`197`	`208`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@`
`99`	`99`	`},`
`100`	`100`	`{`
`101`	`101`	`"slug": "actions/download-artifact",`
`102`		`- "tags": ["v1", "v2", "v3", "v4"],`
	`102`	`+ "tags": ["v1", "v2", "v3", "v3-node20", "v4"],`
`103`	`103`	`"next": "v5"`
`104`	`104`	`},`
`105`	`105`	`{`
`@@ -149,7 +149,7 @@`
`149`	`149`	`},`
`150`	`150`	`{`
`151`	`151`	`"slug": "actions/upload-artifact",`
`152`		`- "tags": ["v1", "v2", "v3", "v4"],`
	`152`	`+ "tags": ["v1", "v2", "v3", "v3-node20", "v4"],`
`153`	`153`	`"next": "v5"`
`154`	`154`	`},`
`155`	`155`	`{`