upgrade eslint to v9 and typescript-eslint to v8

Author: rhysd

playground/eslint.config.mjs

@@ -11,17 +11,15 @@ export default ts.config(
         files: ['*.ts'],
         languageOptions: {
             parserOptions: {
-                project: 'tsconfig.json',
+                projectService: true,
+                project: './tsconfig.json',
+                tsconfigRootDir: import.meta.dirname,
             },
         },
     },
     {
         files: ['*.ts', '*.mjs'],
         rules: {
-            indent: ['error', 4],
-            quotes: ['error', 'single'],
-            'linebreak-style': ['error', 'unix'],
-            semi: ['error', 'always'],
             eqeqeq: ['error', 'always'],
             'no-constant-condition': ['error', { checkLoops: false }],
             '@typescript-eslint/no-unsafe-member-access': 'off',
@@ -44,6 +42,7 @@ export default ts.config(
         files: ['eslint.config.mjs'],
         languageOptions: {
             parserOptions: {
+                projectService: false,
                 project: 'tsconfig.eslint.json',
             },
         },

playground/index.ts

@@ -145,7 +145,6 @@ jobs:
             successMessage.style.display = 'none';
             invalidInputMessage.style.display = 'none';
             editor.clearGutter('error-marker');
-            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             window.runActionlint!(editor.getValue());
         }
 

playground/package.json

@@ -8,8 +8,8 @@
     "lint:stylelint": "stylelint style.css",
     "lint:prettier": "prettier --check '*.ts' '*.mjs'",
     "lint:eslint": "eslint --max-warnings 0 '*.ts' '*.mjs'",
-    "lint:eslintconfig": "tsc --checkJs --noEmit -p tsconfig.eslint.json",
-    "lint": "npm run lint:prettier && npm run lint:eslint && npm run lint:stylelint && npm run lint:eslintconfig",
+    "lint:tsc-eslint": "tsc -p tsconfig.eslint.json",
+    "lint": "npm run lint:prettier && npm run lint:eslint && npm run lint:stylelint && npm run lint:tsc-eslint",
     "prettier": "prettier --write '*.ts' '*.mjs'",
     "build": "tsc -p .",
     "watch": "tsc -p . --watch",

playground/test.ts

@@ -9,8 +9,8 @@ if (typeof globalThis.crypto === 'undefined') {
     globalThis.crypto = new Crypto();
 }
 
-// Inject global.Go
-require('./lib/js/wasm_exec.js');
+// Inject global.Go for testing `main.wasm`.
+require('./lib/js/wasm_exec.js'); // eslint-disable-line @typescript-eslint/no-require-imports
 
 class CheckResults {
     errors: ActionlintError[] | null = null;
@@ -76,7 +76,6 @@ jobs:
         const json = JSON.stringify(errors);
         assert.equal(errors.length, 1, json);
 
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         const err = errors[0]!;
         assert.equal(err.message, '"runs-on" section is missing in job "test"', `message is unexpected: ${json}`);
         assert.equal(err.line, 5, `line is unexpected: ${json}`);
@@ -102,7 +101,6 @@ jobs:
         const json = JSON.stringify(errors);
         assert.equal(errors.length, 1, json);
 
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         const err = errors[0]!;
         assert.ok(err.message.includes('unknown Webhook event "foo"'), `message is unexpected: ${json}`);
         assert.equal(err.line, 2, `line is unexpected: ${json}`);

playground/tsconfig.eslint.json

@@ -1,6 +1,8 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
+    "checkJs": true,
+    "noEmit": true,
     "module": "nodenext",
     "moduleResolution": "nodenext"
   },