fix: resolve TypeScript compilation errors and update tests

- Add extends object constraint to makeRequest generic for 'in' operator
- Fix artist.name type errors by casting to any when using .name fallback
- Fix mock cache object type casting and parameter types
- Update test to expect 202 Accepted (not 204) for notifications per MCP spec

All TypeScript errors resolved. Ready for CI/CD deployment.

Author: rianvdm

src/clients/lastfm.ts

@@ -391,7 +391,7 @@ export class LastfmClient {
 	/**
 	 * Make a request to the Last.fm API
 	 */
-	private async makeRequest<T>(params: Record<string, string>): Promise<T> {
+	private async makeRequest<T extends object>(params: Record<string, string>): Promise<T> {
 		const searchParams = new URLSearchParams({
 			api_key: this.apiKey,
 			format: 'json',

src/protocol/handlers.ts

@@ -696,7 +696,7 @@ Your authentication will be secure and connection-specific - only you will have
 						text: `🎵 **Track Information**
 
 **Track:** ${data.track.name}
-**Artist:** ${data.track.artist.name}
+**Artist:** ${data.track.artist['#text'] || (data.track.artist as any).name}
 **Album:** ${data.track.album?.['#text'] || 'Unknown'}
 
 **Stats:**
@@ -867,7 +867,7 @@ ${artistList}`,
 			const trackList = tracks
 				.map((t) => {
 					const album = t.album?.['#text'] ? ` [${t.album['#text']}]` : ''
-					return `• ${t.artist.name} - ${t.name}${album} (${Math.round(parseFloat(t.match) * 100)}% match)`
+					return `• ${t.artist['#text'] || (t.artist as any).name} - ${t.name}${album} (${Math.round(parseFloat(t.match) * 100)}% match)`
 				})
 				.join('\n')
 
@@ -1084,7 +1084,7 @@ Total albums: ${data.topalbums['@attr'].total}`,
 			const trackList = tracks
 				.map((track) => {
 					const album = track.album?.['#text'] ? ` [${track.album['#text']}]` : ''
-					return `• ${track.artist.name} - ${track.name}${album}`
+					return `• ${track.artist['#text'] || (track.artist as any).name} - ${track.name}${album}`
 				})
 				.join('\n')
 
@@ -1128,7 +1128,7 @@ Total loved tracks: ${data.lovedtracks['@attr'].total}`,
 						text: `🎵 **Track Information**
 
 **Track:** ${data.track.name}${loved}
-**Artist:** ${data.track.artist.name}
+**Artist:** ${data.track.artist['#text'] || (data.track.artist as any).name}
 **Album:** ${data.track.album?.['#text'] || 'Unknown'}
 
 **Stats:**
@@ -1305,7 +1305,7 @@ ${artistList}`,
 			const trackList = tracks
 				.map((t) => {
 					const album = t.album?.['#text'] ? ` [${t.album['#text']}]` : ''
-					return `• ${t.artist.name} - ${t.name}${album} (${Math.round(parseFloat(t.match) * 100)}% match)`
+					return `• ${t.artist['#text'] || (t.artist as any).name} - ${t.name}${album} (${Math.round(parseFloat(t.match) * 100)}% match)`
 				})
 				.join('\n')
 

src/utils/cache.ts

@@ -355,25 +355,25 @@ export function createLastfmCache(kv?: KVNamespace): SmartCache {
 			async get() {
 				return null
 			},
-			async set() {
+			async set(): Promise<void> {
 				return
 			},
-			async getOrFetch(_type, _key, fetcher) {
+			async getOrFetch<T>(_type: keyof CacheConfig, _key: string, fetcher: () => Promise<T>): Promise<T> {
 				return fetcher()
 			},
-			async invalidate() {
+			async invalidate(): Promise<void> {
 				return
 			},
-			async invalidatePattern() {
+			async invalidatePattern(): Promise<void> {
 				return
 			},
-			async getStats() {
+			getStats: async () => {
 				return { totalEntries: 0, entriesByType: {}, pendingRequests: 0 }
 			},
 			cleanupPendingRequests() {
 				return
 			},
-		} as SmartCache
+		} as unknown as SmartCache
 	}
 
 	return new SmartCache(kv, {

test/integration/mcp-client.test.ts

@@ -787,8 +787,8 @@ describe('MCP Client Integration Tests', () => {
 
 			const response = await worker.fetch(request, mockEnv, {} as any)
 
-			// Notifications should return 204 with no body
-			expect(response.status).toBe(204)
+			// Notifications should return 202 Accepted per MCP spec
+			expect(response.status).toBe(202)
 			const text = await response.text()
 			expect(text).toBe('') // Empty response for notifications
 		})