Skip to content

Commit 4561452

Browse files
author
Ricardo Fiorani
committed
updated the tests
1 parent 61f0117 commit 4561452

File tree

5 files changed

+9
-6
lines changed

5 files changed

+9
-6
lines changed

test/Adapter/AbstractServiceAdapterTest.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,10 @@ public function testGetEmbedCode($url)
9393
public function testGetScheme($url)
9494
{
9595
$facebookVideo = $this->getMockingObject($url);
96-
$schemeInsecure = $facebookVideo->getScheme(false);
97-
$this->assertEquals('http', $schemeInsecure);
96+
97+
$originalScheme = $facebookVideo->getScheme(false);
98+
$this->assertEquals(parse_url($url, PHP_URL_SCHEME), $originalScheme);
99+
98100
$schemeSecure = $facebookVideo->getScheme(true);
99101
$this->assertEquals('https', $schemeSecure);
100102
}

test/Adapter/DailymotionServiceAdapterTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public function testIfGetEmbedUrlUsesRightScheme($url)
9494
$this->assertContains('https', $embedUrl);
9595

9696
$embedUrl = $videoObject->getEmbedUrl(false, false);
97-
$this->assertNotContains('https', $embedUrl);
97+
$this->assertEquals(parse_url($url, PHP_URL_SCHEME), parse_url($embedUrl, PHP_URL_SCHEME));
9898
}
9999

100100
/**

test/Adapter/FacebookServiceAdapterTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ public function testIfGetEmbedUrlUsesRightScheme($url)
115115
$this->assertContains('https', $embedUrl);
116116

117117
$embedUrl = $videoObject->getEmbedUrl(false, false);
118-
$this->assertNotContains('https', $embedUrl);
118+
$this->assertEquals(parse_url($url, PHP_URL_SCHEME), parse_url($embedUrl, PHP_URL_SCHEME));
119119
}
120120

121121
/**

test/Adapter/VimeoServiceAdapterTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public function testIfGetEmbedUrlUsesRightScheme($url)
112112
$this->assertContains('https', $embedUrl);
113113

114114
$embedUrl = $videoObject->getEmbedUrl(false, false);
115-
$this->assertNotContains('https', $embedUrl);
115+
$this->assertEquals(parse_url($url, PHP_URL_SCHEME), parse_url($embedUrl, PHP_URL_SCHEME));
116116
}
117117

118118
/**

test/Adapter/YoutubeServiceAdapterTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public function testIfGetEmbedUrlUsesRightScheme($url)
9292
$this->assertContains('https', $embedUrl);
9393

9494
$embedUrl = $videoObject->getEmbedUrl(false, false);
95-
$this->assertNotContains('https', $embedUrl);
95+
$this->assertEquals(parse_url($url, PHP_URL_SCHEME), parse_url($embedUrl, PHP_URL_SCHEME));
9696
}
9797

9898
/**
@@ -114,6 +114,7 @@ public function exampleUrlDataProvider()
114114
array(
115115
'https://www.youtube.com/watch?v=uarCDXc3BjU',
116116
'https://youtu.be/uarCDXc3BjU',
117+
'http://youtu.be/uarBDXc3BjU',
117118
'<iframe width="560" height="315" src="https://www.youtube.com/embed/uarCDXc3BjU" frameborder="0" allowfullscreen></iframe>',
118119
),
119120
);

0 commit comments

Comments
 (0)