Better tests

Author: ricardofiorani

src/Detector/VideoServiceDetector.php

@@ -67,7 +67,7 @@ public function getServiceContainer()
     /**
      * @param ServicesContainer $serviceContainer
      */
-    public function setServiceContainer($serviceContainer)
+    public function setServiceContainer(ServicesContainer $serviceContainer)
     {
         $this->serviceContainer = $serviceContainer;
     }

test/Detector/ServiceDetectorTest.php

@@ -9,62 +9,108 @@
 namespace RicardoFiorani\Test;
 
 use PHPUnit_Framework_TestCase;
+use RicardoFiorani\Container\Factory\ServicesContainerFactory;
 use RicardoFiorani\Detector\VideoServiceDetector;
 use RicardoFiorani\Exception\ServiceNotAvailableException;
 
 class ServiceDetectorTest extends PHPUnit_Framework_TestCase
 {
     /**
-     * @dataProvider youtubeDataProvider
+     * @dataProvider videoUrlProvider
      * @param $url
-     * @param $expectedEmbedCode
+     * @param $expectedServiceName
      * @throws ServiceNotAvailableException
      */
-    public function testCanParseYoutubeUrl($url, $expectedEmbedCode)
+    public function testCanParseUrl($url, $expectedServiceName)
     {
         $detector = new VideoServiceDetector();
         $video = $detector->parse($url);
-        $this->assertEquals($video->getEmbedUrl(), $expectedEmbedCode);
+        $this->assertInstanceOf($expectedServiceName, $video);
     }
 
-    public function youtubeDataProvider()
+    /**
+     * @return array
+     */
+    public function videoUrlProvider()
     {
 
         return array(
             'Normal Youtube URL' => array(
                 'https://www.youtube.com/watch?v=mWRsgZuwf_8',
-                'http://www.youtube.com/embed/mWRsgZuwf_8',
+                '\\RicardoFiorani\\Adapter\\Youtube\\YoutubeServiceAdapter',
             ),
             'Short Youtube URL' => array(
                 'https://youtu.be/JMLBOKVfHaA',
-                'http://www.youtube.com/embed/JMLBOKVfHaA',
+                'RicardoFiorani\\Adapter\\Youtube\\YoutubeServiceAdapter',
             ),
             'Embed Youtube URL' => array(
                 '<iframe width="420" height="315" src="https://www.youtube.com/embed/vwp9JkaESdg" frameborder="0" allowfullscreen></iframe>',
-                'http://www.youtube.com/embed/vwp9JkaESdg',
+                '\\RicardoFiorani\\Adapter\\Youtube\\YoutubeServiceAdapter',
+            ),
+            'Common Vimeo URL' => array(
+                'https://vimeo.com/137781541',
+                '\\RicardoFiorani\\Adapter\\Vimeo\\VimeoServiceAdapter',
+            ),
+            'Commom Dailymotion URL' => array(
+                'http://www.dailymotion.com/video/x332a71_que-categoria-jogador-lucas-lima-faz-golaco-em-treino-do-santos_sport',
+                '\\RicardoFiorani\\Adapter\\Dailymotion\\DailyMotionServiceAdapter',
             ),
         );
     }
 
     /**
-     * @dataProvider vimeoDataProvider
-     * @param string $url
-     * @param string $expectedEmbedCode
+     * @throws ServiceNotAvailableException
+     * @dataProvider invalidVideoUrlProvider
      */
-    public function testCanParseVimeoUrl($url, $expectedEmbedCode)
+    public function testThrowsExceptionOnInvalidUrl($url)
     {
         $detector = new VideoServiceDetector();
+        $this->setExpectedException('\\RicardoFiorani\\Exception\\ServiceNotAvailableException');
         $video = $detector->parse($url);
-        $this->assertEquals($video->getEmbedUrl(), $expectedEmbedCode);
     }
 
-    public function vimeoDataProvider()
+    /**
+     * @return array
+     */
+    public function invalidVideoUrlProvider($url)
     {
         return array(
-            'Common Vimeo URL' => array(
-                'https://vimeo.com/137781541',
-                'http://player.vimeo.com/video/137781541'
-            )
+            array(
+                'http://tvuol.uol.com.br/video/dirigindo-pelo-mundo-de-final-fantasy-xv-0402CC9B3764E4A95326',
+            ),
+            array(
+                'https://www.google.com.br/',
+            ),
+            array(
+                'https://www.youtube.com/',
+            ),
         );
     }
+
+    /**
+     * @dataProvider videoUrlProvider
+     */
+    public function testServiceDetectorDontReparseSameUrl($url)
+    {
+        $detector = new VideoServiceDetector();
+        $video = $detector->parse($url);
+
+        $this->assertSame($video, $detector->parse($url));
+    }
+
+    public function testServiceContainerGetter()
+    {
+        $detector = new VideoServiceDetector();
+        $this->assertInstanceOf('RicardoFiorani\\Container\\ServicesContainer', $detector->getServiceContainer());
+    }
+
+    public function testServiceContainerSetter()
+    {
+        $detector = new VideoServiceDetector();
+        $serviceContainer = ServicesContainerFactory::createNewServiceDetector();
+        $detector->setServiceContainer($serviceContainer);
+        $this->assertSame($serviceContainer, $detector->getServiceContainer());
+    }
+
+
 }