[Heavy] Implement Vector in OpGen

Author: ricejasonf

heavy/include/heavy/OpGen.h

@@ -397,7 +397,7 @@ class OpGen : public ValueVisitor<OpGen, mlir::Value> {
   mlir::Value VisitBinding(Binding* B);
 
   mlir::Value VisitPair(Pair* P);
-  // TODO mlir::Value VisitVector(Vector* V);
+  mlir::Value VisitVector(Vector* V);
 
   mlir::Value Lookup(heavy::Value V) {
     return BindingTable.lookup(V);

heavy/lib/OpGen.cpp

@@ -1141,18 +1141,21 @@ mlir::Value OpGen::VisitPair(Pair* P) {
   return HandleCall(P);
 }
 
-#if 0 // TODO VectorOp??
 mlir::Value OpGen::VisitVector(Vector* V) {
-  llvm::ArrayRef<Value> Xs = V->getElements();
-  Vector* New = Context.CreateVector(Xs.size());
-  llvm::MutableArrayRef<Value> Ys = New->getElements();
-  for (unsigned i = 0; i < Xs.size(); ++i) {
-    Visit(Xs[i]);
-    Ys[i] = Visit(Xs[i]);
+  llvm::SmallVector<mlir::Value, 8> Vals;
+  for (auto X : V->getElements()) {
+    mlir::Value Val = GetSingleResult(X);
+    if (CheckError())
+      return mlir::Value();
+    Vals.push_back(Val);
   }
-  return New;
+
+  // Localize the values in the current context.
+  for (mlir::Value& Val : Vals)
+    Val = LocalizeValue(Val);
+
+  return create<heavy::VectorOp>(Context.getLoc(), Vals);
 }
-#endif
 
 // LocalizeValue - If a value belongs to a parent region from
 //                 which the current region should be isolated

heavy/test/Evaluate/vector.scm

@@ -0,0 +1,19 @@
+; RUN: heavy-scheme %s | FileCheck %s
+(import (heavy base))
+
+(define (id x) x)
+
+; CHECK: #()
+(write #())(newline)
+
+; CHECK: #(5)
+(write #(5))(newline)
+
+; CHECK: #(42)
+(write #((id 42)))(newline)
+
+; CHECK: #(1 2 "yo" "moo")
+(write #(1 2 "yo" (id "moo")))(newline)
+
+; CHECK: #(#(1 2 "yo" "moo"))
+(write #(#(1 2 "yo" (id "moo"))))(newline)