[5.3] [bugfix] Use iife for the scripts core and load validate as module (joomla#43758)

* iife

* fixes

* nope

* nope

* cs

* Update validate.es6.js

* CS

* CS

* oops

* what

* cs

* cs

* x

* fix

---------

Co-authored-by: Allon Moritz <[email protected]>

Author: dgrammatiko

build/build-modules-js/javascript/compile-to-es2017.mjs

@@ -10,13 +10,6 @@ import { babel } from '@rollup/plugin-babel';
 import { minifyCode } from './minify.mjs';
 import { getPackagesUnderScope } from '../init/common/resolve-package.cjs';
 
-function esmOrIife(file) {
-  if (file.endsWith('core.es6.js') || file.endsWith('validate.es6.js')) {
-    return 'iife';
-  }
-  return 'es';
-}
-
 // List of external modules that should not be resolved by rollup
 const externalModules = [];
 const collectExternals = () => {
@@ -91,7 +84,7 @@ export const handleESMFile = async (file) => {
   });
 
   bundle.write({
-    format: esmOrIife(file),
+    format: file.endsWith('core.es6.js') ? 'iife' : 'es',
     sourcemap: false,
     file: resolve(`${newPath}.js`),
   })

build/media_source/system/joomla.asset.json

@@ -173,7 +173,7 @@
       "type": "script",
       "class": "FormValidateAssetItem",
       "attributes": {
-        "defer": true
+        "type": "module"
       },
       "dependencies": [
         "core"

build/media_source/system/js/fields/validate.es6.js

@@ -2,9 +2,6 @@
  * @copyright  (C) 2018 Open Source Matters, Inc. <https://www.joomla.org>
  * @license    GNU General Public License version 2 or later; see LICENSE.txt
  */
-
-'use strict';
-
 import punycode from 'punycode';
 
 class JFormValidator {
@@ -317,14 +314,7 @@ class JFormValidator {
   }
 }
 
-const initialize = () => {
-  document.formvalidator = new JFormValidator();
-
-  // Cleanup
-  document.removeEventListener('DOMContentLoaded', initialize);
-};
-
-document.addEventListener('DOMContentLoaded', initialize);
+document.formvalidator = new JFormValidator();
 
 /**
  * Expose the classes to the global scope