[6.0] Removing defs of JPATH_COMPONENT* from installation app (joomla#45250)

* Removing definitions of JPATH_COMPONENT* from installation app
* Set basepath in installer application

Author: Hackwar

installation/src/Application/CliInstallationApplication.php

@@ -121,10 +121,6 @@ public function __construct(
         // Store the debug value to config based on the JDEBUG flag.
         $this->config->set('debug', JDEBUG);
 
-        \define('JPATH_COMPONENT', JPATH_BASE);
-        \define('JPATH_COMPONENT_SITE', JPATH_SITE);
-        \define('JPATH_COMPONENT_ADMINISTRATOR', JPATH_ADMINISTRATOR);
-
         // Register the config to Factory.
         Factory::$config   = $this->config;
         Factory::$language = $language;

installation/src/Application/InstallationApplication.php

@@ -187,11 +187,6 @@ public function dispatch()
         // Register the document object with Factory.
         Factory::$document = $document;
 
-        // Define component path.
-        \define('JPATH_COMPONENT', JPATH_BASE);
-        \define('JPATH_COMPONENT_SITE', JPATH_SITE);
-        \define('JPATH_COMPONENT_ADMINISTRATOR', JPATH_ADMINISTRATOR);
-
         // Execute the task.
         ob_start();
         $this->executeController();
@@ -301,7 +296,7 @@ private function executeController()
         $factory->setDatabase($this->getContainer()->get(DatabaseInterface::class));
 
         // Create the instance
-        $controller = $factory->createController($controllerName, 'Installation', [], $this, $this->input);
+        $controller = $factory->createController($controllerName, 'Installation', ['base_path' => JPATH_INSTALLATION], $this, $this->input);
 
         // Execute the task
         $controller->execute($task);