[5.4][PHP8.5] imagedestroy() function has been deprecated (joomla#46200)

---------

Co-authored-by: Quy Ton <[email protected]>
Co-authored-by: Harald Leithner <[email protected]>

Author: 3 people

libraries/src/Image/Filter/Backgroundfill.php

@@ -71,9 +71,6 @@ public function execute(array $options = [])
         // Move flattened result onto current handle.
         // If handle was palette-based, it'll stay like that.
         imagecopy($this->handle, $bg, 0, 0, 0, 0, $width, $height);
-
-        // Free up memory
-        imagedestroy($bg);
     }
 
     /**

libraries/src/Image/Image.php

@@ -1142,7 +1142,9 @@ protected function sanitizeWidth($width, $height)
     public function destroy()
     {
         if ($this->isLoaded()) {
-            return imagedestroy($this->getHandle());
+            $this->handle = null;
+
+            return true;
         }
 
         return false;

tests/Unit/Plugin/Task/Checkfiles/Extension/CheckfilesPluginTest.php

@@ -59,7 +59,6 @@ public function setUp(): void
         $image = imagecreate(200, 200);
         imagecolorallocate($image, 255, 255, 0);
         imagepng($image, $this->tmpFolder . '/test.png');
-        imagedestroy($image);
     }
 
     /**