[5.2] Invalid pass-by-reference usage (joomla#41971)

Author: Denitz

administrator/components/com_menus/src/Model/MenuModel.php

@@ -125,7 +125,7 @@ protected function populateState()
      *
      * @since   1.6
      */
-    public function &getItem($itemId = null)
+    public function getItem($itemId = null)
     {
         $itemId = (!empty($itemId)) ? $itemId : (int) $this->getState('menu.id');
 

administrator/components/com_messages/src/Model/ConfigModel.php

@@ -57,7 +57,7 @@ protected function populateState()
      *
      * @since   1.6
      */
-    public function &getItem()
+    public function getItem()
     {
         $item   = new CMSObject();
         $userid = (int) $this->getState('user.id');

administrator/components/com_modules/src/Model/PositionsModel.php

@@ -110,7 +110,7 @@ public function getItems()
                     ->bind(':clientid', $clientId, ParameterType::INTEGER);
 
                 if ($search) {
-                    $search = '%' . str_replace(' ', '%', trim($search), true) . '%';
+                    $search = '%' . str_replace(' ', '%', trim($search)) . '%';
                     $query->where($db->quoteName('position') . ' LIKE :position')
                         ->bind(':position', $search);
                 }

administrator/components/com_templates/src/Model/TemplateModel.php

@@ -625,7 +625,7 @@ protected function populateState()
      *
      * @since   1.6
      */
-    public function &getTemplate()
+    public function getTemplate()
     {
         if (empty($this->template)) {
             $pk  = (int) $this->getState('extension.id');