[6.0] Accesslevel edit - simplify (joomla#45588)

* Simplify access level edit
* deprecate language string
* Fix test
* add tab
* cs

Author: chmst

administrator/components/com_users/tmpl/level/edit.php

@@ -20,37 +20,18 @@
 $wa = $this->getDocument()->getWebAssetManager();
 $wa->useScript('keepalive')
     ->useScript('form.validate');
-
 ?>
 
 <form action="<?php echo Route::_('index.php?option=com_users&id=' . (int) $this->item->id); ?>" method="post" name="adminForm" id="level-form" aria-label="<?php echo Text::_('COM_USERS_LEVEL_FORM_' . ((int) $this->item->id === 0 ? 'NEW' : 'EDIT'), true); ?>" class="form-validate main-card">
-    <?php echo HTMLHelper::_('uitab.startTabSet', 'myTab', ['active' => 'details', 'recall' => true, 'breakpoint' => 768]); ?>
-
-        <?php echo HTMLHelper::_('uitab.addTab', 'myTab', 'details', Text::_('COM_USERS_LEVEL_DETAILS')); ?>
-            <fieldset class="options-form">
-                <legend><?php echo Text::_('COM_USERS_LEVEL_DETAILS'); ?></legend>
-                <div class="control-group">
-                    <div class="control-label">
-                        <?php echo $this->form->getLabel('title'); ?>
-                    </div>
-                    <div class="controls">
-                        <?php echo $this->form->getInput('title'); ?>
-                    </div>
-                </div>
-            </fieldset>
-        <?php echo HTMLHelper::_('uitab.endTab'); ?>
-
-        <?php echo HTMLHelper::_('uitab.addTab', 'myTab', 'groups', Text::_('COM_USERS_USER_GROUPS_HAVING_ACCESS')); ?>
+    <?php echo HTMLHelper::_('uitab.startTabSet', 'myTab', ['active' => 'groups', 'recall' => true, 'breakpoint' => 768]); ?>
+        <?php echo HTMLHelper::_('uitab.addTab', 'myTab', 'groups', Text::_('COM_USERS_USERGROUP_DETAILS')); ?>
+            <?php echo $this->form->renderField('title'); ?>
             <fieldset class="options-form">
                 <legend><?php echo Text::_('COM_USERS_USER_GROUPS_HAVING_ACCESS'); ?></legend>
-                <div>
-                    <?php echo HTMLHelper::_('access.usergroups', 'jform[rules]', $this->item->rules, true); ?>
-                </div>
+                <?php echo HTMLHelper::_('access.usergroups', 'jform[rules]', $this->item->rules, true); ?>
             </fieldset>
         <?php echo HTMLHelper::_('uitab.endTab'); ?>
-
     <?php echo HTMLHelper::_('uitab.endTabSet'); ?>
-
     <input type="hidden" name="task" value="">
     <?php echo HTMLHelper::_('form.token'); ?>
-</form>
+</form>

administrator/language/en-GB/com_users.ini

@@ -200,6 +200,7 @@ COM_USERS_LBL_SELECT_INSTRUCTIONS="Please select how you would like to verify yo
 COM_USERS_LEVELS_N_ITEMS_DELETED="%d View Permission Levels deleted."
 COM_USERS_LEVELS_N_ITEMS_DELETED_1="View Permission Level deleted."
 COM_USERS_LEVELS_TABLE_CAPTION="Viewing Access Levels"
+; The following string is deprecated and will be removed with 8.0
 COM_USERS_LEVEL_DETAILS="Level Details"
 COM_USERS_LEVEL_FIELD_TITLE_LABEL="Level Title"
 COM_USERS_LEVEL_FORM_EDIT="Edit Viewing Access Level"

tests/System/integration/administrator/components/com_users/Levels.cy.js

@@ -19,7 +19,7 @@ describe('Test in backend that the user access level list', () => {
   it('can open the access level form', () => {
     cy.clickToolbarButton('New');
 
-    cy.contains('Level Details');
+    cy.contains('User Groups With Viewing Access');
   });
 
   it('can delete the test level', () => {