[5.3] Removing calls to legacy ->set() (joomla#44011)

Hackwar · web-flow · commit 6ab1ee9e1110 · 2024-10-05T13:19:26.000+02:00
* Removing calls to legacy -&gt;set()

* Codestyle

* Removing additional calls
diff --git a/administrator/components/com_fields/tmpl/field/edit.php b/administrator/components/com_fields/tmpl/field/edit.php
@@ -55,27 +55,24 @@
                 <?php endforeach; ?>
             </div>
             <div class="col-lg-3">
-                <?php $this->set(
-                    'fields',
-                    [
-                            [
-                                'published',
-                                'state',
-                                'enabled',
-                            ],
-                            'group_id',
-                            'assigned_cat_ids',
-                            'access',
-                            'language',
-                            'note',
-                        ]
-                ); ?>
+                <?php $this->fields = [
+                        [
+                            'published',
+                            'state',
+                            'enabled',
+                        ],
+                        'group_id',
+                        'assigned_cat_ids',
+                        'access',
+                        'language',
+                        'note',
+                    ]; ?>
                 <?php echo LayoutHelper::render('joomla.edit.global', $this); ?>
-                <?php $this->set('fields', null); ?>
+                <?php $this->fields = null; ?>
             </div>
         </div>
         <?php echo HTMLHelper::_('uitab.endTab'); ?>
-        <?php $this->set('ignore_fieldsets', ['fieldparams']); ?>
+        <?php $this->ignore_fieldsets = ['fieldparams']; ?>
         <?php echo LayoutHelper::render('joomla.edit.params', $this); ?>
         <?php echo HTMLHelper::_('uitab.addTab', 'myTab', 'publishing', Text::_('JGLOBAL_FIELDSET_PUBLISHING', true)); ?>
         <fieldset id="fieldset-publishingdata" class="options-form">
diff --git a/administrator/components/com_fields/tmpl/group/edit.php b/administrator/components/com_fields/tmpl/group/edit.php
@@ -41,25 +41,22 @@
                 <?php echo $this->form->renderField('description'); ?>
             </div>
             <div class="col-lg-3">
-                <?php $this->set(
-                    'fields',
-                    [
-                            [
-                                'published',
-                                'state',
-                                'enabled',
-                            ],
-                            'access',
-                            'language',
-                            'note',
-                        ]
-                ); ?>
+                <?php $this->fields = [
+                        [
+                            'published',
+                            'state',
+                            'enabled',
+                        ],
+                        'access',
+                        'language',
+                        'note',
+                    ]; ?>
                 <?php echo LayoutHelper::render('joomla.edit.global', $this); ?>
-                <?php $this->set('fields', null); ?>
+                <?php $this->fields = null; ?>
             </div>
         </div>
         <?php echo HTMLHelper::_('uitab.endTab'); ?>
-        <?php $this->set('ignore_fieldsets', ['fieldparams']); ?>
+        <?php $this->ignore_fieldsets = ['fieldparams']; ?>
         <?php echo LayoutHelper::render('joomla.edit.params', $this); ?>
         <?php echo HTMLHelper::_('uitab.addTab', 'myTab', 'publishing', Text::_('JGLOBAL_FIELDSET_PUBLISHING', true)); ?>
         <fieldset id="fieldset-rules" class="options-form">
diff --git a/administrator/components/com_menus/src/Model/MenutypesModel.php b/administrator/components/com_menus/src/Model/MenutypesModel.php
@@ -145,7 +145,7 @@ public function getTypeOptions()
      */
     public function addReverseLookupUrl($option)
     {
-        $this->rlu[MenusHelper::getLinkKey($option->request)] = $option->get('title');
+        $this->rlu[MenusHelper::getLinkKey($option->request)] = $option->title;
     }
 
     /**
diff --git a/administrator/components/com_messages/src/Model/ConfigModel.php b/administrator/components/com_messages/src/Model/ConfigModel.php
@@ -85,7 +85,8 @@ public function getItem()
         }
 
         foreach ($rows as $row) {
-            $item->set($row->cfg_name, $row->cfg_value);
+            $property        = $row->cfg_name;
+            $item->$property = $row->cfg_value;
         }
 
         $this->preprocessData('com_messages.config', $item);
diff --git a/administrator/components/com_messages/src/View/Message/HtmlView.php b/administrator/components/com_messages/src/View/Message/HtmlView.php
@@ -105,7 +105,7 @@ protected function addToolbar()
             $sender = $this->getUserFactory()->loadUserById($this->item->user_id_from);
 
             if (
-                $sender->id !== $app->getIdentity()->get('id') && ($sender->authorise('core.admin')
+                $sender->id !== $app->getIdentity()->id && ($sender->authorise('core.admin')
                 || $sender->authorise('core.manage', 'com_messages') && $sender->authorise('core.login.admin'))
                 && $app->getIdentity()->authorise('core.manage', 'com_users')
             ) {
diff --git a/administrator/components/com_plugins/src/Helper/PluginsHelper.php b/administrator/components/com_plugins/src/Helper/PluginsHelper.php
@@ -116,7 +116,7 @@ public function parseXMLTemplateFile($templateBaseDir, $templateDir)
             }
 
             foreach ($xml as $key => $value) {
-                $data->set($key, $value);
+                $data->$key = $value;
             }
         }
 
diff --git a/administrator/components/com_templates/src/Helper/TemplatesHelper.php b/administrator/components/com_templates/src/Helper/TemplatesHelper.php
@@ -99,7 +99,7 @@ public static function parseXMLTemplateFile($templateBaseDir, $templateDir)
             }
 
             foreach ($xml as $key => $value) {
-                $data->set($key, $value);
+                $data->$key = $value;
             }
         }
 
diff --git a/administrator/components/com_users/src/Helper/Mfa.php b/administrator/components/com_users/src/Helper/Mfa.php
@@ -112,7 +112,7 @@ public static function getConfigurationInterface(User $user): ?string
         $view->setDocument($app->getDocument());
         $view->returnURL = base64_encode(Uri::getInstance()->toString());
         $view->user      = $user;
-        $view->set('forHMVC', true);
+        $view->forHMVC   = true;
         $view->setLanguage($app->getLanguage());
 
         @ob_start();
diff --git a/api/components/com_contact/src/Controller/ContactController.php b/api/components/com_contact/src/Controller/ContactController.php
@@ -205,7 +205,7 @@ private function _sendEmail($data, $contact, $emailCopyToSender)
 
         if ($contact->email_to == '' && $contact->user_id != 0) {
             $contact_user      = $this->getUserFactory()->loadUserById($contact->user_id);
-            $contact->email_to = $contact_user->get('email');
+            $contact->email_to = $contact_user->email;
         }
 
         $templateData = [
diff --git a/components/com_contact/src/Controller/DisplayController.php b/components/com_contact/src/Controller/DisplayController.php
@@ -69,7 +69,7 @@ public function display($cachable = false, $urlparams = [])
         $vName = $this->input->get('view', 'categories');
         $this->input->set('view', $vName);
 
-        if ($this->app->getIdentity()->get('id')) {
+        if ($this->app->getIdentity()->id) {
             $cachable = false;
         }
 
diff --git a/components/com_newsfeeds/src/Controller/DisplayController.php b/components/com_newsfeeds/src/Controller/DisplayController.php
@@ -42,7 +42,7 @@ public function display($cachable = false, $urlparams = false)
         $vName = $this->input->get('view', 'categories');
         $this->input->set('view', $vName);
 
-        if ($this->app->getIdentity()->get('id') || ($this->input->getMethod() === 'POST' && $vName === 'category')) {
+        if ($this->app->getIdentity()->id || ($this->input->getMethod() === 'POST' && $vName === 'category')) {
             $cachable = false;
         }
 
diff --git a/components/com_users/src/Controller/ProfileController.php b/components/com_users/src/Controller/ProfileController.php
@@ -52,10 +52,8 @@ public function edit()
             return false;
         }
 
-        $cookieLogin = $user->get('cookieLogin');
-
         // Check if the user logged in with a cookie
-        if (!empty($cookieLogin)) {
+        if (isset($user->cookieLogin) && !empty($user->cookieLogin)) {
             // If so, the user must login to edit the password and other data.
             $app->enqueueMessage(Text::_('JGLOBAL_REMEMBER_MUST_LOGIN'), 'message');
             $this->setRedirect(Route::_('index.php?option=com_users&view=login', false));
diff --git a/components/com_users/src/Model/RegistrationModel.php b/components/com_users/src/Model/RegistrationModel.php
@@ -140,9 +140,9 @@ public function activate($token)
             // Compile the admin notification mail values.
             $data               = $user->getProperties();
             $data['activation'] = ApplicationHelper::getHash(UserHelper::genRandomPassword());
-            $user->set('activation', $data['activation']);
-            $data['siteurl']  = Uri::base();
-            $data['activate'] = Route::link(
+            $user->activation   = $data['activation'];
+            $data['siteurl']    = Uri::base();
+            $data['activate']   = Route::link(
                 'site',
                 'index.php?option=com_users&task=registration.activate&token=' . $data['activation'],
                 false,
@@ -205,8 +205,8 @@ public function activate($token)
             }
         } elseif (($userParams->get('useractivation') == 2) && $user->getParam('activate', 0)) {
             // Admin activation is on and admin is activating the account
-            $user->set('activation', '');
-            $user->set('block', '0');
+            $user->activation = '';
+            $user->block      = '0';
 
             // Compile the user activated notification mail values.
             $data = $user->getProperties();
@@ -240,8 +240,8 @@ public function activate($token)
                 return false;
             }
         } else {
-            $user->set('activation', '');
-            $user->set('block', '0');
+            $user->activation = '';
+            $user->block      = '0';
         }
 
         // Store the user object.
diff --git a/components/com_users/src/View/Profile/HtmlView.php b/components/com_users/src/View/Profile/HtmlView.php
@@ -116,9 +116,7 @@ public function display($tpl = null)
         }
 
         // View also takes responsibility for checking if the user logged in with remember me.
-        $cookieLogin = $user->get('cookieLogin');
-
-        if (!empty($cookieLogin)) {
+        if (isset($user->cookieLogin) && !empty($user->cookieLogin)) {
             // If so, the user must login to edit the password and other data.
             // What should happen here? Should we force a logout which destroys the cookies?
             $app = Factory::getApplication();
diff --git a/components/com_users/tmpl/login/default.php b/components/com_users/tmpl/login/default.php
@@ -12,9 +12,7 @@
 
 /** @var \Joomla\Component\Users\Site\View\Login\HtmlView $this */
 
-$cookieLogin = $this->user->get('cookieLogin');
-
-if (!empty($cookieLogin) || $this->user->guest) {
+if ((isset($this->user->cookieLogin) && !empty($this->user->cookieLogin)) || $this->user->guest) {
     // The user is not logged in or needs to provide a password.
     echo $this->loadTemplate('login');
 } else {
diff --git a/installation/src/Model/LanguagesModel.php b/installation/src/Model/LanguagesModel.php
@@ -249,7 +249,7 @@ protected function getPackageUrl($remoteManifest)
         $update->loadFromXml($remoteManifest);
 
         // Get the download url from the remote manifest
-        $downloadUrl = $update->get('downloadurl', false);
+        $downloadUrl = $update->downloadurl ?? false;
 
         // Check if the download url exist, otherwise return empty value
         if ($downloadUrl === false) {
diff --git a/libraries/src/Access/Rules.php b/libraries/src/Access/Rules.php
@@ -174,7 +174,7 @@ public function getAllowed($identity)
 
         foreach ($this->data as $name => &$action) {
             if ($action->allow($identity)) {
-                $allowed->set($name, true);
+                $allowed->$name = true;
             }
         }
 
diff --git a/libraries/src/Application/CMSApplication.php b/libraries/src/Application/CMSApplication.php
@@ -905,7 +905,7 @@ public function login($credentials, $options = [])
             $user = Factory::getUser();
 
             if ($response->type === 'Cookie') {
-                $user->set('cookieLogin', true);
+                $user->cookieLogin = true;
             }
 
             if (\in_array(false, $results, true) == false) {
diff --git a/libraries/src/MVC/Controller/ApiController.php b/libraries/src/MVC/Controller/ApiController.php
@@ -204,13 +204,15 @@ public function displayList()
         $offset         = null;
 
         if (\array_key_exists('offset', $paginationInfo)) {
-            $offset = $paginationInfo['offset'];
-            $this->modelState->set($this->context . '.limitstart', $offset);
+            $offset                      = $paginationInfo['offset'];
+            $property                    = $this->context . '.limitstart';
+            $this->modelState->$property = $offset;
         }
 
         if (\array_key_exists('limit', $paginationInfo)) {
-            $limit = $paginationInfo['limit'];
-            $this->modelState->set($this->context . '.list.limit', $limit);
+            $limit                       = $paginationInfo['limit'];
+            $property                    = $this->context . '.list.limit';
+            $this->modelState->$property = $limit;
         }
 
         $viewType   = $this->app->getDocument()->getType();
diff --git a/libraries/src/MVC/View/AbstractView.php b/libraries/src/MVC/View/AbstractView.php
@@ -160,7 +160,11 @@ public function get($property, $default = null)
             }
         }
 
-        return $this->legacyGet($property, $default);
+        if (isset($this->$property)) {
+            return $this->$property;
+        }
+
+        return $default;
     }
 
     /**
diff --git a/libraries/src/User/User.php b/libraries/src/User/User.php
@@ -628,7 +628,7 @@ public function bind(&$array)
             $array['password'] = UserHelper::hashPassword($array['password']);
 
             // Set the registration timestamp
-            $this->set('registerDate', Factory::getDate()->toSql());
+            $this->registerDate = Factory::getDate()->toSql();
         } else {
             // Updating an existing user
             if (!empty($array['password'])) {
diff --git a/libraries/src/User/UserHelper.php b/libraries/src/User/UserHelper.php
@@ -374,8 +374,8 @@ public static function activateUser($activation)
         if ($id) {
             $user = User::getInstance($id);
 
-            $user->set('block', '0');
-            $user->set('activation', '');
+            $user->block      = 0;
+            $user->activation = '';
 
             // Time to take care of business.... store the user.
             if (!$user->save()) {
diff --git a/modules/mod_articles_category/src/Helper/ArticlesCategoryHelper.php b/modules/mod_articles_category/src/Helper/ArticlesCategoryHelper.php
@@ -69,7 +69,7 @@ public function getArticles(Registry $params, SiteApplication $app)
 
         // Access filter
         $access     = !ComponentHelper::getParams('com_content')->get('show_noauth');
-        $authorised = Access::getAuthorisedViewLevels($app->getIdentity()->get('id'));
+        $authorised = Access::getAuthorisedViewLevels($app->getIdentity()->id);
         $articles->setState('filter.access', $access);
 
         // Prep for Normal or Dynamic Modes
diff --git a/modules/mod_articles_popular/src/Helper/ArticlesPopularHelper.php b/modules/mod_articles_popular/src/Helper/ArticlesPopularHelper.php
@@ -121,7 +121,7 @@ public function getArticles(Registry $moduleParams, SiteApplication $app)
             $items      = [];
             $itemParams = new \stdClass();
 
-            $itemParams->authorised = Access::getAuthorisedViewLevels($app->getIdentity()->get('id'));
+            $itemParams->authorised = Access::getAuthorisedViewLevels($app->getIdentity()->id);
             $itemParams->access     = $access;
 
             foreach ($articlesModel->getItems() as $item) {
diff --git a/plugins/user/joomla/src/Extension/Joomla.php b/plugins/user/joomla/src/Extension/Joomla.php
@@ -500,7 +500,7 @@ private function getUser($user, $options = [])
             }
         } else {
             // No existing user and autoregister off, this is a temporary user.
-            $instance->set('tmp_user', true);
+            $instance->tmp_user = true;
         }
 
         return $instance;

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ public function getTypeOptions()`
`145`	`145`	`*/`
`146`	`146`	`public function addReverseLookupUrl($option)`
`147`	`147`	`{`
`148`		`- $this->rlu[MenusHelper::getLinkKey($option->request)] = $option->get('title');`
	`148`	`+ $this->rlu[MenusHelper::getLinkKey($option->request)] = $option->title;`
`149`	`149`	`}`
`150`	`150`
`151`	`151`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,8 @@ public function getItem()`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`foreach ($rows as $row) {`
`88`		`- $item->set($row->cfg_name, $row->cfg_value);`
	`88`	`+ $property = $row->cfg_name;`
	`89`	`+ $item->$property = $row->cfg_value;`
`89`	`90`	`}`
`90`	`91`
`91`	`92`	`$this->preprocessData('com_messages.config', $item);`
Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ public function parseXMLTemplateFile($templateBaseDir, $templateDir)`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`foreach ($xml as $key => $value) {`
`119`		`- $data->set($key, $value);`
	`119`	`+ $data->$key = $value;`
`120`	`120`	`}`
`121`	`121`	`}`
`122`	`122`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ public static function parseXMLTemplateFile($templateBaseDir, $templateDir)`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`foreach ($xml as $key => $value) {`
`102`		`- $data->set($key, $value);`
	`102`	`+ $data->$key = $value;`
`103`	`103`	`}`
`104`	`104`	`}`
`105`	`105`
Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ private function _sendEmail($data, $contact, $emailCopyToSender)`
`205`	`205`
`206`	`206`	`if ($contact->email_to == '' && $contact->user_id != 0) {`
`207`	`207`	`$contact_user = $this->getUserFactory()->loadUserById($contact->user_id);`
`208`		`- $contact->email_to = $contact_user->get('email');`
	`208`	`+ $contact->email_to = $contact_user->email;`
`209`	`209`	`}`
`210`	`210`
`211`	`211`	`$templateData = [`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public function display($cachable = false, $urlparams = [])`
`69`	`69`	`$vName = $this->input->get('view', 'categories');`
`70`	`70`	`$this->input->set('view', $vName);`
`71`	`71`
`72`		`- if ($this->app->getIdentity()->get('id')) {`
	`72`	`+ if ($this->app->getIdentity()->id) {`
`73`	`73`	`$cachable = false;`
`74`	`74`	`}`
`75`	`75`