[5.3] Remove unused exception variable in try catch block for libraries (joomla#44922)

---------

Co-authored-by: Martina  Scholz <[email protected]>

Author: joomdonation

libraries/src/Access/Access.php

@@ -1044,7 +1044,7 @@ public static function getActionsFromData($data, $xpath = "/access/section[@name
         if (\is_string($data)) {
             try {
                 $data = new \SimpleXMLElement($data);
-            } catch (\Exception $e) {
+            } catch (\Exception) {
                 return false;
             }
 

libraries/src/Application/CMSApplication.php

@@ -498,7 +498,7 @@ public function getCfg($varname, $default = null)
                 Log::WARNING,
                 'deprecated'
             );
-        } catch (\RuntimeException $exception) {
+        } catch (\RuntimeException) {
             // Informational log only
         }
 

libraries/src/Application/ConsoleApplication.php

@@ -525,7 +525,7 @@ protected function populateHttpHost()
          */
         try {
             $uri = Uri::getInstance($liveSite);
-        } catch (\RuntimeException $e) {
+        } catch (\RuntimeException) {
             $uri = Uri::getInstance('https://joomla.invalid/set/by/console/application');
         }
 

libraries/src/Application/DaemonApplication.php

@@ -517,7 +517,7 @@ protected function daemonize()
                 $this->processId = (int) posix_getpid();
                 $this->parentId  = $this->processId;
             }
-        } catch (\RuntimeException $e) {
+        } catch (\RuntimeException) {
             Log::add('Unable to fork.', Log::EMERGENCY);
 
             return false;

libraries/src/Application/EventAware.php

@@ -60,7 +60,7 @@ public function registerEvent($event, callable $handler)
     {
         try {
             $this->getDispatcher()->addListener($event, $handler);
-        } catch (\UnexpectedValueException $e) {
+        } catch (\UnexpectedValueException) {
             // No dispatcher is registered, don't throw an error (mimics old behavior)
         }
 
@@ -93,7 +93,7 @@ public function triggerEvent($eventName, $args = [])
     {
         try {
             $dispatcher = $this->getDispatcher();
-        } catch (\UnexpectedValueException $exception) {
+        } catch (\UnexpectedValueException) {
             $this->getLogger()->error(\sprintf('Dispatcher not set in %s, cannot trigger events.', \get_class($this)));
 
             return [];

libraries/src/Application/MultiFactorAuthenticationHandler.php

@@ -59,7 +59,7 @@ protected function isHandlingMultiFactorAuthentication(): bool
         // Multi-factor Authentication checks take place only for logged in users.
         try {
             $user = $this->getIdentity();
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             return false;
         }
 
@@ -255,7 +255,7 @@ private function needsMultiFactorAuthenticationRedirection(): bool
         // Make sure we are logged in
         try {
             $user = $this->getIdentity();
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             // This would happen if we are in CLI or under an old Joomla! version. Either case is not supported.
             return false;
         }
@@ -356,7 +356,7 @@ private function hasRejectedMultiFactorAuthenticationSetup(): bool
 
         try {
             $result = $db->setQuery($query)->loadResult();
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             $result = 1;
         }
 
@@ -491,7 +491,7 @@ private function decryptLegacyTFAString(string $secret, string $stringToDecrypt)
         // Is this already decrypted?
         try {
             $decrypted = @json_decode($stringToDecrypt, true);
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             $decrypted = null;
         }
 

libraries/src/Cache/CacheController.php

@@ -103,7 +103,7 @@ public static function getInstance($type = 'output', $options = [])
 
         try {
             return Factory::getContainer()->get(CacheControllerFactoryInterface::class)->createCacheController($type, $options);
-        } catch (\RuntimeException $e) {
+        } catch (\RuntimeException) {
             $type  = strtolower(preg_replace('/[^A-Z0-9_\.-]/i', '', $type));
             $class = 'JCacheController' . ucfirst($type);
 

libraries/src/Cache/Storage/RedisStorage.php

@@ -129,7 +129,7 @@ protected function getConnection()
 
         try {
             static::$_redis->ping();
-        } catch (\RedisException $e) {
+        } catch (\RedisException) {
             static::$_redis = null;
 
             throw new CacheConnectingException('Redis ping failed', 500);

libraries/src/Captcha/Google/HttpBridgePostRequestMethod.php

@@ -69,7 +69,7 @@ public function submit(RequestParameters $params)
             $response = $this->http->post(self::SITE_VERIFY_URL, $params->toArray());
 
             return (string) $response->getBody();
-        } catch (InvalidResponseCodeException $exception) {
+        } catch (InvalidResponseCodeException) {
             return '';
         }
     }

libraries/src/Categories/Categories.php

@@ -157,7 +157,7 @@ public static function getInstance($extension, $options = [])
             if ($component instanceof CategoryServiceInterface) {
                 $categories = $component->getCategory($options, \count($parts) > 1 ? $parts[1] : '');
             }
-        } catch (SectionNotFoundException $e) {
+        } catch (SectionNotFoundException) {
             $categories = null;
         }
 
@@ -236,7 +236,7 @@ protected function _load($id)
     {
         try {
             $db = $this->getDatabase();
-        } catch (DatabaseNotFoundException $e) {
+        } catch (DatabaseNotFoundException) {
             @trigger_error(\sprintf('Database must be set, this will not be caught anymore in 5.0.'), E_USER_DEPRECATED);
             $db = Factory::getContainer()->get(DatabaseInterface::class);
         }