Skip to content

Commit 8141452

Browse files
authored
[5.2] Fix a11y issue in accordion (role) (joomla#40578)
1 parent a0dc126 commit 8141452

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

libraries/src/HTML/Helpers/Bootstrap.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -676,7 +676,7 @@ public static function startAccordion($selector = 'myAccordian', $options = []):
676676

677677
static::$loaded[__METHOD__][$selector] = $opt;
678678

679-
return '<div id="' . $selector . '" class="accordion" role="tablist">';
679+
return '<div id="' . $selector . '" class="accordion">';
680680
}
681681

682682
/**
@@ -715,11 +715,11 @@ public static function addSlide($selector, $text, $id, $class = ''): string
715715
return <<<HTMLSTR
716716
<div class="accordion-item $class">
717717
<h2 class="accordion-header" id="$id-heading">
718-
<button class="accordion-button $collapsed" type="button" data-bs-toggle="collapse" data-bs-target="#$id" aria-expanded="$ariaExpanded" aria-controls="$id" role="tab">
718+
<button class="accordion-button $collapsed" type="button" data-bs-toggle="collapse" data-bs-target="#$id" aria-expanded="$ariaExpanded" aria-controls="$id">
719719
$text
720720
</button>
721721
</h2>
722-
<div id="$id" class="accordion-collapse collapse $in" aria-labelledby="$id-heading" $parent role="tabpanel">
722+
<div id="$id" class="accordion-collapse collapse $in" aria-labelledby="$id-heading" $parent>
723723
<div class="accordion-body">
724724
HTMLSTR;
725725
}

0 commit comments

Comments
 (0)