[5.4] Revert b/c breaking change in AbstractView::get (joomla#45940)

* Revert "[5.4] Replace deprecation AbstractView::get() in layouts (joomla#45702)"
* This reverts commit f1906ba.

Author: brianteeman

administrator/components/com_menus/layouts/joomla/menu/edit_modules.php

@@ -26,7 +26,7 @@
 
 $saveHistory = ComponentHelper::getParams($component)->get('save_history', 0);
 
-$fields = $displayData->fields ?? [
+$fields = $displayData->get('fields') ?: [
     ['parent', 'parent_id'],
     ['published', 'state', 'enabled'],
     ['category', 'catid'],
@@ -39,7 +39,7 @@
     'version_note',
 ];
 
-$hiddenFields = $displayData->hidden_fields ?? [];
+$hiddenFields = $displayData->get('hidden_fields') ?: [];
 
 if (!$saveHistory) {
     $hiddenFields[] = 'version_note';

components/com_contact/src/View/Categories/HtmlView.php

@@ -35,5 +35,5 @@ class HtmlView extends CategoriesView
      * @var    string  The name of the extension for the category
      * @since  3.2
      */
-    public $extension = 'com_contact';
+    protected $extension = 'com_contact';
 }

components/com_content/src/View/Categories/HtmlView.php

@@ -35,5 +35,5 @@ class HtmlView extends CategoriesView
      * @var    string  The name of the extension for the category
      * @since  3.2
      */
-    public $extension = 'com_content';
+    protected $extension = 'com_content';
 }

components/com_newsfeeds/src/View/Categories/HtmlView.php

@@ -35,5 +35,5 @@ class HtmlView extends CategoriesView
      * @var    string  The name of the extension for the category
      * @since  3.2
      */
-    public $extension = 'com_newsfeeds';
+    protected $extension = 'com_newsfeeds';
 }

layouts/joomla/content/categories_default.php

@@ -23,7 +23,7 @@
     <?php // If there is a description in the menu parameters use that; ?>
     <?php if ($displayData->params->get('categories_description')) : ?>
         <div class="category-desc base-desc">
-            <?php echo HTMLHelper::_('content.prepare', $displayData->params->get('categories_description'), '', $displayData->extension . '.categories'); ?>
+            <?php echo HTMLHelper::_('content.prepare', $displayData->params->get('categories_description'), '', $displayData->get('extension') . '.categories'); ?>
         </div>
     <?php else : ?>
         <?php // Otherwise get one from the database if it exists. ?>

layouts/joomla/content/category_default.php

@@ -20,7 +20,7 @@
  * layout you need to close this div either by overriding this file or in your main layout.
  */
 $params    = $displayData->params;
-$category  = $displayData->category;
+$category  = $displayData->get('category');
 $extension = $category->extension;
 $canEdit   = $params->get('access-edit');
 $className = substr($extension, 4);
@@ -89,7 +89,7 @@
     <?php endif; ?>
     <?php echo $displayData->loadTemplate($displayData->subtemplatename); ?>
 
-    <?php if ($displayData->maxLevel != 0 && $displayData->children) : ?>
+    <?php if ($displayData->maxLevel != 0 && $displayData->get('children')) : ?>
         <div class="cat-children">
             <?php if ($params->get('show_category_heading_title_text', 1) == 1) : ?>
                 <h3>

layouts/joomla/edit/admin_modules.php

@@ -17,7 +17,7 @@
 $form   = $displayData->getForm();
 $input  = $app->getInput();
 
-$fields = $displayData->fields ?? [
+$fields = $displayData->get('fields') ?: [
     ['parent', 'parent_id'],
     ['published', 'state', 'enabled'],
     ['category', 'catid'],
@@ -30,7 +30,7 @@
     'version_note',
 ];
 
-$hiddenFields = $displayData->hidden_fields ?? [];
+$hiddenFields = $displayData->get('hidden_fields') ?: [];
 
 if (!ModuleHelper::isAdminMultilang()) {
     $hiddenFields[] = 'language';

layouts/joomla/edit/fieldset.php

@@ -15,17 +15,17 @@
 $app  = Factory::getApplication();
 $form = $displayData->getForm();
 
-$name = $displayData->fieldset;
+$name = $displayData->get('fieldset');
 $fieldSet = $form->getFieldset($name);
 
 if (empty($fieldSet)) {
     return;
 }
 
-$ignoreFields = $displayData->ignore_fields ?? [];
-$extraFields  = $displayData->extra_fields ?? [];
+$ignoreFields = $displayData->get('ignore_fields') ? : [];
+$extraFields  = $displayData->get('extra_fields') ? : [];
 
-if (!empty($displayData->showOptions) || ($displayData->show_options ?? 1)) {
+if (!empty($displayData->showOptions) || $displayData->get('show_options', 1)) {
     if (isset($extraFields[$name])) {
         foreach ($extraFields[$name] as $f) {
             if (in_array($f, $ignoreFields)) {

layouts/joomla/edit/global.php

@@ -28,7 +28,7 @@
 
 $saveHistory = ComponentHelper::getParams($component)->get('save_history', 0);
 
-$fields = $displayData->fields ?? [
+$fields = $displayData->get('fields') ?: [
     'transition',
     ['parent', 'parent_id'],
     ['published', 'state', 'enabled'],
@@ -42,7 +42,7 @@
     'version_note',
 ];
 
-$hiddenFields = $displayData->hidden_fields ?? [];
+$hiddenFields = $displayData->get('hidden_fields') ?: [];
 
 if (!$saveHistory) {
     $hiddenFields[] = 'version_note';

layouts/joomla/edit/params.php

@@ -18,27 +18,27 @@
 $app       = Factory::getApplication();
 $form      = $displayData->getForm();
 $fieldSets = $form->getFieldsets();
-$helper    = ($displayData->useCoreUI ?? false) ? 'uitab' : 'bootstrap';
+$helper    = $displayData->get('useCoreUI', false) ? 'uitab' : 'bootstrap';
 
 if (empty($fieldSets)) {
     return;
 }
 
-$ignoreFieldsets      = $displayData->ignore_fieldsets ?? [];
-$outputFieldsets      = $displayData->output_fieldsets ?? [];
-$ignoreFieldsetFields = $displayData->ignore_fieldset_fields ?? [];
-$ignoreFields         = $displayData->ignore_fields ?? [];
-$extraFields          = $displayData->extra_fields ?? [];
-$tabName              = $displayData->tab_name ?? 'myTab';
+$ignoreFieldsets      = $displayData->get('ignore_fieldsets') ?: [];
+$outputFieldsets      = $displayData->get('output_fieldsets') ?: [];
+$ignoreFieldsetFields = $displayData->get('ignore_fieldset_fields') ?: [];
+$ignoreFields         = $displayData->get('ignore_fields') ?: [];
+$extraFields          = $displayData->get('extra_fields') ?: [];
+$tabName              = $displayData->get('tab_name') ?: 'myTab';
 
 // These are required to preserve data on save when fields are not displayed.
-$hiddenFieldsets = $displayData->hiddenFieldsets ?? [];
+$hiddenFieldsets = $displayData->get('hiddenFieldsets') ?: [];
 
 // These are required to configure showing and hiding fields in the editor.
-$configFieldsets = $displayData->configFieldsets ?? [];
+$configFieldsets = $displayData->get('configFieldsets') ?: [];
 
 // Handle the hidden fieldsets when show_options is set false
-if (!($displayData->show_options ?? 1)) {
+if (!$displayData->get('show_options', 1)) {
     // The HTML buffer
     $html   = [];