[5.2] Fix increment on non-alphanumeric string deprecation (joomla#44173)

Author: QuyTon

administrator/components/com_banners/src/Model/BannerModel.php

@@ -347,6 +347,7 @@ protected function prepareTable($table)
             // Set the values
             $table->created    = $date->toSql();
             $table->created_by = $user->id;
+            $table->version    = 1;
 
             // Set ordering to the last item if not set
             if (empty($table->ordering)) {
@@ -364,10 +365,8 @@ protected function prepareTable($table)
             // Set the values
             $table->modified    = $date->toSql();
             $table->modified_by = $user->id;
+            $table->version++;
         }
-
-        // Increment the content version number.
-        $table->version++;
     }
 
     /**

administrator/components/com_contact/src/Model/ContactModel.php

@@ -363,6 +363,7 @@ protected function prepareTable($table)
         if (empty($table->id)) {
             // Set the values
             $table->created = $date;
+            $table->version = 1;
 
             // Set ordering to the last item if not set
             if (empty($table->ordering)) {
@@ -379,10 +380,8 @@ protected function prepareTable($table)
             // Set the values
             $table->modified    = $date;
             $table->modified_by = $this->getCurrentUser()->id;
+            $table->version++;
         }
-
-        // Increment the content version number.
-        $table->version++;
     }
 
     /**

administrator/components/com_content/src/Model/ArticleModel.php

@@ -347,7 +347,7 @@ protected function prepareTable($table)
         }
 
         // Increment the content version number.
-        $table->version++;
+        $table->version = empty($table->version) ? 1 : $table->version + 1;
 
         // Reorder the articles within the category so the new article is first
         if (empty($table->id)) {

administrator/components/com_newsfeeds/src/Model/NewsfeedModel.php

@@ -305,6 +305,7 @@ protected function prepareTable($table)
         if (empty($table->id)) {
             // Set the values
             $table->created = $date->toSql();
+            $table->version = 1;
 
             // Set ordering to the last item if not set
             if (empty($table->ordering)) {
@@ -321,10 +322,8 @@ protected function prepareTable($table)
             // Set the values
             $table->modified    = $date->toSql();
             $table->modified_by = $user->id;
+            $table->version++;
         }
-
-        // Increment the content version number.
-        $table->version++;
     }
 
     /**

administrator/components/com_tags/src/Model/TagModel.php

@@ -325,7 +325,7 @@ public function save($data)
     protected function prepareTable($table)
     {
         // Increment the content version number.
-        $table->version++;
+        $table->version = empty($table->version) ? 1 : $table->version + 1;
     }
 
     /**