Fix code logic in admin controllers (joomla#45037)

Author: joomdonation

administrator/components/com_banners/src/Controller/BannerController.php

@@ -71,7 +71,7 @@ protected function allowAdd($data = [])
      */
     protected function allowEdit($data = [], $key = 'id')
     {
-        $recordId   = (int) isset($data[$key]) ? $data[$key] : 0;
+        $recordId   = isset($data[$key]) ? (int) $data[$key] : 0;
         $categoryId = 0;
 
         if ($recordId) {

administrator/components/com_categories/src/Controller/CategoryController.php

@@ -91,7 +91,7 @@ protected function allowAdd($data = [])
      */
     protected function allowEdit($data = [], $key = 'parent_id')
     {
-        $recordId = (int) isset($data[$key]) ? $data[$key] : 0;
+        $recordId = isset($data[$key]) ? (int) $data[$key] : 0;
         $user     = $this->app->getIdentity();
 
         // Check "edit" permission on record asset (explicit or inherited)

administrator/components/com_contact/src/Controller/ContactController.php

@@ -63,7 +63,7 @@ protected function allowAdd($data = [])
      */
     protected function allowEdit($data = [], $key = 'id')
     {
-        $recordId = (int) isset($data[$key]) ? $data[$key] : 0;
+        $recordId = isset($data[$key]) ? (int) $data[$key] : 0;
 
         // Since there is no asset tracking, fallback to the component permissions.
         if (!$recordId) {

administrator/components/com_content/src/Controller/ArticleController.php

@@ -159,7 +159,7 @@ protected function allowAdd($data = [])
      */
     protected function allowEdit($data = [], $key = 'id')
     {
-        $recordId = (int) isset($data[$key]) ? $data[$key] : 0;
+        $recordId = isset($data[$key]) ? (int) $data[$key] : 0;
         $user     = $this->app->getIdentity();
 
         // Zero record (id:0), return component edit permission by calling parent controller method

administrator/components/com_fields/src/Controller/FieldController.php

@@ -95,7 +95,7 @@ protected function allowAdd($data = [])
      */
     protected function allowEdit($data = [], $key = 'id')
     {
-        $recordId = (int) isset($data[$key]) ? $data[$key] : 0;
+        $recordId = isset($data[$key]) ? (int) $data[$key] : 0;
         $user     = $this->app->getIdentity();
 
         // Zero record (id:0), return component edit permission by calling parent controller method

administrator/components/com_fields/src/Controller/GroupController.php

@@ -117,7 +117,7 @@ protected function allowAdd($data = [])
      */
     protected function allowEdit($data = [], $key = 'parent_id')
     {
-        $recordId = (int) isset($data[$key]) ? $data[$key] : 0;
+        $recordId = isset($data[$key]) ? (int) $data[$key] : 0;
         $user     = $this->app->getIdentity();
 
         // Zero record (parent_id:0), return component edit permission by calling parent controller method

administrator/components/com_modules/src/Controller/ModuleController.php

@@ -141,7 +141,7 @@ protected function allowSave($data, $key = 'id')
     protected function allowEdit($data = [], $key = 'id')
     {
         // Initialise variables.
-        $recordId = (int) isset($data[$key]) ? $data[$key] : 0;
+        $recordId = isset($data[$key]) ? (int) $data[$key] : 0;
 
         // Zero record (id:0), return component edit permission by calling parent controller method
         if (!$recordId) {

administrator/components/com_newsfeeds/src/Controller/NewsfeedController.php

@@ -68,7 +68,7 @@ protected function allowAdd($data = [])
      */
     protected function allowEdit($data = [], $key = 'id')
     {
-        $recordId = (int) isset($data[$key]) ? $data[$key] : 0;
+        $recordId = isset($data[$key]) ? (int) $data[$key] : 0;
 
         // Since there is no asset tracking, fallback to the component permissions.
         if (!$recordId) {

components/com_contact/src/Controller/ContactController.php

@@ -344,7 +344,7 @@ protected function allowAdd($data = [])
      */
     protected function allowEdit($data = [], $key = 'id')
     {
-        $recordId = (int) isset($data[$key]) ? $data[$key] : 0;
+        $recordId = isset($data[$key]) ? (int) $data[$key] : 0;
 
         if (!$recordId) {
             return false;

components/com_content/src/Controller/ArticleController.php

@@ -124,7 +124,7 @@ protected function allowAdd($data = [])
      */
     protected function allowEdit($data = [], $key = 'id')
     {
-        $recordId = (int) isset($data[$key]) ? $data[$key] : 0;
+        $recordId = isset($data[$key]) ? (int) $data[$key] : 0;
         $user     = $this->app->getIdentity();
 
         // Zero record (id:0), return component edit permission by calling parent controller method