[5.2] Remove get()/set() calls to table classes (joomla#43508)

* Remove get()/set() calls to table classes

* Codestyle

* Fixing issue

Author: Hackwar

administrator/components/com_categories/src/Model/CategoryModel.php

@@ -1026,7 +1026,7 @@ protected function batchCopy($value, $pks, $contexts)
             }
 
             // Get the new item ID
-            $newId = $this->table->get('id');
+            $newId = $this->table->id;
 
             // Add the new ID to the array
             $newIds[$pk] = $newId;

administrator/components/com_fields/src/Model/FieldModel.php

@@ -1192,7 +1192,7 @@ protected function batchCopy($value, $pks, $contexts)
                 }
 
                 // Get the new item ID
-                $newId = $table->get('id');
+                $newId = $table->id;
 
                 // Add the new ID to the array
                 $newIds[$pk] = $newId;

administrator/components/com_installer/src/Model/DatabaseModel.php

@@ -579,15 +579,15 @@ public function fixUpdateVersion($extensionId)
         $cache         = new Registry($table->manifest_cache);
         $updateVersion = $cache->get('version');
 
-        if ($table->get('type') === 'file' && $table->get('element') === 'joomla') {
+        if ($table->type === 'file' && $table->element === 'joomla') {
             $extensionVersion = new Version();
             $extensionVersion = $extensionVersion->getShortVersion();
         } else {
             $installationXML = InstallerHelper::getInstallationXML(
-                $table->get('element'),
-                $table->get('type'),
-                $table->get('client_id'),
-                $table->get('type') === 'plugin' ? $table->get('folder') : null
+                $table->element,
+                $table->type,
+                $table->client_id,
+                $table->type === 'plugin' ? $table->folder : null
             );
             $extensionVersion = (string) $installationXML->version;
         }
@@ -597,7 +597,7 @@ public function fixUpdateVersion($extensionId)
         }
 
         $cache->set('version', $extensionVersion);
-        $table->set('manifest_cache', $cache->toString());
+        $table->manifest_cache = $cache->toString();
 
         if ($table->store()) {
             return $extensionVersion;

administrator/components/com_joomlaupdate/src/Model/UpdateModel.php

@@ -745,7 +745,7 @@ public function finaliseUpgrade()
             $row->load($id);
 
             // Update name.
-            $row->set('name', 'files_joomla');
+            $row->name = 'files_joomla';
 
             // Update manifest.
             $row->manifest_cache = $installer->generateManifestCache();
@@ -761,18 +761,18 @@ public function finaliseUpgrade()
             }
         } else {
             // Add an entry to the extension table with a whole heap of defaults.
-            $row->set('name', 'files_joomla');
-            $row->set('type', 'file');
-            $row->set('element', 'joomla');
+            $row->name    = 'files_joomla';
+            $row->type    = 'file';
+            $row->element = 'joomla';
 
             // There is no folder for files so leave it blank.
-            $row->set('folder', '');
-            $row->set('enabled', 1);
-            $row->set('protected', 0);
-            $row->set('access', 0);
-            $row->set('client_id', 0);
-            $row->set('params', '');
-            $row->set('manifest_cache', $installer->generateManifestCache());
+            $row->folder         = '';
+            $row->enabled        = 1;
+            $row->protected      = 0;
+            $row->access         = 0;
+            $row->client_id      = 0;
+            $row->params         = '';
+            $row->manifest_cache = $installer->generateManifestCache();
 
             if (!$row->store()) {
                 $this->collectError('Write the manifest_cache', new \Exception('Writing the manifest_cache finished with "false" result.'));
@@ -783,7 +783,7 @@ public function finaliseUpgrade()
             }
 
             // Set the insert id.
-            $row->set('extension_id', $db->insertid());
+            $row->extension_id = $db->insertid();
 
             // Since we have created a module item, we add it to the installation step stack
             // so that if we have to rollback the changes we can undo it.

administrator/components/com_menus/src/Helper/MenusHelper.php

@@ -550,7 +550,7 @@ protected static function installPresetItems($node, $menutype)
                 throw new \Exception($table->getError());
             }
 
-            $item->id = $table->get('id');
+            $item->id = $table->id;
 
             if ($item->hasChildren()) {
                 static::installPresetItems($item, $menutype);

administrator/components/com_menus/src/Model/ItemModel.php

@@ -297,7 +297,7 @@ protected function batchCopy($value, $pks, $contexts)
             }
 
             // Get the new item ID
-            $newId = $table->get('id');
+            $newId = $table->id;
 
             // Add the new ID to the array
             $newIds[$pk] = $newId;
@@ -974,7 +974,7 @@ protected function populateState()
         if ($pk) {
             $table = $this->getTable();
             $table->load($pk);
-            $forcedClientId = $table->get('client_id', $forcedClientId);
+            $forcedClientId = isset($table->client_id) ? $table->client_id : $forcedClientId;
         }
 
         if (isset($forcedClientId) && $forcedClientId != $clientId) {
@@ -1454,7 +1454,7 @@ public function save($data)
         $this->setState('item.menutype', $table->menutype);
 
         // Load associated menu items, for now not supported for admin menu… may be later
-        if ($table->get('client_id') == 0 && Associations::isEnabled()) {
+        if ($table->client_id == 0 && Associations::isEnabled()) {
             // Adding self to the association
             $associations = $data['associations'] ?? [];
 

administrator/components/com_modules/src/Model/ModuleModel.php

@@ -191,7 +191,7 @@ protected function batchCopy($value, $pks, $contexts)
                 }
 
                 // Get the new item ID
-                $newId = $table->get('id');
+                $newId = $table->id;
 
                 // Add the new ID to the array
                 $newIds[$pk] = $newId;

administrator/components/com_scheduler/src/Model/TaskModel.php

@@ -699,7 +699,7 @@ public function unlock(array &$pks): bool
                 // Prune items that are already at the given state.
                 $lockedColumnName = $table->getColumnAlias('locked');
 
-                if (property_exists($table, $lockedColumnName) && \is_null($table->get($lockedColumnName))) {
+                if (property_exists($table, $lockedColumnName) && \is_null($table->$lockedColumnName)) {
                     unset($pks[$i]);
                 }
             }

administrator/components/com_workflow/src/Model/WorkflowModel.php

@@ -292,7 +292,7 @@ public function setDefault($pk, $value = 1)
                 $table->load(
                     [
                     'default'   => '1',
-                    'extension' => $table->get('extension'),
+                    'extension' => $table->extension,
                     ]
                 )
             ) {

administrator/modules/mod_menu/src/Menu/CssMenu.php

@@ -236,7 +236,7 @@ protected function check($node, Registry $params)
 
             $table->load(['menutype' => $menutype]);
 
-            $menutype = $table->get('title', $menutype);
+            $menutype = isset($table->title) ? $table->title : $menutype;
             $message  = Text::sprintf('MOD_MENU_IMPORTANT_ITEMS_INACCESSIBLE_LIST_WARNING', $menutype, implode(', ', $missing), $uri);
 
             $this->application->enqueueMessage($message, 'warning');