Skip to content

Commit ff63f78

Browse files
authored
[5.3] Logical css joomla tabs (joomla#44607)
* [5.3] Logical CSS properties Use logical CSS properties to avoid having to set different LTR and RTL css This is a redo of joomla#36034 which could not be merged at the time as browsers didnt support logical css properties for floats. They do now https://caniuse.com/?search=float-inline The css changed is for the highlighted areas of the screenshot. There is no visual change As this is a scss change then you will need to either rebuild the css or test with a prebuilt package Signed-off-by: BrianTeeman <[email protected]> * position Signed-off-by: BrianTeeman <[email protected]> * stylelint Signed-off-by: BrianTeeman <[email protected]> --------- Signed-off-by: BrianTeeman <[email protected]>
1 parent b9e6129 commit ff63f78

File tree

1 file changed

+6
-20
lines changed
  • build/media_source/templates/administrator/atum/scss/vendor/joomla-custom-elements

1 file changed

+6
-20
lines changed

build/media_source/templates/administrator/atum/scss/vendor/joomla-custom-elements/joomla-tab.scss

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -275,12 +275,8 @@ joomla-tab[view=accordion] {
275275
padding: 0 !important;
276276

277277
@include media-breakpoint-down(lg) {
278-
[dir=ltr] & .respTable {
279-
text-align: right;
280-
}
281-
282-
[dir=rtl] & .respTable {
283-
text-align: left;
278+
.respTable {
279+
text-align: end;
284280
}
285281

286282
.respTable, .respTable thead, .respTable tbody, .respTable tr, .respTable th, .respTable td {
@@ -289,26 +285,16 @@ joomla-tab[view=accordion] {
289285

290286
.respTable thead {
291287
position: absolute;
292-
top: -1111px;
293-
left: -1111px;
288+
inset-block-start: -1111px;
289+
inset-inline-start: -1111px;
294290
}
295291

296-
/* stylelint-disable */
297292
.respTable td::before {
293+
float: inline-start;
294+
padding-inline-end: 2em;
298295
font-weight: $bold-weight;
299296
content: attr(data-label) ":";
300-
301-
[dir=ltr] & {
302-
float: left;
303-
padding: 0 2em 0 0;
304-
}
305-
306-
[dir=rtl] & {
307-
float: right;
308-
padding: 0 0 0 2em;
309-
}
310297
}
311-
/* stylelint-enable */
312298

313299
.respTable td:nth-child(1) {
314300
font-weight: $bold-weight;

0 commit comments

Comments
 (0)