[5.4] Remove pointless boolean expressions (joomla#44885)

* [5.3] Remove pointless boolean expressions
Co-authored-by: Tuan Pham Ngoc <[email protected]>
Co-authored-by: Quy Ton <[email protected]>

Author: 3 people

administrator/components/com_associations/src/Model/AssociationsModel.php

@@ -328,7 +328,7 @@ protected function getListQuery()
         }
 
         // If component item type supports access level, select the access level also.
-        if (\array_key_exists('acl', $support) && $support['acl'] == true && !empty($fields['access'])) {
+        if (\array_key_exists('acl', $support) && $support['acl'] && !empty($fields['access'])) {
             $query->select($db->quoteName($fields['access'], 'access'));
 
             // Join over the access levels.

administrator/components/com_categories/src/Model/CategoriesModel.php

@@ -455,7 +455,7 @@ public function getItems()
     {
         $items = parent::getItems();
 
-        if ($items != false) {
+        if ($items) {
             $extension = $this->getState('filter.extension');
 
             $this->countItems($items, $extension);

administrator/components/com_config/src/Model/ApplicationModel.php

@@ -585,11 +585,11 @@ public function save($data)
         }
 
         // Give a warning if the cache-folder can not be opened
-        if ($data['caching'] > 0 && $data['cache_handler'] == 'file' && @opendir($path) == false) {
+        if ($data['caching'] > 0 && $data['cache_handler'] == 'file' && @opendir($path) === false) {
             $error = true;
 
             // If a custom path is in use, try using the system default instead of disabling cache
-            if ($path !== JPATH_CACHE && @opendir(JPATH_CACHE) != false) {
+            if ($path !== JPATH_CACHE && @opendir(JPATH_CACHE) !== false) {
                 try {
                     Log::add(
                         Text::sprintf('COM_CONFIG_ERROR_CUSTOM_CACHE_PATH_NOTWRITABLE_USING_DEFAULT', $path, JPATH_CACHE),

administrator/components/com_content/src/Model/ArticleModel.php

@@ -708,7 +708,7 @@ public function save($data)
             $check = $input->post->get('jform', [], 'array');
 
             foreach ($data['urls'] as $i => $url) {
-                if ($url != false && ($i == 'urla' || $i == 'urlb' || $i == 'urlc')) {
+                if (trim($url) !== '' && ($i == 'urla' || $i == 'urlb' || $i == 'urlc')) {
                     if (preg_match('~^#[a-zA-Z]{1}[a-zA-Z0-9-_:.]*$~', $check['urls'][$i]) == 1) {
                         $data['urls'][$i] = $check['urls'][$i];
                     } else {

administrator/components/com_finder/src/Service/HTML/Query.php

@@ -41,14 +41,14 @@ public static function explained(IndexerQuery $query)
 
         // Process the required tokens.
         foreach ($query->included as $token) {
-            if ($token->required && (!isset($token->derived) || $token->derived == false)) {
+            if ($token->required && (!isset($token->derived) || !$token->derived)) {
                 $parts[] = '<span class="query-required">' . Text::sprintf('COM_FINDER_QUERY_TOKEN_REQUIRED', $token->term) . '</span>';
             }
         }
 
         // Process the optional tokens.
         foreach ($query->included as $token) {
-            if (!$token->required && (!isset($token->derived) || $token->derived == false)) {
+            if (!$token->required && (!isset($token->derived) || !$token->derived)) {
                 $parts[] = '<span class="query-optional">' . Text::sprintf('COM_FINDER_QUERY_TOKEN_OPTIONAL', $token->term) . '</span>';
             }
         }

administrator/components/com_installer/src/Model/UpdateModel.php

@@ -533,13 +533,6 @@ public function getForm($data = [], $loadData = true)
         Form::addFieldPath(JPATH_COMPONENT . '/models/fields');
         $form = Form::getInstance('com_installer.update', 'update', ['load_data' => $loadData]);
 
-        // Check for an error.
-        if ($form == false) {
-            $this->setError($form->getMessage());
-
-            return false;
-        }
-
         // Check the session for previously entered form data.
         $data = $this->loadFormData();
 

administrator/components/com_menus/src/Field/MenuItemByTypeField.php

@@ -149,7 +149,7 @@ public function setup(\SimpleXMLElement $element, $value, $group = null)
     {
         $result = parent::setup($element, $value, $group);
 
-        if ($result == true) {
+        if ($result) {
             $menuType = (string) $this->element['menu_type'];
 
             if (!$menuType) {

administrator/components/com_menus/src/Model/ItemModel.php

@@ -1146,7 +1146,7 @@ protected function preprocessForm(Form $form, $data, $group = 'content')
             // If an XML file was found in the component, load it first.
             // We need to qualify the full path to avoid collisions with component file names.
 
-            if ($form->loadFile($formFile, true, '/metadata') == false) {
+            if (!$form->loadFile($formFile, true, '/metadata')) {
                 throw new \Exception(Text::_('JERROR_LOADFILE_FAILED'));
             }
 

administrator/components/com_redirect/src/Model/LinkModel.php

@@ -72,7 +72,7 @@ public function getForm($data = [], $loadData = true)
         }
 
         // Modify the form based on access controls.
-        if ($this->canEditState((object) $data) != true) {
+        if (!$this->canEditState((object)$data)) {
             // Disable fields for display.
             $form->setFieldAttribute('published', 'disabled', 'true');
 
@@ -83,7 +83,7 @@ public function getForm($data = [], $loadData = true)
 
         // If in advanced mode then we make sure the new URL field is not compulsory and the header
         // field compulsory in case people select non-3xx redirects
-        if (ComponentHelper::getParams('com_redirect')->get('mode', 0) == true) {
+        if (ComponentHelper::getParams('com_redirect')->get('mode', 0)) {
             $form->setFieldAttribute('new_url', 'required', 'false');
             $form->setFieldAttribute('header', 'required', 'true');
         }

administrator/components/com_redirect/src/Table/LinkTable.php

@@ -74,13 +74,13 @@ public function check()
         }
 
         // Check for valid name if not in advanced mode.
-        if (empty($this->new_url) && ComponentHelper::getParams('com_redirect')->get('mode', 0) == false) {
+        if (empty($this->new_url) && !ComponentHelper::getParams('com_redirect')->get('mode', 0)) {
             $this->setError(Text::_('COM_REDIRECT_ERROR_DESTINATION_URL_REQUIRED'));
 
             return false;
         }
 
-        if (empty($this->new_url) && ComponentHelper::getParams('com_redirect')->get('mode', 0) == true) {
+        if (empty($this->new_url) && ComponentHelper::getParams('com_redirect')->get('mode', 0)) {
             // Else if an empty URL and in redirect mode only throw the same error if the code is a 3xx status code
             if ($this->header < 400 && $this->header >= 300) {
                 $this->setError(Text::_('COM_REDIRECT_ERROR_DESTINATION_URL_REQUIRED'));