[Kernel][#2] IcebergCompatV3 - move IcebergCompatCheck to base class (delta-io#4732)

<!--
Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md
2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
Your PR title ...'.
  3. Be sure to keep the PR description updated to reflect all changes.
  4. Please write your PR title to summarize what this PR proposes.
5. If possible, provide a concise example to reproduce the issue for a
faster review.
6. If applicable, include the corresponding issue number in the PR title
and link it in the body.
-->

#### Which Delta project/connector is this regarding?
<!--
Please add the component selected below to the beginning of the pull
request title
For example: [Spark] Title of my pull request
-->

- [ ] Spark
- [ ] Standalone
- [ ] Flink
- [x] Kernel
- [ ] Other (fill in here)

## Description

<!--
- Describe what this PR changes.
- Describe why we need the change.
 
If this PR resolves an issue be sure to include "Resolves #XXX" to
correctly link and close the issue upon merge.
-->
This PR is refactoring only, move all the IcebergCompatChecks from
`IcebergCompatV2MetadataValidatorAndUpdater.java` to its base class
`IcebergCompatMetadataValidatorAndUpdater.java` so that later newly
added `IcebergCompatV3MetadataValidatorAndUpdater.java` can use them.

## How was this patch tested?

<!--
If tests were added, say they were added here. Please make sure to test
the changes thoroughly including negative and positive cases if
possible.
If the changes were tested in any way other than unit tests, please
clarify how you tested step by step (ideally copy and paste-able, so
that other reviewers can test and check, and descendants can verify in
the future).
If the changes were not tested, please explain why.
-->
Existing unit tests since it is only doing refactoring.
## Does this PR introduce _any_ user-facing changes?

<!--
If yes, please clarify the previous behavior and the change this PR
proposes - provide the console output, description and/or an example to
show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change
compared to the released Delta Lake versions or within the unreleased
branches such as master.
If no, write 'No'.
-->

Author: KaiqiJinWow

kernel/kernel-api/src/main/java/io/delta/kernel/internal/icebergcompat/IcebergCompatMetadataValidatorAndUpdater.java

@@ -15,17 +15,27 @@
  */
 package io.delta.kernel.internal.icebergcompat;
 
+import static io.delta.kernel.internal.tablefeatures.TableFeatures.*;
+import static io.delta.kernel.internal.util.Preconditions.checkArgument;
 import static java.util.Collections.singletonMap;
+import static java.util.stream.Collectors.toList;
 
 import io.delta.kernel.exceptions.KernelException;
 import io.delta.kernel.internal.DeltaErrors;
 import io.delta.kernel.internal.TableConfig;
 import io.delta.kernel.internal.actions.Metadata;
 import io.delta.kernel.internal.actions.Protocol;
 import io.delta.kernel.internal.tablefeatures.TableFeature;
-import java.util.List;
-import java.util.Optional;
+import io.delta.kernel.internal.types.TypeWideningChecker;
+import io.delta.kernel.internal.util.ColumnMapping;
+import io.delta.kernel.internal.util.SchemaIterable;
+import io.delta.kernel.internal.util.SchemaUtils;
+import io.delta.kernel.internal.util.Tuple2;
+import io.delta.kernel.types.*;
+import java.util.*;
 import java.util.function.Predicate;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 /**
  * Contains interfaces and common utility classes for defining the iceberg conversion compatibility
@@ -53,19 +63,25 @@ public abstract class IcebergCompatMetadataValidatorAndUpdater {
   /////////////////////////////////////////////////////////////////////////////////
   /** Defines the input context for the metadata validator and updater. */
   public static class IcebergCompatInputContext {
+    final String compatFeatureName;
     final boolean isCreatingNewTable;
     final Metadata newMetadata;
     final Protocol newProtocol;
 
     public IcebergCompatInputContext(
-        boolean isCreatingNewTable, Metadata newMetadata, Protocol newProtocol) {
+        String compatFeatureName,
+        boolean isCreatingNewTable,
+        Metadata newMetadata,
+        Protocol newProtocol) {
+      this.compatFeatureName = compatFeatureName;
       this.isCreatingNewTable = isCreatingNewTable;
       this.newMetadata = newMetadata;
       this.newProtocol = newProtocol;
     }
 
     public IcebergCompatInputContext withUpdatedMetadata(Metadata newMetadata) {
-      return new IcebergCompatInputContext(isCreatingNewTable, newMetadata, newProtocol);
+      return new IcebergCompatInputContext(
+          compatFeatureName, isCreatingNewTable, newMetadata, newProtocol);
     }
   }
 
@@ -79,7 +95,7 @@ interface PostMetadataProcessor {
    * is not set, we will set it to a default value. It will also update the metadata to make it
    * compatible with Iceberg compat version targeted.
    */
-  static class IcebergCompatRequiredTablePropertyEnforcer<T> {
+  protected static class IcebergCompatRequiredTablePropertyEnforcer<T> {
     public final TableConfig<T> property;
     public final Predicate<T> validator;
     public final String autoSetValue;
@@ -147,14 +163,169 @@ Optional<Metadata> validateAndUpdate(
     }
   }
 
+  /////////////////////////////////////////////////////////////////////////////////
+  /// Implementation of {@link IcebergCompatRequiredTablePropertyEnforcer}      ///
+  /////////////////////////////////////////////////////////////////////////////////
+  protected static final IcebergCompatRequiredTablePropertyEnforcer COLUMN_MAPPING_REQUIREMENT =
+      new IcebergCompatRequiredTablePropertyEnforcer<>(
+          TableConfig.COLUMN_MAPPING_MODE,
+          (value) ->
+              ColumnMapping.ColumnMappingMode.NAME == value
+                  || ColumnMapping.ColumnMappingMode.ID == value,
+          ColumnMapping.ColumnMappingMode.NAME.value);
+
   /**
    * Defines checks for compatibility with the targeted iceberg features (icebergCompatV1 or
    * icebergCompatV2 etc.)
    */
-  interface IcebergCompatCheck {
+  protected interface IcebergCompatCheck {
     void check(IcebergCompatInputContext inputContext);
   }
 
+  ///////////////////////////////////////////////////////////
+  /// Implementation of {@link IcebergCompatCheck}        ///
+  ///////////////////////////////////////////////////////////
+  protected static IcebergCompatCheck disallowOtherCompatVersions(List<String> incompatibleProps) {
+    return (inputContext) -> {
+      for (String prop : incompatibleProps) {
+        if (Boolean.parseBoolean(
+            inputContext.newMetadata.getConfiguration().getOrDefault(prop, "false"))) {
+          throw DeltaErrors.icebergCompatIncompatibleVersionEnabled(
+              inputContext.compatFeatureName, prop);
+        }
+      }
+    };
+  }
+
+  protected static final IcebergCompatCheck CHECK_ONLY_ICEBERG_COMPAT_V2_ENABLED =
+      disallowOtherCompatVersions(
+          Arrays.asList("delta.enableIcebergCompatV1", "delta.enableIcebergCompatV3"));
+
+  protected static final IcebergCompatCheck CHECK_ONLY_ICEBERG_COMPAT_V3_ENABLED =
+      disallowOtherCompatVersions(
+          Arrays.asList("delta.enableIcebergCompatV1", "delta.enableIcebergCompatV2"));
+
+  protected static IcebergCompatCheck hasOnlySupportedTypes(
+      Set<Class<? extends DataType>> supportedTypes) {
+    return (inputContext) -> {
+      List<Tuple2<List<String>, StructField>> matches =
+          SchemaUtils.filterRecursively(
+              inputContext.newMetadata.getSchema(),
+              /* recurseIntoMapAndArrayTypes= */ true,
+              /* stopOnFirstMatch = */ false,
+              field -> {
+                DataType dataType = field.getDataType();
+                for (Class<? extends DataType> clazz : supportedTypes) {
+                  if (clazz.isInstance(dataType)) return false;
+                }
+                return true;
+              });
+
+      if (!matches.isEmpty()) {
+        throw DeltaErrors.icebergCompatUnsupportedTypeColumns(
+            inputContext.compatFeatureName,
+            matches.stream().map(tuple -> tuple._2.getDataType()).collect(toList()));
+      }
+    };
+  }
+
+  private static final Set<Class<? extends DataType>> V2_SUPPORTED_TYPES =
+      new HashSet<>(
+          Arrays.asList(
+              ByteType.class,
+              ShortType.class,
+              IntegerType.class,
+              LongType.class,
+              FloatType.class,
+              DoubleType.class,
+              DecimalType.class,
+              StringType.class,
+              BinaryType.class,
+              BooleanType.class,
+              DateType.class,
+              TimestampType.class,
+              TimestampNTZType.class,
+              ArrayType.class,
+              MapType.class,
+              StructType.class));
+
+  protected static final IcebergCompatCheck V2_CHECK_HAS_SUPPORTED_TYPES =
+      hasOnlySupportedTypes(V2_SUPPORTED_TYPES);
+
+  protected static final IcebergCompatCheck V3_CHECK_HAS_SUPPORTED_TYPES =
+      hasOnlySupportedTypes(
+          Stream.concat(V2_SUPPORTED_TYPES.stream(), Stream.of(VariantType.class))
+              .collect(Collectors.toSet()));
+
+  // These are the common supported partition types for both Iceberg compat V2 and V3
+  protected static final IcebergCompatCheck CHECK_HAS_ALLOWED_PARTITION_TYPES =
+      (inputContext) ->
+          inputContext
+              .newMetadata
+              .getPartitionColNames()
+              .forEach(
+                  partitionCol -> {
+                    int partitionFieldIndex =
+                        inputContext.newMetadata.getSchema().indexOf(partitionCol);
+                    checkArgument(
+                        partitionFieldIndex != -1,
+                        "Partition column %s not found in the schema",
+                        partitionCol);
+                    DataType dataType =
+                        inputContext.newMetadata.getSchema().at(partitionFieldIndex).getDataType();
+                    boolean validType =
+                        dataType instanceof ByteType
+                            || dataType instanceof ShortType
+                            || dataType instanceof IntegerType
+                            || dataType instanceof LongType
+                            || dataType instanceof FloatType
+                            || dataType instanceof DoubleType
+                            || dataType instanceof DecimalType
+                            || dataType instanceof StringType
+                            || dataType instanceof BinaryType
+                            || dataType instanceof BooleanType
+                            || dataType instanceof DateType
+                            || dataType instanceof TimestampType
+                            || dataType instanceof TimestampNTZType;
+                    if (!validType) {
+                      throw DeltaErrors.icebergCompatUnsupportedTypePartitionColumn(
+                          inputContext.compatFeatureName, dataType);
+                    }
+                  });
+
+  protected static final IcebergCompatCheck CHECK_HAS_NO_PARTITION_EVOLUTION =
+      (inputContext) -> {
+        // TODO: Kernel doesn't support replace table yet. When it is supported, extend
+        // this to allow checking the partition columns aren't changed
+      };
+
+  protected static final IcebergCompatCheck CHECK_HAS_NO_DELETION_VECTORS =
+      (inputContext) -> {
+        if (inputContext.newProtocol.supportsFeature(DELETION_VECTORS_RW_FEATURE)) {
+          throw DeltaErrors.icebergCompatIncompatibleTableFeatures(
+              inputContext.compatFeatureName, Collections.singleton(DELETION_VECTORS_RW_FEATURE));
+        }
+      };
+
+  protected static final IcebergCompatCheck CHECK_HAS_SUPPORTED_TYPE_WIDENING =
+      (inputContext) -> {
+        Protocol protocol = inputContext.newProtocol;
+        if (!protocol.supportsFeature(TYPE_WIDENING_RW_FEATURE)
+            && !protocol.supportsFeature(TYPE_WIDENING_RW_PREVIEW_FEATURE)) {
+          return;
+        }
+        for (SchemaIterable.SchemaElement element :
+            new SchemaIterable(inputContext.newMetadata.getSchema())) {
+          for (TypeChange typeChange : element.getField().getTypeChanges()) {
+            if (!TypeWideningChecker.isIcebergV2Compatible(
+                typeChange.getFrom(), typeChange.getTo())) {
+              throw DeltaErrors.icebergCompatUnsupportedTypeWidening(
+                  inputContext.compatFeatureName, typeChange);
+            }
+          }
+        }
+      };
+
   /////////////////////////////////////////////////////////////////////////////////
   /// Implementation of {@link IcebergCompatMetadataValidatorAndUpdater}        ///
   /////////////////////////////////////////////////////////////////////////////////