[Kernel][Test]Make DomainMetadataSuite work with post commit hook and do some clean up (delta-io#4336)

<!--
Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md
2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
Your PR title ...'.
  3. Be sure to keep the PR description updated to reflect all changes.
  4. Please write your PR title to summarize what this PR proposes.
5. If possible, provide a concise example to reproduce the issue for a
faster review.
6. If applicable, include the corresponding issue number in the PR title
and link it in the body.
-->

#### Which Delta project/connector is this regarding?
<!--
Please add the component selected below to the beginning of the pull
request title
For example: [Spark] Title of my pull request
-->

- [ ] Spark
- [ ] Standalone
- [ ] Flink
- [X] Kernel
- [ ] Other (fill in here)

## Description

<!--
- Describe what this PR changes.
- Describe why we need the change.
 
If this PR resolves an issue be sure to include "Resolves #XXX" to
correctly link and close the issue upon merge.
-->
This PR makes no functional change, it makes DomainMetadataSuite work
with post commit hook and do some clean up
## How was this patch tested?

<!--
If tests were added, say they were added here. Please make sure to test
the changes thoroughly including negative and positive cases if
possible.
If the changes were tested in any way other than unit tests, please
clarify how you tested step by step (ideally copy and paste-able, so
that other reviewers can test and check, and descendants can verify in
the future).
If the changes were not tested, please explain why.
-->
Existing test
## Does this PR introduce _any_ user-facing changes?

<!--
If yes, please clarify the previous behavior and the change this PR
proposes - provide the console output, description and/or an example to
show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change
compared to the released Delta Lake versions or within the unreleased
branches such as master.
If no, write 'No'.
-->
No

Author: huan233usc

kernel/kernel-defaults/src/test/scala/io/delta/kernel/defaults/DeltaTableWriteSuiteBase.scala

@@ -300,7 +300,8 @@ trait DeltaTableWriteSuiteBase extends AnyFunSuite with TestUtils {
       schema: StructType = null,
       partCols: Seq[String] = null,
       tableProperties: Map[String, String] = null,
-      clock: Clock = () => System.currentTimeMillis): Transaction = {
+      clock: Clock = () => System.currentTimeMillis,
+      withDomainMetadataSupported: Boolean = false): Transaction = {
 
     var txnBuilder = createWriteTxnBuilder(
       TableImpl.forPath(engine, tablePath, clock))
@@ -314,6 +315,10 @@ trait DeltaTableWriteSuiteBase extends AnyFunSuite with TestUtils {
       txnBuilder = txnBuilder.withTableProperties(engine, tableProperties.asJava)
     }
 
+    if (withDomainMetadataSupported) {
+      txnBuilder = txnBuilder.withDomainMetadataSupported()
+    }
+
     txnBuilder.build(engine)
   }
 

kernel/kernel-defaults/src/test/scala/io/delta/kernel/defaults/DomainMetadataSuite.scala

@@ -15,22 +15,20 @@
  */
 package io.delta.kernel.defaults
 
-import java.util.Collections
-
 import scala.collection.JavaConverters._
 import scala.collection.immutable.Seq
 
 import io.delta.kernel._
+import io.delta.kernel.data.Row
 import io.delta.kernel.defaults.internal.parquet.ParquetSuiteBase
 import io.delta.kernel.engine.Engine
 import io.delta.kernel.exceptions._
 import io.delta.kernel.expressions.Literal
-import io.delta.kernel.internal.{SnapshotImpl, TableConfig, TableImpl, TransactionBuilderImpl, TransactionImpl}
-import io.delta.kernel.internal.actions.{DomainMetadata, Protocol, SingleAction}
+import io.delta.kernel.internal.{SnapshotImpl, TableImpl, TransactionImpl}
+import io.delta.kernel.internal.actions.DomainMetadata
 import io.delta.kernel.internal.rowtracking.RowTrackingMetadataDomain
-import io.delta.kernel.internal.tablefeatures.TableFeatures
-import io.delta.kernel.internal.util.Utils.toCloseableIterator
-import io.delta.kernel.utils.CloseableIterable.{emptyIterable, inMemoryIterable}
+import io.delta.kernel.utils.CloseableIterable
+import io.delta.kernel.utils.CloseableIterable.emptyIterable
 
 import org.apache.spark.sql.delta.DeltaLog
 import org.apache.spark.sql.delta.RowId.{RowTrackingMetadataDomain => SparkRowTrackingMetadataDomain}
@@ -104,34 +102,25 @@ class DomainMetadataSuite extends DeltaTableWriteSuiteBase with ParquetSuiteBase
       useInternalApi: Boolean = false): Unit = {
     // Create the transaction with domain metadata and commit
     val txn = createTxnWithDomainMetadatas(engine, tablePath, domainMetadatas, useInternalApi)
-    txn.commit(engine, emptyIterable())
+    commitTransaction(txn, engine, emptyIterable())
 
     // Verify the final state includes the expected domain metadata
     val table = Table.forPath(engine, tablePath)
     assertDomainMetadata(table, engine, expectedValue)
   }
 
-  // TODO we probably don't always need this since domain metadata is now automatically enabled
-  private def setDomainMetadataSupport(engine: Engine, tablePath: String): Unit = {
-    val protocol = new Protocol(
-      3, // minReaderVersion
-      7, // minWriterVersion
-      Collections.emptySet(), // readerFeatures
-      Set("domainMetadata").asJava // writerFeatures
-    )
-
-    val protocolAction = SingleAction.createProtocolSingleAction(protocol.toRow)
-    val txn = createTxn(engine, tablePath, isNewTable = false, testSchema, Seq.empty)
-    txn.commit(engine, inMemoryIterable(toCloseableIterator(Seq(protocolAction).asJava.iterator())))
-  }
-
   private def createTableWithDomainMetadataSupported(engine: Engine, tablePath: String): Unit = {
     // Create an empty table
-    createTxn(engine, tablePath, isNewTable = true, testSchema, Seq.empty)
-      .commit(engine, emptyIterable())
-
-    // Set writer version and writer feature to support domain metadata
-    setDomainMetadataSupport(engine, tablePath)
+    commitTransaction(
+      createTxn(
+        engine,
+        tablePath,
+        isNewTable = true,
+        testSchema,
+        Seq.empty,
+        withDomainMetadataSupported = true),
+      engine,
+      emptyIterable())
   }
 
   private def validateDomainMetadataConflictResolution(
@@ -162,22 +151,22 @@ class DomainMetadataSuite extends DeltaTableWriteSuiteBase with ParquetSuiteBase
     val txn1 = createTxnWithDomainMetadatas(engine, tablePath, currentTxn1DomainMetadatas)
 
     val txn2 = createTxnWithDomainMetadatas(engine, tablePath, winningTxn2DomainMetadatas)
-    txn2.commit(engine, emptyIterable())
+    commitTransaction(txn2, engine, emptyIterable())
 
     val txn3 = createTxnWithDomainMetadatas(engine, tablePath, winningTxn3DomainMetadatas)
-    txn3.commit(engine, emptyIterable())
+    commitTransaction(txn3, engine, emptyIterable())
 
     if (expectedConflict) {
       // We expect the commit of txn1 to fail because of the conflicting DM actions
       val ex = intercept[KernelException] {
-        txn1.commit(engine, emptyIterable())
+        commitTransaction(txn1, engine, emptyIterable())
       }
       assert(
         ex.getMessage.contains(
           "A concurrent writer added a domainMetadata action for the same domain"))
     } else {
       // We expect the commit of txn1 to succeed
-      txn1.commit(engine, emptyIterable())
+      commitTransaction(txn1, engine, emptyIterable())
       // Verify the final state includes merged domain metadata
       val expectedMetadata =
         (winningTxn2DomainMetadatas ++ winningTxn3DomainMetadatas ++ currentTxn1DomainMetadatas)
@@ -187,13 +176,26 @@ class DomainMetadataSuite extends DeltaTableWriteSuiteBase with ParquetSuiteBase
     }
   }
 
+  override def commitTransaction(
+      txn: Transaction,
+      engine: Engine,
+      dataActions: CloseableIterable[Row]): TransactionCommitResult = {
+    val result = txn.commit(engine, dataActions)
+    result.getPostCommitHooks
+      .stream()
+      .forEach(hook => hook.threadSafeInvoke(engine))
+    result
+  }
+
   test("create table w/o domain metadata") {
     withTempDirAndEngine { (tablePath, engine) =>
       val table = Table.forPath(engine, tablePath)
 
       // Create an empty table
-      createTxn(engine, tablePath, isNewTable = true, testSchema, Seq.empty)
-        .commit(engine, emptyIterable())
+      commitTransaction(
+        createTxn(engine, tablePath, isNewTable = true, testSchema, Seq.empty),
+        engine,
+        emptyIterable())
 
       // Verify that the table doesn't have any domain metadata
       assertDomainMetadata(table, engine, Map.empty)
@@ -204,26 +206,30 @@ class DomainMetadataSuite extends DeltaTableWriteSuiteBase with ParquetSuiteBase
     withTempDirAndEngine { (tablePath, engine) =>
       // Create an empty table
       // Its minWriterVersion is 2 and doesn't have 'domainMetadata' in its writerFeatures
-      createTxn(engine, tablePath, isNewTable = true, testSchema, Seq.empty)
-        .commit(engine, emptyIterable())
+      commitTransaction(
+        createTxn(
+          engine,
+          tablePath,
+          isNewTable = true,
+          testSchema,
+          Seq.empty),
+        engine,
+        emptyIterable())
 
       val dm1 = new DomainMetadata("domain1", "", false)
       // We use the internal API because our public API will automatically upgrade the protocol
       val txn1 = createTxnWithDomainMetadatas(engine, tablePath, List(dm1), useInternalApi = true)
 
       // We expect the commit to fail because the table doesn't support domain metadata
       val e = intercept[KernelException] {
-        txn1.commit(engine, emptyIterable())
+        commitTransaction(txn1, engine, emptyIterable())
       }
       assert(
         e.getMessage
           .contains(
             "Cannot commit DomainMetadata action(s) because the feature 'domainMetadata' "
               + "is not supported on this table."))
 
-      // Set writer version and writer feature to support domain metadata
-      setDomainMetadataSupport(engine, tablePath)
-
       // Commit domain metadata again and expect success
       commitDomainMetadataAndVerify(
         engine,
@@ -642,7 +648,7 @@ class DomainMetadataSuite extends DeltaTableWriteSuiteBase with ParquetSuiteBase
   test("updating domain metadata fails after transaction committed") {
     withTempDirAndEngine { (tablePath, engine) =>
       val txn = createTxn(engine, tablePath, isNewTable = true, testSchema, Seq.empty)
-      txn.commit(engine, emptyIterable())
+      commitTransaction(txn, engine, emptyIterable())
 
       intercept[IllegalStateException] {
         txn.addDomainMetadata("domain", "config")
@@ -698,7 +704,7 @@ class DomainMetadataSuite extends DeltaTableWriteSuiteBase with ParquetSuiteBase
         val txn = createWriteTxnBuilder(Table.forPath(defaultEngine, tablePath))
           .build(defaultEngine)
         txn.removeDomainMetadata("foo")
-        txn.commit(defaultEngine, emptyIterable());
+        commitTransaction(txn, defaultEngine, emptyIterable());
       }
     }
 
@@ -791,8 +797,14 @@ class DomainMetadataSuite extends DeltaTableWriteSuiteBase with ParquetSuiteBase
   test("removing a domain on a table without DomainMetadata support") {
     withTempDirAndEngine { (tablePath, engine) =>
       // Create table with legacy protocol
-      createTxn(tablePath = tablePath, isNewTable = true, schema = testSchema, partCols = Seq())
-        .commit(engine, emptyIterable())
+      commitTransaction(
+        createTxn(
+          tablePath = tablePath,
+          isNewTable = true,
+          schema = testSchema,
+          partCols = Seq()),
+        engine,
+        emptyIterable())
       intercept[IllegalStateException] {
         val txn = createWriteTxnBuilder(Table.forPath(engine, tablePath))
           .build(engine)