Merge pull request #26 from richardeschloss/development

Development

Author: richardeschloss

.gitlab-ci.yml

@@ -22,6 +22,9 @@ test_unit:
     - npm install
     - npm run test:unit:cov
   coverage: '/All files[^|]*\|[^|]*\s+([\d\.]+)/'
+  artifacts:
+    paths:
+      - coverage
 
 test_e2e:
   script:

CHANGELOG.md

@@ -2,6 +2,12 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## [1.0.5] - 2019-12-06
+
+### Added
+
+- Check for missing vuex options; i.e., missing mutations or actions
+
 ## [1.0.4] - 2019-11-19
 
 ### Changed

io/plugin.js

@@ -63,7 +63,7 @@ function nuxtSocket(ioOpts) {
     }
     Object.entries(storeFns).forEach(([group, fn]) => {
       const groupOpts = vuexOpts[group]
-      if (groupOpts.length && groupOpts.length > 0) {
+      if (groupOpts && groupOpts.constructor.name === 'Array' && groupOpts.length > 0) {
         groupOpts.forEach((item) => {
           let evt = null
           let mappedItem = null

package.json

@@ -1,6 +1,6 @@
 {
   "name": "nuxt-socket-io",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "description": "Socket.io module for Nuxt. Just plug it in and GO",
   "author": "Richard Schloss",
   "main": "io/module.js",

test/specs/Plugin.spec.js

@@ -129,6 +129,38 @@ test('Socket plugin (malformed vuex options)', async (t) => {
   await loadPlugin(t)
 })
 
+test('Socket plugin (vuex options missing mutations)', async (t) => {
+  const testCfg = {
+    sockets: [
+      {
+        default: true,
+        url: 'http://localhost:3000',
+        vuex: {
+          actions: []
+        }
+      }
+    ]
+  }
+  pOptions.set(testCfg)
+  await loadPlugin(t)
+})
+
+test('Socket plugin (vuex options missing actions)', async (t) => {
+  const testCfg = {
+    sockets: [
+      {
+        default: true,
+        url: 'http://localhost:3000',
+        vuex: {
+          mutations: []
+        }
+      }
+    ]
+  }
+  pOptions.set(testCfg)
+  await loadPlugin(t)
+})
+
 test('Socket plugin (vuex opts as strings)', async (t) => {
   const testCfg = {
     sockets: [