refactor(IpfsClient): remove synchronous versions of DoCommand and Download

If you really need a synchronous command use .Result or .Wait

Author: richardschneider

src/IpfsClient.cs

@@ -458,77 +458,7 @@ public async Task<String> UploadAsync(string command, byte[] data, params string
             }
         }
 
-        /// <summary>
-        ///  Perform an <see href="https://ipfs.io/docs/api/">IPFS API command</see> returning a string.
-        /// </summary>
-        /// <param name="command">
-        ///   The <see href="https://ipfs.io/docs/api/">IPFS API command</see>, such as
-        ///   <see href="https://ipfs.io/docs/api/#apiv0filels">"file/ls"</see>.
-        /// </param>
-        /// <param name="arg">
-        ///   The optional argument to the command.
-        /// </param>
-        /// <param name="options">
-        ///   The optional flags to the command.
-        /// </param>
-        /// <returns>
-        ///   A string representation of the command's result.
-        /// </returns>
-        public string DoCommand(string command, string arg = null, params string[] options)
-        {
-            return DoCommandAsync(command, arg, options).Result;
-        }
-
-        /// <summary>
-        ///   Perform an <see href="https://ipfs.io/docs/api/">IPFS API command</see> returning 
-        ///   a specific <see cref="Type"/>.
-        /// </summary>
-        /// <typeparam name="T">
-        ///   The <see cref="Type"/> of object to return.
-        /// </typeparam>
-        /// <param name="command">
-        ///   The <see href="https://ipfs.io/docs/api/">IPFS API command</see>, such as
-        ///   <see href="https://ipfs.io/docs/api/#apiv0filels">"file/ls"</see>.
-        /// </param>
-        /// <param name="arg">
-        ///   The optional argument to the command.
-        /// </param>
-        /// <param name="options">
-        ///   The optional flags to the command.
-        /// </param>
-        /// <returns>
-        ///   A <typeparamref name="T"/>.
-        /// </returns>
-        /// <remarks>
-        ///   The command's response is converted to <typeparamref name="T"/> using
-        ///   <c>JsonConvert</c>.
-        /// </remarks>
-        public T DoCommand<T>(string command, string arg = null, params string[] options)
-        {
-            return DoCommandAsync<T>(command, arg, options).Result;
-        }
 
-        /// <summary>
-        ///  Perform an <see href="https://ipfs.io/docs/api/">IPFS API command</see> returning a
-        ///  <see cref="Stream"/>.
-        /// </summary>
-        /// <param name="command">
-        ///   The <see href="https://ipfs.io/docs/api/">IPFS API command</see>, such as
-        ///   <see href="https://ipfs.io/docs/api/#apiv0filels">"file/ls"</see>.
-        /// </param>
-        /// <param name="arg">
-        ///   The optional argument to the command.
-        /// </param>
-        /// <param name="options">
-        ///   The optional flags to the command.
-        /// </param>
-        /// <returns>
-        ///   A <see cref="Stream"/> containing the command's result.
-        /// </returns>
-        public Stream Download(string command, string arg = null, params string[] options)
-        {
-            return DownloadAsync(command, arg, options).Result;
-        }
 
         /// <summary>
         /// 

src/MerkleNode.cs

@@ -169,12 +169,7 @@ public byte[] DataBytes
         {
             get
             {
-                using (var stream = DataStream)
-                using (var data = new MemoryStream())
-                {
-                    stream.CopyTo(data);
-                    return data.ToArray();
-                }
+                return IpfsClient.Block.GetAsync(Hash).Result.DataBytes;
             }
         }
 
@@ -183,7 +178,7 @@ public Stream DataStream
         {
             get
             {
-                return IpfsClient.Download("block/get", Hash);
+                return IpfsClient.Block.GetAsync(Hash).Result.DataStream;
             }
         }
 

src/TrustedPeerCollection.cs

@@ -41,7 +41,7 @@ public void Add(MultiAddress peer)
             if (peer == null)
                 throw new ArgumentNullException();
 
-            ipfs.DoCommand("bootstrap/add", peer.ToString());
+            ipfs.DoCommandAsync("bootstrap/add", peer.ToString()).Wait();
             peers = null;
         }
 
@@ -53,7 +53,7 @@ public void Add(MultiAddress peer)
         /// </remarks>
         public void AddDefaultNodes()
         {
-            ipfs.DoCommand("bootstrap/add", null, "default=true");
+            ipfs.DoCommandAsync("bootstrap/add", null, "default=true").Wait();
             peers = null;
         }
 
@@ -65,7 +65,7 @@ public void AddDefaultNodes()
         /// </remarks>
         public void Clear()
         {
-            ipfs.DoCommand("bootstrap/rm", null, "all=true");
+            ipfs.DoCommandAsync("bootstrap/rm", null, "all=true").Wait();
             peers = null;
         }
 
@@ -111,7 +111,7 @@ public bool Remove(MultiAddress peer)
             if (peer == null)
                 throw new ArgumentNullException();
 
-            ipfs.DoCommand("bootstrap/rm", peer.ToString());
+            ipfs.DoCommandAsync("bootstrap/rm", peer.ToString()).Wait();
             peers = null;
             return true;
         }
@@ -132,7 +132,7 @@ IEnumerator IEnumerable.GetEnumerator()
 
         void Fetch()
         {
-            peers = ipfs.DoCommand<BootstrapListResponse>("bootstrap/list").Peers;
+            peers = ipfs.DoCommandAsync<BootstrapListResponse>("bootstrap/list").Result.Peers;
         }
     }
 }