-
-
Notifications
You must be signed in to change notification settings - Fork 75
Open
Description
Continuing from a message raising it in discord by BenjiKenobi.
I think there might be a bug in the markdown rendering code for text in tables. It appears to split text in the table cells while there's still enough space to widen the table.
I think the impact of this bus is pretty low, but it would be frustrating to format a table to not wrap any text if the actual limit before it starts wrapping is unknown.
In the original example where it's spotted,
I have also created some simpler text that displays how text wrapping seems to behave in various situations.
The pure markdown text is:
## A table that wraps words long before it reaches the end of the page
This is a problem, because it indicates that something's gone wrong with text wrapping.
| one | two | three | four | five | six | seven | eight | nine | ten |
|-|-|-|-|-|-|-|-|-|-|
| some text | some more text | ccc | ddd | eee/eee | fff | ggg | hhh | iii | jjj |
## A table that doesn't wrap words, and goes off the end
This is a problem, but there's no universally-correct solution. I think it's justifiable to leave this as-is and players should make the table narrower or lower their font size.
| one | two | three | four | five | six | seven | eight | nine | ten |
|-|-|-|-|-|-|-|-|-|-|
| some text | some_more_text | some_more | done_more | out_of_space | fff | ggg | hhh | iii | jjj |
## A table as wide as it can be before going off the end
This is correct. I'm mostly including this for comparison of where I think the end of the page is.
| one | two | three | four | five | six | seven | eight | nine | ten |
|-|-|-|-|-|-|-|-|-|-|
| some text | some_more_text | some_more | done_more | out_of | fff | ggg | hhh | iii | jjjjjjjjj |
## Some ordinary text that wraps correctly
This is correct. I'm including ordinary text to show that text wrapping normally uses as much of the page width as makes sense (there's not enough space at the end to fit "american", so it wraps to the next line).
lorem ipsum dolor sit amet. foo bar baz. inky pinky moe and clyde. The Simpsons is an animated cartoon about an american family.
## A string of text long enough to go off the end
This is a very long line without any indication of where the line should break. Breaking the line up might confuse readers into thinking there's an actual separator in this sequence of numbers, so leaving as-is is justifiable.
012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
and it's displayed in gcs as:
I've also attached a gcs file below. Because github doesn't allow all file extensions, I've renamed it to a .json.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels