subprocess best practice

richstokes · richstokes · commit 2d7b4d7db2e0 · 2025-06-21T14:08:51.000-07:00
diff --git a/dlna.py b/dlna.py
@@ -1917,6 +1917,7 @@ def _get_media_duration(self, file_path, mime_type):
                         capture_output=True,
                         text=True,
                         timeout=10,
+                        check=False,
                     )
 
                     if result.returncode == 0 and result.stdout.strip():
@@ -1937,6 +1938,7 @@ def _get_media_duration(self, file_path, mime_type):
                         capture_output=True,
                         text=True,
                         timeout=10,
+                        check=False,
                     )
 
                     if result.returncode == 0 and result.stdout.strip():

Original file line number	Diff line number	Diff line change
`@@ -1917,6 +1917,7 @@ def _get_media_duration(self, file_path, mime_type):`
`1917`	`1917`	`capture_output=True,`
`1918`	`1918`	`text=True,`
`1919`	`1919`	`timeout=10,`
	`1920`	`+ check=False,`
`1920`	`1921`	`)`
`1921`	`1922`
`1922`	`1923`	`if result.returncode == 0 and result.stdout.strip():`
`@@ -1937,6 +1938,7 @@ def _get_media_duration(self, file_path, mime_type):`
`1937`	`1938`	`capture_output=True,`
`1938`	`1939`	`text=True,`
`1939`	`1940`	`timeout=10,`
	`1941`	`+ check=False,`
`1940`	`1942`	`)`
`1941`	`1943`
`1942`	`1944`	`if result.returncode == 0 and result.stdout.strip():`