iop: improve code quality (fix llvm warnings)

Author: rickgaiser

iop/arcade/acata/src/acata-entry.c

@@ -34,7 +34,7 @@ int acAtaEntry(int argc, char **argv)
 	{
 		return ret;
 	}
-	if ( !RegisterLibraryEntries(&_exp_acata) == 0 )
+	if ( RegisterLibraryEntries(&_exp_acata) != 0 )
 		return -16;
 	return 0;
 }

iop/cdvd/cdvdman/include/cdvdman.h

@@ -64,7 +64,7 @@ typedef struct cdvdman_dma3_parameter_
 typedef struct cdvdman_internal_struct_
 {
 	char m_cdvdman_command;
-	char m_last_error;
+	unsigned char m_last_error;
 	char m_unused_002;
 	char m_ncmd_intr_count;
 	int m_wait_flag;

iop/dev9/atad/src/ps2atad.c

@@ -1030,7 +1030,7 @@ int ata_device_sector_io64(int device, void *buf, u64 lba, u32 nsectors, int dir
 
         if (atad_devinfo[device].lba48 && (ata_dvrp_workaround ? (lba >= atad_devinfo[device].total_sectors) : 1)) {
             /* Setup for 48-bit LBA.  */
-            len = (nsectors > 65536) ? 65536 : nsectors;
+            len = (u16)((nsectors > 65536) ? 65536 : nsectors); /* 0 means 65536 in LBA48 */
 
             /* Combine bits 24-31 and bits 0-7 of lba into sector.  */
             sector = ((lba >> 16) & 0xff00) | (lba & 0xff);

iop/fs/filexio/src/fileXio_iop.c

@@ -386,7 +386,7 @@ static int fileXio_GetDir_RPC(const char* pathname, struct fileXioDirEntry dirEn
 		}
 		// wait for any previous DMA to complete
 	      // before over-writing localDirEntry
-	      while(sceSifDmaStat(dmaID)>=0);
+	      while(sceSifDmaStat(dmaID)>=0) {}
             DirEntryCopy(&localDirEntry, &dirbuf);
 	      // DMA localDirEntry to the address specified by dirEntry[matched_entries]
 	      // setup the dma struct

iop/fs/http/src/ps2http.c

@@ -140,7 +140,7 @@ int readLine( int socket, char * buffer, int size )
 
 		if ( rc <= 0 ) return rc;
 
-		if ( (*ptr == '\n') ) break;
+		if (*ptr == '\n') break;
 
 		// increment after check for cr.  Don't want to count the cr.
 		count++;

iop/sound/libsnd2/src/ssclose.c

@@ -25,7 +25,7 @@ static void _SsClose(s16 seq_sep_no)
 
 		score_struct = &_ss_score[sep_no][seq_no];
 		score_struct->m_flags = 0;
-		score_struct->m_next_sep = 255;
+		score_struct->m_next_sep = -1;
 		score_struct->m_next_seq = 0;
 		score_struct->m_unk48 = 0;
 		score_struct->m_unk4A = 0;

iop/sound/libsnd2/src/sstable.c

@@ -38,7 +38,7 @@ void SsSetTableSize(char *table, s16 s_max, s16 t_max)
 
 			score_struct = &_ss_score[i][j];
 			score_struct->m_flags = 0;
-			score_struct->m_next_sep = 255;
+			score_struct->m_next_sep = -1;
 			score_struct->m_next_seq = 0;
 			score_struct->m_unk48 = 0;
 			score_struct->m_unk4A = 0;