Skip to content

Commit 20e1afb

Browse files
committed
add new message types from kernel manager:
message_status for 'Kernel is ready' and the like message_error for error messages/backtraces from execution
1 parent 67460a2 commit 20e1afb

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

frontend/src/components/Chat.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ function Message(props: {
3939
</div>
4040
)}
4141

42-
{props.type == "message" &&
42+
{["message", "message_status"].indexOf(props.type) !== -1 &&
4343
(props.showLoader ? (
4444
<div>
4545
{text} {props.showLoader ? <div className="loader"></div> : null}
@@ -53,15 +53,15 @@ function Message(props: {
5353
<div className="cell-output" dangerouslySetInnerHTML={{ __html: text }}></div>
5454
))}
5555

56-
{(props.type == "message_raw") &&
56+
{(["message_raw", "message_error"].indexOf(props.type) !== -1) &&
5757
(props.showLoader ? (
5858
<div>
5959
{text} {props.showLoader ? <div className="loader"></div> : null}
6060
</div>
6161
) : (
6262
<div className="cell-output" dangerouslySetInnerHTML={{ __html: text }}></div>
6363
))}
64-
64+
6565
{props.type == "image/png" &&
6666
<div className="cell-output-image" dangerouslySetInnerHTML={{ __html: `<img src='data:image/png;base64,${text}' />` }}></div>
6767
}

gpt_code_ui/kernel_program/kernel_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ def flush_kernel_msgs(kc, tries=1, timeout=0.2):
149149
elif msg["msg_type"] == "error":
150150
send_message(
151151
utils.escape_ansi("\n".join(msg["content"]["traceback"])),
152-
"message_raw",
152+
"message_error",
153153
)
154154
except queue.Empty:
155155
hit_empty += 1

gpt_code_ui/kernel_program/main.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,10 @@ def on_recv(conn, ident, message):
8080
logger.debug("Kernel is ready.")
8181
result_queue.put({
8282
"value": "Kernel is ready.",
83-
"type": "message"
83+
"type": "message_status"
8484
})
8585

86-
elif message["type"] in ["message", "message_raw", "image/png", "image/jpeg"]:
86+
elif message["type"] in ["message", "message_raw", "message_error", "image/png", "image/jpeg"]:
8787
# TODO: 1:1 kernel <> channel mapping
8888
logger.debug("%s of type %s" % (message["value"], message["type"]))
8989

0 commit comments

Comments
 (0)