stream option in MicVAD.new is not available anymore?

[Enuriru]

const vad = await MicVAD.new({ ... stream: mediaStream, ...

It worked before but stopped in the latest release. How can I pass an existing media stream to the lib?

Thanks

[ricky0123]

Hi @Enuriru now you should pass these parameters

vad/packages/web/src/real-time-vad.ts

Lines 66 to 68 in 7cbadd3

	getStream: () => Promise<MediaStream>
	pauseStream: (stream: MediaStream) => Promise<void>
	resumeStream: (stream: MediaStream) => Promise<MediaStream>

getStream is called at the beginning, so you can have it pass in your stream (and you can have resumeStream return your stream as well).

You can see the default values here for inspiration

vad/packages/web/src/real-time-vad.ts

Lines 102 to 125 in 7cbadd3

	getStream: async () => {
	return await navigator.mediaDevices.getUserMedia({
	audio: {
	channelCount: 1,
	echoCancellation: true,
	autoGainControl: true,
	noiseSuppression: true,
	},
	})
	},
	pauseStream: async (_stream: MediaStream) => {
	_stream.getTracks().forEach((track) => {
	track.stop()
	})
	},
	resumeStream: async (_stream: MediaStream) => {
	return await navigator.mediaDevices.getUserMedia({
	audio: {
	channelCount: 1,
	echoCancellation: true,
	autoGainControl: true,
	noiseSuppression: true,
	},
	})

I added this because we recently made it (in #198) so that calling vad.pause() stops the stream tracks (in order to remove the microphone indicator from the browser), but if people are passing in their own stream, we don't want to stop it and then create a new stream when pause and resume are called.

You can also see how I'm testing the alternative, where someone passes in a stream and does nothing to it on pause/resume, here

vad/test-site/src/index.tsx

Lines 334 to 345 in 7cbadd3

	const stream = await defaultVADParams.getStream()
	getStream = async () => {
	console.log("called getStream")
	return stream
	}
	pauseStream = async (_stream: MediaStream) => {
	console.log("called pauseStream")
	}
	resumeStream = async (_stream: MediaStream) => {
	console.log("called resumeStream")
	return stream
	}