Skip to content

Commit 0ed0d77

Browse files
committed
[PUSB] PUSBCallback struct has been merged into PUSBListNode
This slightly simplifies PluggableUSB API.
1 parent bda5848 commit 0ed0d77

File tree

2 files changed

+11
-14
lines changed

2 files changed

+11
-14
lines changed

hardware/arduino/avr/cores/arduino/PluggableUSB.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ int PUSB_GetInterface(u8* interfaceNum)
4040
int ret = 0;
4141
PUSBListNode* node = rootNode;
4242
for (u8 i=0; i<modules_count; i++) {
43-
ret = node->cb->getInterface(interfaceNum);
43+
ret = node->getInterface(interfaceNum);
4444
node = node->next;
4545
}
4646
return ret;
@@ -51,7 +51,7 @@ int PUSB_GetDescriptor(int8_t t)
5151
int ret = 0;
5252
PUSBListNode* node = rootNode;
5353
for (u8 i=0; i<modules_count && ret == 0; i++) {
54-
ret = node->cb->getDescriptor(t);
54+
ret = node->getDescriptor(t);
5555
node = node->next;
5656
}
5757
return ret;
@@ -62,7 +62,7 @@ bool PUSB_Setup(USBSetup& setup, u8 j)
6262
bool ret = false;
6363
PUSBListNode* node = rootNode;
6464
for (u8 i=0; i<modules_count && ret == false; i++) {
65-
ret = node->cb->setup(setup, j);
65+
ret = node->setup(setup, j);
6666
node = node->next;
6767
}
6868
return ret;
@@ -85,16 +85,16 @@ int8_t PUSB_AddFunction(PUSBListNode *node, u8* interface)
8585
}
8686

8787
*interface = lastIf;
88-
lastIf += node->cb->numInterfaces;
89-
for ( u8 i = 0; i< node->cb->numEndpoints; i++) {
90-
_initEndpoints[lastEp] = node->cb->endpointType[i];
88+
lastIf += node->numInterfaces;
89+
for ( u8 i = 0; i< node->numEndpoints; i++) {
90+
_initEndpoints[lastEp] = node->endpointType[i];
9191
lastEp++;
9292
}
9393
modules_count++;
94-
return lastEp - node->cb->numEndpoints;
94+
return lastEp - node->numEndpoints;
9595
// restart USB layer???
9696
}
9797

9898
#endif
9999

100-
#endif /* if defined(USBCON) */
100+
#endif /* if defined(USBCON) */

hardware/arduino/avr/cores/arduino/PluggableUSB.h

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,21 +25,18 @@
2525

2626
#if defined(USBCON)
2727

28-
typedef struct __attribute__((packed))
29-
{
28+
class PUSBListNode {
29+
public:
30+
PUSBListNode() { }
3031
bool (*setup)(USBSetup& setup, u8 i);
3132
int (*getInterface)(u8* interfaceNum);
3233
int (*getDescriptor)(int8_t t);
3334
int8_t numEndpoints;
3435
int8_t numInterfaces;
3536
uint8_t *endpointType;
36-
} PUSBCallbacks;
3737

38-
class PUSBListNode {
3938
public:
4039
PUSBListNode *next = NULL;
41-
PUSBCallbacks *cb;
42-
PUSBListNode(PUSBCallbacks *ncb) {cb = ncb;}
4340
};
4441

4542
int8_t PUSB_AddFunction(PUSBListNode *node, u8 *interface);

0 commit comments

Comments
 (0)