Option for compilation with ASan/MSan

[AshFungor]

Hey, @riebl!

Do you think I's a good idea to add global option to enable sanitizers? I've been working in my fork for a while and had to use those at some point, but enabling them on per-target basis is a bit frustrating. Probably the best approach would be turning them on for all targets at once. The only issue I might think of is that only Artery modules would be tracked, Omnet++, INET and other external components would still be oblivious - though I don't think that debugging them should be considered here.

I'm also aware of available VS Code launch config for debugging, but to be honest I rarely tend to debug in such way, most of the time reports from sanitizers are more than enough to track memory issues and I use logging for everything else. So, what do you think?

Sorry, I'm quite busy at the moment, so I plan to get to work on Artery in December. Maybe someone could implement this earlier :)

[riebl]

Hi @AshFungor,

what do you have in mind? Why is adding -fsanitize= to CMAKE_CXX_FLAGS not enough?
I am fine with adding such a feature to our CMake setup, but right now I miss the benefit of a dedicated feature over the plain CMake approach.

[AshFungor]

Well, I can see the following benefits:

1. Users would normally also enable some other debug options too (like -fno-omit-frame-pointer)
2. Users would have to also provide -fsanitize= for linker flags too, which means specifying two variables on command line
3. Sanitizers are not available across all compilers and it's a good idea to put them behind a compiler check in case CMake picks the wrong one

[riebl]

Maybe add these settings simply to a CMake preset? I think it is pretty hard to constantly keep up with the features provided by GCC and LLVM, so the "auto detection" is probably broken sooner or later. Still, a preset file may point at least in the right direction.

[AshFungor]

Yeah, that's a good approach, too :)

[mill1m]

Hi @riebl, can you add me as contributor? I want to add PR for specified presets and modify tools/build.py to support --preset flag

[riebl]

Hi @mill1m,

GitHub will list anyone who has contributed a commit as contributor automatically. Just create a PR – no special permission is required for this step. I will then review it and as soon as it is merged, you will be listed as contributor.