Merge pull request #424 from gwarf/ansible_lint

style: address ansible-lint errors and small clean-up.

Author: riemers

handlers/main.yml

@@ -1,6 +1,6 @@
 ---
 # non macOS
-- name: Restart_gitlab_runner
+- name: "Restart_gitlab_runner"
   ansible.builtin.service:
     name: gitlab-runner
     state: "{{ gitlab_runner_restart_state }}"
@@ -9,21 +9,21 @@
   when: ansible_facts['os_family'] != 'Darwin' and ansible_facts['os_family'] != 'Windows' and not gitlab_runner_container_install
 
 # macOS
-- name: Restart_gitlab_runner_macos
+- name: "Restart_gitlab_runner_macos"
   ansible.builtin.command: "{{ gitlab_runner_executable }} restart"
   listen: restart_gitlab_runner_macos
   become: "{{ gitlab_runner_system_mode }}"
   when: ansible_facts['os_family'] == 'Darwin' and gitlab_runner_macos_start_runner
 
-- name: Restart_gitlab_runner_windows
+- name: "Restart_gitlab_runner_windows"
   ansible.windows.win_command: "{{ gitlab_runner_executable }} restart"
   args:
     chdir: "{{ gitlab_runner_config_file_location }}"
   listen: restart_gitlab_runner_windows
   when: ansible_facts['os_family'] == 'Windows' and gitlab_runner_windows_start_runner
 
 # Container
-- name: Restart_gitlab_runner_container
+- name: "Restart_gitlab_runner_container"
   community.docker.docker_container:
     name: "{{ gitlab_runner_container_name }}"
     restart: true

tasks/config-runner-container.yml

@@ -16,7 +16,7 @@
   check_mode: false
   changed_when: false
 
-- name: Update config
+- name: "Update config"
   ansible.builtin.include_tasks: update-config-runner.yml
   vars:
     runn_name_prefix: "{{ conf_name_prefix }} runner[{{ (gitlab_runner_index | int) + 1 }}/{{ gitlab_runner_runners | length }}]:"

tasks/config-runner-windows.yml

@@ -15,7 +15,7 @@
   check_mode: false
   changed_when: false
 
-- name: Update config
+- name: "Update config"
   ansible.builtin.include_tasks: update-config-runner-windows.yml
   vars:
     runn_name_prefix: "{{ conf_name_prefix }} runner[{{ (gitlab_runner_index | int) + 1 }}/{{ gitlab_runner_runners | length }}]:"

tasks/config-runner.yml

@@ -17,7 +17,7 @@
   changed_when: false
   no_log: "{{ gitlab_runner_no_log_secrets | default(omit) }}"
 
-- name: Update config
+- name: "Update config"
   ansible.builtin.include_tasks: update-config-runner.yml
   vars:
     runn_name_prefix: "{{ conf_name_prefix }} runner[{{ (gitlab_runner_index | int) + 1 }}/{{ gitlab_runner_runners | length }}]:"

tasks/config-runners-container.yml

@@ -1,22 +1,22 @@
 ---
-- name: Get existing config.toml
+- name: "Get existing config.toml"
   ansible.builtin.slurp:
     src: "{{ gitlab_runner_config_file }}"
   register: runner_config_file
 
-- name: Get pre-existing runner configs
+- name: "Get pre-existing runner configs"
   ansible.builtin.set_fact:
     runner_configs: "{{ (runner_config_file['content'] | b64decode).split('[[runners]]\n') }}"
 
-- name: Create temporary directory
+- name: "Create temporary directory"
   ansible.builtin.tempfile:
     state: directory
     suffix: gitlab-runner-config
   register: temp_runner_config_dir
   check_mode: false
   changed_when: false
 
-- name: Write config section for each runner
+- name: "Write config section for each runner"
   vars:
     conf_name_prefix: "conf[{{ (runner_config_index | int) + 1 }}/{{ runner_configs | length }}]:"
   ansible.builtin.include_tasks: config-runner-container.yml
@@ -25,7 +25,7 @@
     index_var: runner_config_index
     loop_var: runner_config
 
-- name: Assemble new config.toml
+- name: "Assemble new config.toml"
   ansible.builtin.assemble:
     src: "{{ temp_runner_config_dir.path }}"
     dest: "{{ gitlab_runner_config_file }}"
@@ -37,7 +37,7 @@
       verify -c /gitlab-runner.conf
     mode: "0600"
 
-- name: Remove temporary directory
+- name: "Remove temporary directory"
   ansible.builtin.file:
     path: "{{ temp_runner_config_dir.path }}"
     state: "absent"

tasks/config-runners-windows.yml

@@ -1,26 +1,26 @@
 ---
-- name: (Windows) Get existing config.toml
+- name: "(Windows) Get existing config.toml"
   ansible.builtin.slurp:
     src: "{{ gitlab_runner_config_file }}"
   register: runner_config_file
 
-- name: (Windows) Get pre-existing global config
+- name: "(Windows) Get pre-existing global config"
   ansible.builtin.set_fact:
     runner_global_config: "{{ (runner_config_file['content'] | b64decode).split('[[runners]]')[0] }}"
 
-- name: (Windows) Get pre-existing runner configs
+- name: "(Windows) Get pre-existing runner configs"
   ansible.builtin.set_fact:
     runner_configs: "{{ (runner_config_file['content'] | b64decode).split('[[runners]]')[1:] }}"
 
-- name: (Windows) Create temporary directory
+- name: "(Windows) Create temporary directory"
   ansible.windows.win_tempfile:
     state: directory
     suffix: gitlab-runner-config
   register: temp_runner_config_dir
   check_mode: false
   changed_when: false
 
-- name: (Windows) Write config section for each runner
+- name: "(Windows) Write config section for each runner"
   vars:
     conf_name_prefix: "conf[{{ (runner_config_index | int) + 1 }}/{{ runner_configs | length }}]:"
   ansible.builtin.include_tasks: config-runner-windows.yml
@@ -29,35 +29,35 @@
     index_var: runner_config_index
     loop_var: runner_config
 
-- name: (Windows) Assemble new config.toml
+- name: "(Windows) Assemble new config.toml"
   when: not ansible_check_mode
   block:
-    - name: (Windows) Create temporary file config.toml
+    - name: "(Windows) Create temporary file config.toml"
       ansible.windows.win_tempfile:
         state: file
         suffix: temp
       register: config_toml_temp
 
-    - name: (Windows) Write global config to file
+    - name: "(Windows) Write global config to file"
       community.windows.win_lineinfile:
         insertbefore: BOF
         path: "{{ config_toml_temp.path }}"
         line: "{{ runner_global_config }}"
 
-    - name: (Windows) Create temporary file runners-config.toml
+    - name: "(Windows) Create temporary file runners-config.toml"
       ansible.windows.win_tempfile:
         state: file
         suffix: temp
       register: runners_config_toml_temp
 
-    - name: (Windows) Assemble runners files in config dir
+    - name: "(Windows) Assemble runners files in config dir"
       ansible.windows.win_shell: dir -rec | gc | out-file "{{ runners_config_toml_temp.path }}"
       args:
         chdir: "{{ temp_runner_config_dir.path }}"
 
-    - name: (Windows) Assemble new config.toml
+    - name: "(Windows) Assemble new config.toml"
       ansible.windows.win_shell: gc "{{ config_toml_temp.path }}","{{ runners_config_toml_temp.path }}" | Set-Content "{{ gitlab_runner_config_file }}"
-    - name: (Windows) Verify config
+    - name: "(Windows) Verify config"
       ansible.windows.win_command: "{{ gitlab_runner_executable }} verify"
       args:
         chdir: "{{ gitlab_runner_config_file_location }}"

tasks/config-runners.yml

@@ -1,24 +1,24 @@
 ---
-- name: Get existing config.toml
+- name: "Get existing config.toml"
   ansible.builtin.slurp:
     src: "{{ gitlab_runner_config_file }}"
   register: runner_config_file
   become: "{{ gitlab_runner_system_mode }}"
 
-- name: Get pre-existing runner configs
+- name: "Get pre-existing runner configs"
   ansible.builtin.set_fact:
     runner_configs: "{{ (runner_config_file['content'] | b64decode).split('[[runners]]\n') }}"
   no_log: "{{ gitlab_runner_no_log_secrets | default(omit) }}"
 
-- name: Create temporary directory
+- name: "Create temporary directory"
   ansible.builtin.tempfile:
     state: directory
     suffix: gitlab-runner-config
   register: temp_runner_config_dir
   check_mode: false
   changed_when: false
 
-- name: Write config section for each runner
+- name: "Write config section for each runner"
   vars:
     conf_name_prefix: "conf[{{ (runner_config_index | int) + 1 }}/{{ runner_configs | length }}]:"
   ansible.builtin.include_tasks: config-runner.yml
@@ -28,7 +28,7 @@
     loop_var: runner_config
   no_log: "{{ gitlab_runner_no_log_secrets | default(omit) }}"
 
-- name: Assemble new config.toml
+- name: "Assemble new config.toml"
   ansible.builtin.assemble:
     src: "{{ temp_runner_config_dir.path }}"
     dest: "{{ gitlab_runner_config_file }}"

tasks/global-setup-windows.yml

@@ -1,17 +1,17 @@
 ---
-- name: (Windows) Create .gitlab-runner dir
+- name: "(Windows) Create .gitlab-runner dir"
   ansible.windows.win_file:
     path: "{{ gitlab_runner_config_file_location }}"
     state: directory
 
-- name: (Windows) Ensure config.toml exists
+- name: "(Windows) Ensure config.toml exists"
   ansible.windows.win_file:
     path: "{{ gitlab_runner_config_file }}"
     state: touch
     modification_time: preserve
     access_time: preserve
 
-- name: (Windows) Set concurrent option
+- name: "(Windows) Set concurrent option"
   community.windows.win_lineinfile:
     dest: "{{ gitlab_runner_config_file }}"
     regexp: ^(\s*)concurrent =.*
@@ -23,7 +23,7 @@
     - restart_gitlab_runner_macos
     - restart_gitlab_runner_windows
 
-- name: (Windows) Set check_interval option
+- name: "(Windows) Set check_interval option"
   community.windows.win_lineinfile:
     dest: "{{ gitlab_runner_config_file }}"
     regexp: ^check_interval =.*
@@ -35,32 +35,32 @@
     - restart_gitlab_runner
     - restart_gitlab_runner_windows
 
-- name: (Windows) Add listen_address to config
+- name: "(Windows) Add listen_address to config"
   community.windows.win_lineinfile:
     dest: "{{ gitlab_runner_config_file }}"
     regexp: ^listen_address =.*
     line: listen_address = "{{ gitlab_runner_listen_address }}"
     insertafter: \s*concurrent.*
     state: present
-  when: gitlab_runner_listen_address | length > 0  # Ensure value is set
+  when: gitlab_runner_listen_address | length > 0 # Ensure value is set
   notify:
     - restart_gitlab_runner
     - restart_gitlab_runner_windows
 
-- name: (Windows) Add sentry dsn to config
+- name: "(Windows) Add sentry dsn to config"
   community.windows.win_lineinfile:
     dest: "{{ gitlab_runner_config_file }}"
     regexp: ^sentry_dsn =.*
     line: sentry_dsn = "{{ gitlab_runner_sentry_dsn }}"
     insertafter: \s*concurrent.*
     state: present
-  when: gitlab_runner_sentry_dsn | length > 0  # Ensure value is set
+  when: gitlab_runner_sentry_dsn | length > 0 # Ensure value is set
   notify:
     - restart_gitlab_runner
     - restart_gitlab_runner_macos
     - restart_gitlab_runner_windows
 
-- name: (Windows) Add session server listen_address to config
+- name: "(Windows) Add session server listen_address to config"
   community.windows.win_lineinfile:
     dest: "{{ gitlab_runner_config_file }}"
     regexp: ^(\s+)listen_address =
@@ -72,7 +72,7 @@
     - restart_gitlab_runner_macos
     - restart_gitlab_runner_windows
 
-- name: (Windows) Add session server advertise_address to config
+- name: "(Windows) Add session server advertise_address to config"
   community.windows.win_lineinfile:
     dest: "{{ gitlab_runner_config_file }}"
     regexp: ^\s*advertise_address =
@@ -84,7 +84,7 @@
     - restart_gitlab_runner_macos
     - restart_gitlab_runner_windows
 
-- name: (Windows) Add session server session_timeout to config
+- name: "(Windows) Add session server session_timeout to config"
   community.windows.win_lineinfile:
     dest: "{{ gitlab_runner_config_file }}"
     regexp: ^\s*session_timeout =