Merge pull request #1570 from riganti/improve-assemblyload-error

Include referencing assembly in "could not load" error

Author: exyi

src/Framework/Framework/Compilation/ControlTree/DefaultControlResolver.cs

@@ -164,12 +164,10 @@ private static void RegisterCapabilitiesFromInterfaces(Type type)
 
         private IEnumerable<Assembly> GetAllRelevantAssemblies(string dotvvmAssembly)
         {
-
 #if DotNetCore
             var assemblies = compiledAssemblyCache.GetAllAssemblies()
                    .Where(a => a.GetReferencedAssemblies().Any(r => r.Name == dotvvmAssembly));
 #else
-
             var loadedAssemblies = compiledAssemblyCache.GetAllAssemblies()
                 .Where(a => a.GetReferencedAssemblies().Any(r => r.Name == dotvvmAssembly));
 
@@ -178,7 +176,16 @@ private IEnumerable<Assembly> GetAllRelevantAssemblies(string dotvvmAssembly)
             // ReflectionUtils.GetAllAssemblies() in netframework returns only assemblies which have already been loaded into
             // the current AppDomain, to return all assemblies we traverse recursively all referenced Assemblies
             var assemblies = loadedAssemblies
-                .SelectRecursively(a => a.GetReferencedAssemblies().Where(an => visitedAssemblies.Add(an.FullName)).Select(an => Assembly.Load(an)))
+                .SelectRecursively(a => a.GetReferencedAssemblies().Where(an => visitedAssemblies.Add(an.FullName)).Select(an => {
+                    try
+                    {
+                        return Assembly.Load(an);
+                    }
+                    catch (Exception ex)
+                    {
+                        throw new Exception($"Unable to load assembly '{an.FullName}' referenced by '{a.FullName}'.", ex);
+                    }
+                }))
                 .Where(a => a.GetReferencedAssemblies().Any(r => r.Name == dotvvmAssembly))
                 .Distinct();
 #endif