Add MarkupOptions.AllowResourceBinding

Some controls now need to allow resource bindings,
but not hardcoded values (i.e. grid columns)

Author: exyi

src/Framework/Framework/Binding/DotvvmCapabilityProperty.cs

@@ -336,13 +336,21 @@ internal static IControlAttributeDescriptor InitializeArgument(ICustomAttributeP
                 {
                     dotvvmProperty = new DotvvmProperty(propertyName, type, declaringType, boxedDefaultValue, false, attributeProvider);
                     dotvvmProperty.OwningCapability = declaringCapability;
-                    
+
                     var isNullable = propertyType.IsNullable() || type.IsNullable();
                     if (!defaultValue.HasValue && !isNullable)
                         dotvvmProperty.MarkupOptions._required ??= true;
 
+                    if (typeof(IValueBinding).IsAssignableFrom(propertyType))
+                    {
+                        dotvvmProperty.MarkupOptions._allowHardCodedValue ??= false;
+                        dotvvmProperty.MarkupOptions._allowResourceBinding ??= false;
+                    }
                     if (typeof(IBinding).IsAssignableFrom(propertyType))
+                    {
                         dotvvmProperty.MarkupOptions._allowHardCodedValue ??= false;
+                        dotvvmProperty.MarkupOptions._allowResourceBinding ??= true;
+                    }
                     else if (!typeof(ValueOrBinding).IsAssignableFrom(propertyType.UnwrapNullableType()))
                         dotvvmProperty.MarkupOptions._allowBinding ??= false;
 

src/Framework/Framework/Binding/DotvvmProperty.cs

@@ -426,6 +426,7 @@ public static void InitializeProperty(DotvvmProperty property, ICustomAttributeP
             if (property.IsBindingProperty)
             {
                 property.MarkupOptions.AllowHardCodedValue = false;
+                property.MarkupOptions.AllowResourceBinding = !typeof(IValueBinding).IsAssignableFrom(property.PropertyType);
             }
         }
 

src/Framework/Framework/Compilation/ControlTree/ControlTreeResolverBase.cs

@@ -450,7 +450,7 @@ private void ValidateAttribute(IPropertyDescriptor property, IAbstractControl co
                 return;
             }
 
-            if (!property.MarkupOptions.AllowHardCodedValue &&
+            if (!property.MarkupOptions.AllowResourceBinding &&
                 attribute.ValueNode is DothtmlValueBindingNode resourceBinding &&
                 treatBindingAsHardCodedValue.Contains(resourceBinding.BindingNode.Name))
             {

src/Framework/Framework/Controls/CheckBox.cs

@@ -22,7 +22,7 @@ public class CheckBox : CheckableControlBase
         /// <summary>
         /// Gets or sets whether the control is checked.
         /// </summary>
-        [MarkupOptions(AllowHardCodedValue = false)]
+        [MarkupOptions(AllowHardCodedValue = false, AllowResourceBinding = true)]
         public bool? Checked
         {
             get { return (bool?)GetValue(CheckedProperty); }

src/Framework/Framework/Controls/DotvvmBindableObject.cs

@@ -69,7 +69,7 @@ public bool IsPropertySet(DotvvmProperty property, bool inherit = true)
         /// </summary>
         [BindingCompilationRequirements(
                 optional: new[] { typeof(Binding.Properties.SimplePathExpressionBindingProperty) })]
-        [MarkupOptions(AllowHardCodedValue = false)]
+        [MarkupOptions(AllowHardCodedValue = false, AllowResourceBinding = true)]
         public object? DataContext
         {
             get {

src/Framework/Framework/Controls/GridViewCheckBoxColumn.cs

@@ -14,7 +14,7 @@ public class GridViewCheckBoxColumn : GridViewColumn
         /// <summary>
         /// Gets or sets a binding which retrieves the value to display from the current data item.
         /// </summary>
-        [MarkupOptions(AllowHardCodedValue = false, Required = true)]
+        [MarkupOptions(AllowHardCodedValue = false, AllowResourceBinding = true, Required = true)]
         public IStaticValueBinding ValueBinding
         {
             get { return (IStaticValueBinding)GetValueRaw(ValueBindingProperty)!; }

src/Framework/Framework/Controls/ItemsControl.cs

@@ -27,7 +27,7 @@ public abstract class ItemsControl : HtmlGenericControl
         /// <summary>
         /// Gets or sets the source collection or a GridViewDataSet that contains data in the control.
         /// </summary>
-        [MarkupOptions(AllowHardCodedValue = false)]
+        [MarkupOptions(AllowHardCodedValue = false, AllowResourceBinding = true)]
         [BindingCompilationRequirements(
             required: new[] { typeof(DataSourceAccessBinding) },
             optional: new[] { typeof(DataSourceLengthBinding), typeof(CollectionElementDataContextBindingProperty) })]

src/Framework/Framework/Controls/MarkupOptionsAttribute.cs

@@ -33,6 +33,16 @@ public bool AllowHardCodedValue
         }
         internal bool? _allowHardCodedValue = null;
 
+        /// <summary>
+        /// Gets or sets whether the `resource` binding can be used on this property. By default, the <see cref="AllowHardCodedValue" /> is copied.
+        /// </summary>
+        public bool AllowResourceBinding
+        {
+            get => _allowResourceBinding ?? AllowHardCodedValue;
+            set => _allowResourceBinding = value;
+        }
+        internal bool? _allowResourceBinding = null;
+
         /// <summary>
         /// Gets or sets the name in markup. Null means that the name of the property should be used.
         /// </summary>

src/Framework/Framework/Controls/Validation.cs

@@ -24,7 +24,7 @@ public class Validation
         /// Note that data annotations of the property used in the target binding are not validated, only the rules inside its value.
         /// </summary>
         [AttachedProperty(typeof(object))]
-        [MarkupOptions(AllowHardCodedValue = false)]
+        [MarkupOptions(AllowHardCodedValue = false, AllowResourceBinding = true)]
         public static DotvvmProperty TargetProperty = DotvvmProperty.Register<object?, Validation>(() => TargetProperty, null, true);
 
 

src/Tests/ControlTests/MarkupControlTests.cs

@@ -144,7 +144,7 @@ @wrapperTag div
             StringAssert.Contains(exception.Message, "cannot be used in resource-binding only data context, because it uses value bindings on the data context.");
 
             // is dothtml (not dotcontrol), otherwise it's impossible to find where is it being a problem
-            StringAssert.EndsWith("MarkupControl_ValueInResource_Error.dothtml", exception.FileName);
+            StringAssert.EndsWith(exception.FileName, "MarkupControl_ValueInResource_Error.dothtml");
         }
 
         [TestMethod]