Add script to generate pre-assigned property IDs

* Optimize relevant property accessed using the new compile-time constants
* Optimize PropertyGroup.Clear
* Cover DotvvmPropertyDictionary with more tests (and fix some bugs)

Author: exyi

src/Framework/Framework/Binding/BindingHelper.cs

@@ -64,8 +64,8 @@ public static string FormatKnockoutScript(this ParametrizedCode code, DotvvmBind
         /// Gets Internal.PathFragmentProperty or DataContext.KnockoutExpression. Returns null if none of these is set.
         /// </summary>
         public static string? GetDataContextPathFragment(this DotvvmBindableObject currentControl) =>
-            currentControl.properties.TryGet(Internal.PathFragmentProperty, out var pathFragment) && pathFragment is string pathFragmentStr ? pathFragmentStr :
-            currentControl.properties.TryGet(DotvvmBindableObject.DataContextProperty, out var dataContext) && dataContext is IValueBinding binding ?
+            currentControl.properties.TryGet(DotvvmPropertyIdAssignment.PropertyIds.Internal_PathFragment, out var pathFragment) && pathFragment is string pathFragmentStr ? pathFragmentStr :
+            currentControl.properties.TryGet(DotvvmPropertyIdAssignment.PropertyIds.DotvvmBindableObject_DataContext, out var dataContext) && dataContext is IValueBinding binding ?
                 binding.GetProperty<SimplePathExpressionBindingProperty>()
                 .Code.FormatKnockoutScript(currentControl, binding) :
             null;
@@ -88,16 +88,16 @@ internal static (int stepsUp, DotvvmBindableObject target) FindDataContextTarget
             if (bindingContext == null || controlContext == null || controlContext.Equals(bindingContext)) return (0, control);
 
             var changes = 0;
-            foreach (var a in control.GetAllAncestors(includingThis: true))
+            for (var ancestor = control; ancestor is {}; ancestor = ancestor.Parent)
             {
-                var ancestorContext = a.GetDataContextType(inherit: false);
+                var ancestorContext = ancestor.GetDataContextType(inherit: false);
                 if (bindingContext.Equals(ancestorContext))
-                    return (changes, a);
+                    return (changes, ancestor);
 
                 // count only client-side data contexts (DataContext={resource:} is skipped in JS)
-                if (a.properties.TryGet(DotvvmBindableObject.DataContextProperty, out var ancestorRuntimeContext))
+                if (ancestor.properties.TryGet(DotvvmPropertyIdAssignment.PropertyIds.DotvvmBindableObject_DataContext, out var ancestorRuntimeContext))
                 {
-                    if (a.properties.TryGet(Internal.IsServerOnlyDataContextProperty, out var isServerOnly) && isServerOnly != null)
+                    if (ancestor.properties.GetOrNull(DotvvmPropertyIdAssignment.PropertyIds.Internal_IsServerOnlyDataContext) is {} isServerOnly)
                     {
                         if (isServerOnly is false)
                             changes++;
@@ -173,9 +173,8 @@ public static T ExecDelegate<T>(this BindingDelegate<T> func, DotvvmBindableObje
                 // this has O(h^2) complexity because GetValue calls another GetDataContexts,
                 // but this function is used rarely - for exceptions, manually created bindings, ...
                 // Normal bindings have specialized code generated in BindingCompiler
-                if (c.IsPropertySet(DotvvmBindableObject.DataContextProperty, inherit: false))
+                if (c.properties.Contains(DotvvmPropertyIdAssignment.PropertyIds.DotvvmBindableObject_DataContext))
                 {
-                    Debug.Assert(c.properties.Contains(DotvvmBindableObject.DataContextProperty), "Control claims that DataContextProperty is set, but it's not present in the properties dictionary.");
                     yield return c.GetValue(DotvvmBindableObject.DataContextProperty);
                     count--;
                 }

src/Framework/Framework/Binding/DotvvmCapabilityProperty.CodeGeneration.cs

@@ -76,27 +76,28 @@ public static (LambdaExpression getter, LambdaExpression setter) CreatePropertyG
                 var valueParameter = Expression.Parameter(type, "value");
                 var ctor = typeof(VirtualPropertyGroupDictionary<>)
                     .MakeGenericType(propType)
-                    .GetConstructor(new [] { typeof(DotvvmBindableObject), typeof(DotvvmPropertyGroup) })!;
+                    .GetConstructor(BindingFlags.NonPublic | BindingFlags.Instance, [ typeof(DotvvmBindableObject), typeof(ushort), typeof(bool) ])!;
                 var createMethod = typeof(VirtualPropertyGroupDictionary<>)
                     .MakeGenericType(propType)
                     .GetMethod(
                         typeof(ValueOrBinding).IsAssignableFrom(elementType) ? nameof(VirtualPropertyGroupDictionary<int>.CreatePropertyDictionary) :
                         nameof(VirtualPropertyGroupDictionary<int>.CreateValueDictionary),
-                        BindingFlags.Public | BindingFlags.Static
+                        BindingFlags.NonPublic | BindingFlags.Static,
+                        [ typeof(DotvvmBindableObject), typeof(ushort) ]
                     )!;
                 var enumerableType = typeof(IEnumerable<>).MakeGenericType(typeof(KeyValuePair<,>).MakeGenericType(typeof(string), elementType));
                 var copyFromMethod =
                     typeof(VirtualPropertyGroupDictionary<>)
                     .MakeGenericType(propType)
-                    .GetMethod("CopyFrom", new [] { enumerableType, typeof(bool) })!;
+                    .GetMethod("CopyFrom", [ enumerableType, typeof(bool) ])!;
                 return (
                     Lambda(
-                        Convert(Call(createMethod, currentControlParameter, Constant(pgroup)), type),
+                        Convert(Call(createMethod, currentControlParameter, Constant(pgroup.Id)), type),
                         currentControlParameter
                     ),
                     Lambda(
                         Call(
-                            New(ctor, currentControlParameter, Constant(pgroup)),
+                            New(ctor, currentControlParameter, Constant(pgroup.Id), Constant(pgroup.IsBindingProperty)),
                             copyFromMethod,
                             Convert(valueParameter, enumerableType),
                             Constant(true) // clear

src/Framework/Framework/Binding/DotvvmProperty.cs

@@ -209,9 +209,10 @@ public bool IsOwnedByCapability(DotvvmCapabilityProperty capability) =>
 
         private object? GetInheritedValue(DotvvmBindableObject control)
         {
+            var id = this.Id;
             for (var p = control.Parent; p is not null; p = p.Parent)
             {
-                if (p.properties.TryGet(Id, out var v))
+                if (p.properties.TryGet(id, out var v))
                     return v;
             }
             return DefaultValue;

src/Framework/Framework/Binding/DotvvmPropertyId.cs

@@ -129,6 +129,8 @@ public bool IsZero
 
         public override string ToString()
         {
+            if (IsZero)
+                return "[0000_0000]";
             if (IsPropertyGroup)
             {
                 var pg = PropertyGroupInstance;