Add CONNECT_RETRIES and log failures

Author: rikroe

custom_components/eurotronic_cometblue/__init__.py

@@ -1,4 +1,5 @@
 """Comet Blue Bluetooth integration."""
+
 from __future__ import annotations
 
 from datetime import datetime
@@ -39,6 +40,7 @@
 ]
 LOGGER = logging.getLogger(__name__)
 TIMEOUT = 20
+CONNECT_RETRIES = 3
 
 
 async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
@@ -54,7 +56,10 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
         )
 
     cometblue_device = cometblue.AsyncCometBlue(
-        device=ble_device, pin=entry.data.get(CONF_PIN), timeout=TIMEOUT, retries=1
+        device=ble_device,
+        pin=entry.data.get(CONF_PIN),
+        timeout=TIMEOUT,
+        retries=CONNECT_RETRIES,
     )
     try:
         async with cometblue_device:

custom_components/eurotronic_cometblue/climate.py

@@ -1,4 +1,5 @@
 """Comet Blue climate integration."""
+
 from __future__ import annotations
 
 import logging

custom_components/eurotronic_cometblue/coordinator.py

@@ -1,4 +1,5 @@
 """Provides the DataUpdateCoordinator."""
+
 from __future__ import annotations
 
 from datetime import timedelta
@@ -72,8 +73,15 @@ async def send_command(
                 while retry_count < RETRY_COUNT:
                     try:
                         return await getattr(self.device, function)(**payload)
-                    except (InvalidByteValueError, TimeoutError):  # noqa: PERF203
+                    except (InvalidByteValueError, TimeoutError) as ex:  # noqa: PERF203
                         retry_count += 1
+                        LOGGER.info(
+                            "Retrying command '%s' to '%s' after %s (%s)",
+                            payload,
+                            caller_entity_id,
+                            type(ex).__name__,
+                            ex,
+                        )
         except ValueError as err:
             raise ServiceValidationError(
                 f"Invalid payload '{payload}' for '{caller_entity_id}': {err}"
@@ -100,8 +108,7 @@ async def _async_update_data(self) -> dict[str, bytes]:
                     # If one value was not retrieved correctly, keep the old value
                     **{
                         k: retrieved_temperatures.get(k) or self.data.get(k)
-                        for k
-                        in CONF_ALL_TEMPERATURES
+                        for k in CONF_ALL_TEMPERATURES
                     },
                 }
                 # Reset failed update count if all values were retrieved correctly
@@ -110,6 +117,12 @@ async def _async_update_data(self) -> dict[str, bytes]:
             # allow invalid bytes until RETRY_COUNT is reached
             if self.failed_update_count < RETRY_COUNT and self.data:
                 self.failed_update_count += 1
+                LOGGER.info(
+                    "Returning old data for '%s' after %s (%s)",
+                    self.device.device.address,
+                    type(ex).__name__,
+                    ex,
+                )
                 return self.data
             raise UpdateFailed(f"Error in device response: {ex}") from ex
         except Exception as ex:

custom_components/eurotronic_cometblue/number.py

@@ -1,4 +1,5 @@
 """Comet Blue number integration."""
+
 from __future__ import annotations
 
 from collections.abc import Callable

custom_components/eurotronic_cometblue/sensor.py

@@ -1,4 +1,5 @@
 """Comet Blue sensor integration."""
+
 from __future__ import annotations
 
 from homeassistant.components.sensor import (

custom_components/eurotronic_cometblue/utils.py

@@ -1,4 +1,5 @@
 """Comet Blue Bluetooth utils."""
+
 from __future__ import annotations
 
 from datetime import time
@@ -36,6 +37,7 @@ def validate_half_precision(value: float) -> float:
         raise vol.Invalid(f"value {value} is not a float") from err
     return value
 
+
 def validate_cometblue_schedule(schedule: dict[str, time]) -> dict[str, time] | None:
     """Validate the schedule of time ranges.