Skip to content

Commit 4b37cbc

Browse files
committed
[Enhancement] Restrict changes to Backend components only (StarRocks)
1 parent 3a3bd35 commit 4b37cbc

File tree

5 files changed

+5
-15
lines changed

5 files changed

+5
-15
lines changed

web-common/src/features/connectors/connectors-utils.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
import type { V1AnalyzedConnector } from "../../runtime-client";
22

3-
export const OLAP_DRIVERS_WITHOUT_MODELING = [
4-
"clickhouse",
5-
"druid",
6-
"pinot",
7-
"starrocks",
8-
];
3+
export const OLAP_DRIVERS_WITHOUT_MODELING = ["clickhouse","druid","pinot"];
94

105
export function makeFullyQualifiedTableName(
116
driver: string,

web-common/src/features/sources/modal/AddClickHouseForm.svelte

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -266,15 +266,11 @@
266266
details = e.details !== e.message ? e.details : undefined;
267267
} else if (e?.response?.data) {
268268
const originalMessage = e.response.data.message;
269-
const humanReadableResult = humanReadableErrorMessage(
269+
const humanReadable = humanReadableErrorMessage(
270270
connector.name,
271271
e.response.data.code,
272272
originalMessage,
273273
);
274-
const humanReadable =
275-
typeof humanReadableResult === "string"
276-
? humanReadableResult
277-
: originalMessage;
278274
error = humanReadable;
279275
details =
280276
humanReadable !== originalMessage ? originalMessage : undefined;

web-common/src/features/sources/modal/AddDataForm.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,10 +265,10 @@
265265
clickhouseParamsValues: $clickhouseParamsForm,
266266
clickhouseDsnValues: $clickhouseDsnForm,
267267
});
268-
$: isCustomForm = connector.name === "clickhouse";
268+
$: isClickhouse = connector.name === "clickhouse";
269269
$: shouldShowSaveAnywayButton =
270270
isConnectorForm && (showSaveAnyway || clickhouseShowSaveAnyway);
271-
$: saveAnywayLoading = isCustomForm
271+
$: saveAnywayLoading = isClickhouse
272272
? clickhouseSubmitting && saveAnyway
273273
: submitting && saveAnyway;
274274

web-common/src/features/sources/modal/AddDataFormManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ export class AddDataFormManager {
375375
clickhouseConnectorType?: ClickHouseConnectorType;
376376
clickhouseParamsValues?: Record<string, unknown>;
377377
clickhouseDsnValues?: Record<string, unknown>;
378-
\ }): string {
378+
}): string {
379379
const connector = this.connector;
380380
const {
381381
connectionTab,

web-common/src/features/sources/modal/constants.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ export const OLAP_ENGINES = [
6262
"duckdb",
6363
"druid",
6464
"pinot",
65-
"starrocks",
6665
];
6766

6867
export const ALL_CONNECTORS = [...SOURCES, ...OLAP_ENGINES];

0 commit comments

Comments
 (0)