fix: limit grain options in visual metrics (#8680)

* fix: limit grain options in visual metrics

* feedback

Author: briangregoryholmes

web-common/src/features/workspaces/VisualMetrics.svelte

@@ -14,15 +14,18 @@
   import { TIMESTAMPS } from "@rilldata/web-common/lib/duckdb-data-types";
   import { eventBus } from "@rilldata/web-common/lib/event-bus/event-bus";
   import { queryClient } from "@rilldata/web-common/lib/svelte-query/globalQueryClient";
-  import { TIME_GRAIN } from "@rilldata/web-common/lib/time/config";
   import {
     createConnectorServiceOLAPListTables,
     createQueryServiceTableColumns,
     createRuntimeServiceAnalyzeConnectors,
     createRuntimeServiceGetInstance,
+  } from "@rilldata/web-common/runtime-client";
+
+  import {
+    V1TimeGrain,
     type MetricsViewSpecDimension,
     type V1Resource,
-  } from "@rilldata/web-common/runtime-client";
+  } from "@rilldata/web-common/runtime-client/gen/index.schemas";
   import { runtime } from "@rilldata/web-common/runtime-client/runtime-store";
   import { PlusIcon } from "lucide-svelte";
   import { tick } from "svelte";
@@ -48,6 +51,11 @@
     YAMLDimension,
     YAMLMeasure,
   } from "../visual-metrics-editing/lib";
+  import {
+    getAllowedGrainsFromOrder,
+    getGrainOrder,
+    V1TimeGrainToDateTimeUnit,
+  } from "@rilldata/web-common/lib/time/new-grains";
 
   const store = connectorExplorerStore.duplicateStore(
     (connector, database, schema, table) => {
@@ -207,6 +215,22 @@
     .filter(({ type }) => type && TIMESTAMPS.has(type))
     .map(({ name }) => ({ value: name ?? "", label: name ?? "" }));
 
+  $: typeOfSelectedTimeDimension = columns.find(
+    ({ name }) => name === timeDimension,
+  )?.type;
+
+  $: availableGrainOptions = getAllowedGrainsFromOrder(
+    typeOfSelectedTimeDimension === "DATE"
+      ? getGrainOrder(V1TimeGrain.TIME_GRAIN_DAY)
+      : getGrainOrder(V1TimeGrain.TIME_GRAIN_MINUTE),
+  ).map((grain) => {
+    const label = V1TimeGrainToDateTimeUnit[grain];
+    return {
+      value: label,
+      label: label.charAt(0).toUpperCase() + label.slice(1),
+    };
+  });
+
   /** display the main error (the first in this array) at the bottom */
   $: mainError = errors?.at(0);
 
@@ -637,10 +661,7 @@
         full
         truncate
         value={smallestTimeGrain}
-        options={Object.entries(TIME_GRAIN).map(([_, { label }]) => ({
-          value: label,
-          label: label.charAt(0).toUpperCase() + label.slice(1),
-        }))}
+        options={availableGrainOptions}
         placeholder="Select time grain"
         label="Smallest time grain"
         hint="The smallest time unit by which your charts and tables can be bucketed"