fix: leaderboard out of sync url state (#8785)

* fix: leaderboard out of sync url state

* update url tests

Author: djbarnwal

web-common/src/features/dashboards/leaderboard/LeaderboardRow.svelte

@@ -2,20 +2,20 @@
   import FormattedDataType from "@rilldata/web-common/components/data-types/FormattedDataType.svelte";
   import PercentageChange from "@rilldata/web-common/components/data-types/PercentageChange.svelte";
   import ExternalLink from "@rilldata/web-common/components/icons/ExternalLink.svelte";
+  import LeaderboardCell from "@rilldata/web-common/features/dashboards/leaderboard/LeaderboardCell.svelte";
   import { clamp } from "@rilldata/web-common/lib/clamp";
   import { formatMeasurePercentageDifference } from "@rilldata/web-common/lib/number-formatting/percentage-formatter";
   import { slide } from "svelte/transition";
   import { type LeaderboardItemData, makeHref } from "./leaderboard-utils";
-  import LeaderboardItemFilterIcon from "./LeaderboardItemFilterIcon.svelte";
-  import LongBarZigZag from "./LongBarZigZag.svelte";
   import {
     COMPARISON_COLUMN_WIDTH,
     DEFAULT_COLUMN_WIDTH,
-    valueColumn,
     deltaColumn,
     MEASURES_PADDING,
+    valueColumn,
   } from "./leaderboard-widths";
-  import LeaderboardCell from "@rilldata/web-common/features/dashboards/leaderboard/LeaderboardCell.svelte";
+  import LeaderboardItemFilterIcon from "./LeaderboardItemFilterIcon.svelte";
+  import LongBarZigZag from "./LongBarZigZag.svelte";
 
   export let itemData: LeaderboardItemData;
   export let dimensionName: string;
@@ -235,7 +235,7 @@
     {/if}
   </LeaderboardCell>
 
-  {#each Object.keys(values) as measureName, i (i)}
+  {#each leaderboardMeasureNames as measureName, i (i)}
     <LeaderboardCell
       value={values[measureName]?.toString() || ""}
       dataType="INTEGER"

web-common/src/features/dashboards/state-managers/actions/leaderboard.ts

@@ -7,6 +7,25 @@ export const setLeaderboardSortByMeasureName = (
 ) => {
   dashboard.leaderboardSortByMeasureName = name;
 
+  // Ensure leaderboardMeasureNames stays in sync with sort measure
+  // This prevents blank values when sorting by a measure that's not displayed
+  if (dashboard.leaderboardMeasureNames?.length > 0) {
+    const isMultiSelect = dashboard.leaderboardMeasureNames.length > 1;
+
+    if (isMultiSelect) {
+      // In multi-select mode: add sort measure if not already in the list
+      if (!dashboard.leaderboardMeasureNames.includes(name)) {
+        dashboard.leaderboardMeasureNames = [
+          name,
+          ...dashboard.leaderboardMeasureNames,
+        ];
+      }
+    } else {
+      // In single-select mode: replace with just the sort measure
+      dashboard.leaderboardMeasureNames = [name];
+    }
+  }
+
   // reset column widths when changing the leaderboard measure
   resetAllContextColumnWidths(dashboard.contextColumnWidths);
 };

web-common/src/features/dashboards/url-state/url-state-variations.spec.ts

@@ -45,15 +45,15 @@ import {
   AD_BIDS_SET_PREVIOUS_PERIOD_COMPARE_TIME_RANGE_FILTER,
   AD_BIDS_SET_PREVIOUS_WEEK_COMPARE_TIME_RANGE_FILTER,
   AD_BIDS_SET_PUBLISHER_COMPARE_DIMENSION,
+  AD_BIDS_SET_TIME_DIMENSION_OFFSET,
+  AD_BIDS_SET_TIME_DIMENSION_PRIMARY,
   AD_BIDS_SORT_ASC_BY_BID_PRICE,
   AD_BIDS_SORT_ASC_BY_IMPRESSIONS,
   AD_BIDS_SORT_BY_DELTA_ABS_VALUE,
   AD_BIDS_SORT_BY_PERCENT_VALUE,
   AD_BIDS_SORT_BY_VALUE,
   AD_BIDS_SORT_DESC_BY_BID_PRICE,
   AD_BIDS_SORT_DESC_BY_IMPRESSIONS,
-  AD_BIDS_SET_TIME_DIMENSION_OFFSET,
-  AD_BIDS_SET_TIME_DIMENSION_PRIMARY,
   AD_BIDS_SORT_PIVOT_BY_IMPRESSIONS_DESC,
   AD_BIDS_SORT_PIVOT_BY_TIME_DAY_ASC,
   AD_BIDS_SWITCH_TO_STACKED_BAR_IN_TDD,
@@ -304,7 +304,8 @@ const TestCases: {
     title:
       "Leaderboard configs with no preset and leaderboard sort measure in state different than default",
     mutations: [AD_BIDS_SORT_BY_DELTA_ABS_VALUE, AD_BIDS_SORT_ASC_BY_BID_PRICE],
-    expectedSearch: "sort_by=bid_price&sort_type=delta_abs&sort_dir=ASC",
+    expectedSearch:
+      "sort_by=bid_price&sort_type=delta_abs&sort_dir=ASC&leaderboard_measures=bid_price",
   },
   {
     title:
@@ -329,7 +330,7 @@ const TestCases: {
     ],
     preset: AD_BIDS_PRESET,
     expectedSearch:
-      "tr=P7D&tz=Asia%2FKathmandu&compare_tr=rill-PP&grain=day&measures=impressions&dims=publisher&sort_by=bid_price&sort_type=delta_abs",
+      "tr=P7D&tz=Asia%2FKathmandu&compare_tr=rill-PP&grain=day&measures=impressions&dims=publisher&sort_by=bid_price&sort_type=delta_abs&leaderboard_measures=bid_price",
   },
   {
     title: "Leaderboard configs with multiple measures",