Skip to content

Commit bbf74df

Browse files
committed
cancel offer improve
1 parent 68f8446 commit bbf74df

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

js/ripple/api.factory.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -435,14 +435,16 @@ myApp.factory('XrpApi', ['$rootScope', 'AuthenticationFactory', 'ServerManager',
435435
orderCancellation.memos = [{data: _client, type: 'client', format: 'text'}];
436436
return new Promise(async (resolve, reject) => {
437437
try {
438+
let ledger = await _remote.getLedger();
438439
let prepared = await _remote.prepareOrderCancellation(this.address, orderCancellation);
439-
const {signedTransaction} = AuthenticationFactory.sign(this, prepared.txJSON);
440+
const {signedTransaction, id} = AuthenticationFactory.sign(this, prepared.txJSON);
440441
let result = await _remote.submit(signedTransaction);
441-
if ("tesSUCCESS" !== result.engine_result) {
442+
this.verifyTx(id, ledger.ledgerVersion, prepared.instructions.maxLedgerVersion);
443+
if ("tesSUCCESS" !== result.engine_result && "terQUEUED" !== result.engine_result) {
442444
console.warn(result);
443445
return reject(new Error(result.engine_result_message || result.engine_result));
444446
}
445-
resolve(result);
447+
resolve(id);
446448
} catch (err) {
447449
console.error('cancelOffer', err);
448450
reject(err);

0 commit comments

Comments
 (0)